feat: add search_and_replace tool for batch text replacements #9549

hannesrudolph · 2025-11-24T23:20:06Z

Summary

Adds a new native search_and_replace tool that allows multiple search/replace operations in a single file edit, reducing round-trips for common editing patterns.

Changes

packages/types/src/tool.ts: Add search_and_replace to tool names
src/core/assistant-message/NativeToolCallParser.ts: Add parser support for the new tool
src/core/assistant-message/presentAssistantMessage.ts: Add message presentation handling
src/core/prompts/tools/native-tools/index.ts: Export the new tool schema
src/core/prompts/tools/native-tools/search_and_replace.ts: Define native tool schema
src/core/tools/SearchAndReplaceTool.ts: Main tool implementation with streaming support
src/shared/tools.ts: Add tool args type, display name, and group assignment

Features

Batch multiple search/replace operations in a single tool call
Partial matching support for graceful error handling
Individual operation error recovery (continues on partial failures)
Streaming support for real-time feedback
Integrated with existing diff view infrastructure

Testing

Manual testing needed
Unit tests to be added

Important

Add search_and_replace tool for batch text replacements with streaming support and error handling.

Behavior:
- Adds search_and_replace tool to tool.ts, NativeToolCallParser.ts, and presentAssistantMessage.ts.
- Implements main functionality in SearchAndReplaceTool.ts with support for streaming and error handling.
- Supports batch operations, partial matching, and error recovery.
Integration:
- Exports tool schema in index.ts and defines it in search_and_replace.ts.
- Validates tool use in validateToolUse.ts and updates modes.spec.ts for testing.
Testing:
- Adds test cases for tool inclusion and mode restrictions in modes.spec.ts.

^{This description was created by}^{for dc64f16. You can customize this summary. It will automatically update as commits are pushed.}

roomote · 2025-11-24T23:20:25Z

Oroocle Follow along on Roo Cloud

Re-review of the latest changes is complete. One follow-up item remains before this PR is ready to merge.

Add unit tests for the search_and_replace tool covering successful replacements, partial failures, write-protected files, and rooignore handling.

Previous reviews

f71b3c3: Review #1

7f2a48c: Review #2

7f2a48c: Review #3

7c6fb08: Review #4

e3fd37c: Review #5

0c48afc: Review #6

993c34b: Review #7

514b68c: Review #8

520354e: Review #9

8e8ef7e: Review #10

_{Mention @roomote in a comment to request specific changes to this pull request or fix all unresolved issues.}

roomote · 2025-11-24T23:34:55Z

src/core/tools/SearchAndReplaceTool.ts

+	operations: SearchReplaceOperation[]
+}
+
+export class SearchAndReplaceTool extends BaseTool<"search_and_replace"> {


This new native search_and_replace tool does not have any automated tests covering successful replacements, partial failures, or error paths. Since it can modify arbitrary user files, missing tests here increases the risk of regressions (for example around multi-operation flows, write-protected files, or rooignore handling); adding unit tests similar to the existing edit tools would make this safer to evolve.

_{Fix it with Roo Code or mention @roomote and request a fix.}

Adds a new native tool that allows multiple search/replace operations in a single file edit, reducing round-trips for common editing patterns. - Add search_and_replace to tool types and tool groups - Implement SearchAndReplaceTool with streaming support - Add native tool schema and parser support - Support partial matching and error recovery for individual operations

…cing the apply_diff.

- Add search_and_replace as a customTool in the edit group (opt-in only) - Fix tool name from 'apply_diff' to 'search_and_replace' in native tools - Add includedTools parameter to isToolAllowedForMode and validateToolUse - customTools are only allowed when explicitly included via modelInfo.includedTools - Pass includedTools from modelInfo in presentAssistantMessage for validation - Add tests for customTools functionality in modes.spec.ts This makes search_and_replace a standalone opt-in tool that doesn't replace apply_diff. Users can enable it via modelInfo.includedTools configuration.

roomote · 2025-11-27T20:25:53Z

Oroocle See task on Roo Cloud

Review updated for the latest PR state. One follow-up item remains for the new search_and_replace tool.

Add unit tests for the search_and_replace tool covering successful replacements, partial failures, write-protected files, and rooignore handling.

_{Mention @roomote in a comment to request specific changes to this pull request or fix all unresolved issues.}

roomote · 2025-11-27T20:27:11Z

src/core/tools/SearchAndReplaceTool.ts

+	operations: SearchReplaceOperation[]
+}
+
+export class SearchAndReplaceTool extends BaseTool<"search_and_replace"> {


This new search_and_replace tool performs batch edits on arbitrary user files but currently has no automated tests, which makes it easy to regress behavior like multi-operation flows, error aggregation, and protections around rooignore/write-protected files. Adding focused unit tests that cover successful single/multi-operation replacements, partial failures (some operations not matching or matching multiple times), and error paths around missing files or permission constraints would make future changes safer.

_{Fix it with Roo Code or mention @roomote and request a fix.}

This is fine for now

Does it correctly handle rooignore and files outside the workspace?

github-project-automation bot added this to Roo Code Roadmap and Roo Code Roadmap Nov 24, 2025

github-project-automation bot moved this to New in Roo Code Roadmap Nov 24, 2025

github-project-automation bot moved this to Triage in Roo Code Roadmap Nov 24, 2025

hannesrudolph force-pushed the feature/search-and-replace-tool branch 2 times, most recently from 6343d7a to 520354e Compare November 24, 2025 23:31

hannesrudolph added the Issue/PR - Triage New issue. Needs quick review to confirm validity and assign labels. label Nov 24, 2025

roomote bot reviewed Nov 24, 2025

View reviewed changes

hannesrudolph and others added 3 commits November 27, 2025 14:28

Temporary changes made to run evals with the search_and_replace repla…

311b625

…cing the apply_diff.

feat: make search_and_replace a custom tool (opt-in only)

993c34b

daniel-lxs force-pushed the feature/search-and-replace-tool branch from 514b68c to 993c34b Compare November 27, 2025 19:33

daniel-lxs added 4 commits November 27, 2025 15:12

refactor: rename apply_diff_single_file to apply_diff for consistency

e3fd37c

fix: update apply_diff type to remove unnecessary operations field

7c6fb08

fix: enforce required 'diff' field in apply_diff arguments

7f2a48c

daniel-lxs marked this pull request as ready for review November 27, 2025 20:24

daniel-lxs requested review from cte, jr and mrubens as code owners November 27, 2025 20:24

daniel-lxs moved this from Triage to PR [Needs Review] in Roo Code Roadmap Nov 27, 2025

dosubot bot added size:L This PR changes 100-499 lines, ignoring generated files. Enhancement New feature or request labels Nov 27, 2025

roomote bot reviewed Nov 27, 2025

View reviewed changes

hannesrudolph added PR - Needs Review and removed Issue/PR - Triage New issue. Needs quick review to confirm validity and assign labels. labels Nov 27, 2025

chore: remove Roo provider changes from search_and_replace PR

f71b3c3

mrubens approved these changes Nov 28, 2025

View reviewed changes

hannesrudolph merged commit e682c03 into main Nov 28, 2025
10 checks passed

hannesrudolph deleted the feature/search-and-replace-tool branch November 28, 2025 04:19

github-project-automation bot moved this from PR [Needs Review] to Done in Roo Code Roadmap Nov 28, 2025

github-project-automation bot moved this from New to Done in Roo Code Roadmap Nov 28, 2025

mini2s added a commit to zgsm-ai/costrict that referenced this pull request Nov 29, 2025

Roo to main (#718

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

feat: add search_and_replace tool for batch text replacements #9549

feat: add search_and_replace tool for batch text replacements #9549

Uh oh!

hannesrudolph commented Nov 24, 2025 •

edited by ellipsis-dev bot

Loading

Uh oh!

roomote bot commented Nov 24, 2025 •

edited

Loading

Uh oh!

roomote bot Nov 24, 2025

Uh oh!

roomote bot commented Nov 27, 2025 •

edited

Loading

Uh oh!

roomote bot Nov 27, 2025

Uh oh!

daniel-lxs Nov 27, 2025

Uh oh!

mrubens Nov 28, 2025

Uh oh!

Uh oh!

feat: add search_and_replace tool for batch text replacements #9549

feat: add search_and_replace tool for batch text replacements #9549

Uh oh!

Conversation

hannesrudolph commented Nov 24, 2025 • edited by ellipsis-dev bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Changes

Features

Testing

Uh oh!

roomote bot commented Nov 24, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

roomote bot Nov 24, 2025

Choose a reason for hiding this comment

Uh oh!

roomote bot commented Nov 27, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

roomote bot Nov 27, 2025

Choose a reason for hiding this comment

Uh oh!

daniel-lxs Nov 27, 2025

Choose a reason for hiding this comment

Uh oh!

mrubens Nov 28, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

hannesrudolph commented Nov 24, 2025 •

edited by ellipsis-dev bot

Loading

roomote bot commented Nov 24, 2025 •

edited

Loading

roomote bot commented Nov 27, 2025 •

edited

Loading