-
Notifications
You must be signed in to change notification settings - Fork 2.8k
Show the prompt for image gen #9505
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Review completed. The previously flagged issues remain unresolved in the latest commit.
Mention @roomote in a comment to request specific changes to this pull request or fix all unresolved issues. |
| <div className="px-3 py-2 bg-vscode-editor-background border border-vscode-editorGroup-border rounded"> | ||
| <div className="mb-2 break-words">{tool.content}</div> | ||
| <div className="text-xs text-vscode-descriptionForeground">{tool.path}</div> | ||
| </div> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The original CodeAccordian component likely provided click functionality to open the file (similar to other tool operations like readFile at line 636). This change removes that functionality - users can no longer click to open the target image file. Consider wrapping the path in a clickable element that calls vscode.postMessage({ type: "openFile", text: tool.path }) or using a ToolUseBlock component with proper click handlers.
Fix it with Roo Code or mention @roomote and request a fix.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You can still click to open, just tested to confirm
| <div className="px-3 py-2 bg-vscode-editor-background border border-vscode-editorGroup-border rounded"> | ||
| <div className="mb-2 break-words">{tool.content}</div> | ||
| <div className="text-xs text-vscode-descriptionForeground">{tool.path}</div> | ||
| </div> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This implementation creates an inconsistent UI pattern. Other similar tool operations like readFile (lines 616-651), newFileCreated (lines 559-589), and file edit operations (lines 393-443) use CodeAccordian or ToolUseBlock components for displaying file paths. These components provide consistent styling, interactive elements (expand/collapse, file opening), and visual consistency across the chat interface. The new plain div breaks this established pattern and creates a different look and feel specifically for image generation prompts.
Fix it with Roo Code or mention @roomote and request a fix.
Before:

After:

Important
Replaces
CodeAccordianwithToolUseBlockfor displaying image generation prompts inChatRow.tsx, enhancing readability and structure.CodeAccordianwithToolUseBlockfor 'generateImage' prompts inChatRow.tsx.This description was created by
for 2681d69. You can customize this summary. It will automatically update as commits are pushed.