Skip to content

Conversation

@mrubens
Copy link
Collaborator

@mrubens mrubens commented Nov 22, 2025

Before:
Screenshot 2025-11-22 at 10 34 01 AM

After:
Screenshot 2025-11-22 at 10 33 47 AM


Important

Replaces CodeAccordian with ToolUseBlock for displaying image generation prompts in ChatRow.tsx, enhancing readability and structure.

  • Behavior:
    • Replaces CodeAccordian with ToolUseBlock for 'generateImage' prompts in ChatRow.tsx.
    • Displays prompt content and path in a more structured format for 'ask' type messages.
  • UI:
    • Adjusts padding and text styles for better readability of image generation prompts.

This description was created by Ellipsis for 2681d69. You can customize this summary. It will automatically update as commits are pushed.

@mrubens mrubens requested review from cte and jr as code owners November 22, 2025 15:34
@dosubot dosubot bot added size:S This PR changes 10-29 lines, ignoring generated files. UI/UX UI/UX related or focused labels Nov 22, 2025
@roomote
Copy link
Contributor

roomote bot commented Nov 22, 2025

Rooviewer Clock   See task on Roo Cloud

Review completed. The previously flagged issues remain unresolved in the latest commit.

  • Missing click-to-open file functionality - The new implementation removes the ability to click and open the target image file
  • Inconsistent UI pattern - Other tool operations use CodeAccordian or ToolUseBlock components, creating visual inconsistency
Previous reviews

Mention @roomote in a comment to request specific changes to this pull request or fix all unresolved issues.

Comment on lines 1007 to 1010
<div className="px-3 py-2 bg-vscode-editor-background border border-vscode-editorGroup-border rounded">
<div className="mb-2 break-words">{tool.content}</div>
<div className="text-xs text-vscode-descriptionForeground">{tool.path}</div>
</div>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The original CodeAccordian component likely provided click functionality to open the file (similar to other tool operations like readFile at line 636). This change removes that functionality - users can no longer click to open the target image file. Consider wrapping the path in a clickable element that calls vscode.postMessage({ type: "openFile", text: tool.path }) or using a ToolUseBlock component with proper click handlers.

Fix it with Roo Code or mention @roomote and request a fix.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can still click to open, just tested to confirm

Comment on lines 1007 to 1010
<div className="px-3 py-2 bg-vscode-editor-background border border-vscode-editorGroup-border rounded">
<div className="mb-2 break-words">{tool.content}</div>
<div className="text-xs text-vscode-descriptionForeground">{tool.path}</div>
</div>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This implementation creates an inconsistent UI pattern. Other similar tool operations like readFile (lines 616-651), newFileCreated (lines 559-589), and file edit operations (lines 393-443) use CodeAccordian or ToolUseBlock components for displaying file paths. These components provide consistent styling, interactive elements (expand/collapse, file opening), and visual consistency across the chat interface. The new plain div breaks this established pattern and creates a different look and feel specifically for image generation prompts.

Fix it with Roo Code or mention @roomote and request a fix.

@hannesrudolph hannesrudolph added the Issue/PR - Triage New issue. Needs quick review to confirm validity and assign labels. label Nov 22, 2025
@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Nov 22, 2025
@mrubens mrubens merged commit cdc7275 into main Nov 22, 2025
10 checks passed
@mrubens mrubens deleted the show_image_gen_prompt branch November 22, 2025 16:04
@github-project-automation github-project-automation bot moved this from New to Done in Roo Code Roadmap Nov 22, 2025
@github-project-automation github-project-automation bot moved this from Triage to Done in Roo Code Roadmap Nov 22, 2025
@github-actions github-actions bot mentioned this pull request Nov 23, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Issue/PR - Triage New issue. Needs quick review to confirm validity and assign labels. lgtm This PR has been approved by a maintainer size:S This PR changes 10-29 lines, ignoring generated files. UI/UX UI/UX related or focused

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

4 participants