Skip to content

Conversation

@daniel-lxs
Copy link
Member

@daniel-lxs daniel-lxs commented Nov 21, 2025

Summary

This PR enhances the native tool descriptions to match the detail level of their XML counterparts by:

  • Extracting tool descriptions into separate constants for better maintainability
  • Adding detailed JSON examples showing proper usage for each tool
  • Including parameter explanations and usage clarifications from XML versions
  • Maintaining consistent structure across all tool definitions

Tools Enhanced (18 total)

  • apply_diff, ask_followup_question, attempt_completion
  • browser_action, codebase_search, execute_command
  • fetch_instructions, generate_image, insert_content
  • list_code_definition_names, list_files, new_task
  • read_file, run_slash_command, search_files
  • switch_mode, update_todo_list, write_to_file

Benefits

  • Better maintainability: Descriptions are now defined as constants, making updates easier
  • Enhanced details: Added important context from XML tools that was missing
  • Consistency: All tools follow the same pattern of extracting descriptions
  • Code clarity: Separation of concerns between descriptions and tool structure

Testing

✅ All tests pass (4192 passed, 4 skipped)
✅ All lint checks pass
✅ All type checks pass


Important

Enhances 18 native tool descriptions by extracting them into constants, adding JSON examples, and including parameter explanations for better maintainability and consistency.

  • Behavior:
    • Extracts tool descriptions into constants for maintainability.
    • Adds JSON examples and parameter explanations to tool descriptions.
    • Ensures consistent structure across all tool definitions.
  • Tools Enhanced:
    • apply_diff, ask_followup_question, attempt_completion.
    • browser_action, codebase_search, execute_command.
    • fetch_instructions, generate_image, insert_content.
    • list_code_definition_names, list_files, new_task.
    • read_file, run_slash_command, search_files.
    • switch_mode, update_todo_list, write_to_file.
  • Testing:
    • All tests pass (4192 passed, 4 skipped).
    • All lint checks pass.
    • All type checks pass.

This description was created by Ellipsis for 4bf256f. You can customize this summary. It will automatically update as commits are pushed.

- Extract tool descriptions into separate constants for better maintainability
- Add detailed JSON examples showing proper usage for each tool
- Include parameter explanations and usage clarifications from XML versions
- Maintain consistent structure across all tool definitions

Tools enhanced (18 total):
- apply_diff, ask_followup_question, attempt_completion
- browser_action, codebase_search, execute_command
- fetch_instructions, generate_image, insert_content
- list_code_definition_names, list_files, new_task
- read_file, run_slash_command, search_files
- switch_mode, update_todo_list, write_to_file

All tests passing (6/6 in native-tools/__tests__/)
@dosubot dosubot bot added the size:L This PR changes 100-499 lines, ignoring generated files. label Nov 21, 2025
@roomote
Copy link
Contributor

roomote bot commented Nov 21, 2025

Rooviewer Clock   See task on Roo Cloud

Review completed. All 18 tool enhancement files have been examined. The changes follow a consistent pattern of extracting descriptions into constants with helpful examples and clarifications. No issues found.

Mention @roomote in a comment to request specific changes to this pull request or fix all unresolved issues.

@dosubot dosubot bot added the Documentation Improvements or additions to documentation label Nov 21, 2025
@hannesrudolph hannesrudolph added the Issue/PR - Triage New issue. Needs quick review to confirm validity and assign labels. label Nov 21, 2025
@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Nov 22, 2025
@mrubens mrubens merged commit 513eebc into main Nov 22, 2025
22 checks passed
@mrubens mrubens deleted the enhance-native-tool-descriptions branch November 22, 2025 02:59
@github-project-automation github-project-automation bot moved this from Triage to Done in Roo Code Roadmap Nov 22, 2025
@github-project-automation github-project-automation bot moved this from New to Done in Roo Code Roadmap Nov 22, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Documentation Improvements or additions to documentation Issue/PR - Triage New issue. Needs quick review to confirm validity and assign labels. lgtm This PR has been approved by a maintainer size:L This PR changes 100-499 lines, ignoring generated files.

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

4 participants