Skip to content

Retry eval tasks if API instability detected #9365

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
cte merged 1 commit into from
Nov 18, 2025
Merged

Retry eval tasks if API instability detected #9365

cte merged 1 commit into from
Nov 18, 2025

Conversation

@cte
Copy link
Collaborator

@cte cte commented Nov 18, 2025 •
edited by ellipsis-dev bot
Loading

Important

Detects API instability in runTask() and triggers a retry if instability is detected by monitoring specific events.

  • Behavior:
    • Detects API instability in runTask() in runTask.ts by monitoring api_req_retry_delayed and api_req_retried events.
    • Sets isApiUnstable flag to true if instability detected.
    • Throws error at end of runTask() if isApiUnstable is true to trigger retry.
  • Events:
    • Adds api_req_retry_delayed and api_req_retried to loggableSays and monitors them in TaskEvent handler.

This description was created by Ellipsis for 603a60f. You can customize this summary. It will automatically update as commits are pushed.

@cte cte requested review from jr and mrubens as code owners November 18, 2025 19:32
@dosubot dosubot bot added size:S This PR changes 10-29 lines, ignoring generated files. Enhancement New feature or request labels Nov 18, 2025
@roomote
Copy link
Contributor

roomote bot commented Nov 18, 2025 •
edited
Loading

Rooviewer Clock   See task on Roo Cloud

Review complete. Found 2 issues to address:

  • Logger is closed before error is thrown, preventing proper error logging in calling function
  • User-aborted tasks will be retried if API instability is detected

Mention @roomote in a comment to request specific changes to this pull request or fix all unresolved issues.

roomote[bot]
roomote bot reviewed Nov 18, 2025
View reviewed changes
@cte cte merged commit 045c2d6 into main Nov 18, 2025
18 checks passed
@cte cte deleted the cte/retry-eval-tasks-if-api-unstable branch November 18, 2025 19:45
@github-project-automation github-project-automation bot moved this from Triage to Done in Roo Code Roadmap Nov 18, 2025
@github-project-automation github-project-automation bot moved this from New to Done in Roo Code Roadmap Nov 18, 2025
roomote[bot]
roomote bot reviewed Nov 18, 2025
View reviewed changes
packages/evals/src/cli/runTask.ts
logger.close()

if (isApiUnstable) {
throw new Error("API is unstable, throwing to trigger a retry.")
Copy link
Contributor

@roomote roomote bot Nov 18, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

User-aborted tasks should not trigger retries. If a task is aborted (likely user-initiated at line 303-305), the retry will be triggered anyway when API instability is detected. Consider checking taskAbortedAt to prevent retrying intentionally cancelled tasks.

Fix it with Roo Code or mention @roomote and request a fix.

@hannesrudolph hannesrudolph added the Issue/PR - Triage New issue. Needs quick review to confirm validity and assign labels. label Nov 18, 2025
mini2s added a commit to zgsm-ai/costrict that referenced this pull request Nov 19, 2025
@mini2s @heyseth
@Maosghoul @mrubens @daniel-lxs @kevint-cerebras @jr @roomote @ellipsis-dev @roomote @elianiva @hannesrudolph @github-actions @brunobergher @Thibault00 @requesty-JohnCosta27 @dmarkey @SannidhyaSah @cte @sebastiand-cerebras @dleffel @ajjuaire @renovate
Roo to main (#670