Skip to content

Conversation

@mrubens
Copy link
Collaborator

@mrubens mrubens commented Nov 18, 2025

Important

Add changeset and announcement for v3.33.0, update announcement ID, and modify announcement content in multiple languages.

  • Changeset:
    • Adds v3.33.0.md to .changeset/ with release notes and image.
  • Announcement:
    • Updates latestAnnouncementId in ClineProvider.ts to nov-2025-v3.33.0-gemini-native-tools.
    • Modifies announcement content in Announcement.tsx to include new features like Gemini 3, git status, and native tool calling.
  • Localization:
    • Updates announcement translations in chat.json files for multiple languages including it, ja, and ko.

This description was created by Ellipsis for ec271ec. You can customize this summary. It will automatically update as commits are pushed.

@mrubens mrubens requested review from cte and jr as code owners November 18, 2025 17:16
@dosubot dosubot bot added size:M This PR changes 30-99 lines, ignoring generated files. changelog-ready labels Nov 18, 2025
@roomote
Copy link
Contributor

roomote bot commented Nov 18, 2025

Rooviewer Clock   See task on Roo Cloud

Reviewed commit ec271ec. The URL path update from /create to /setup looks good. No issues found.

Previous reviews

Mention @roomote in a comment to request specific changes to this pull request or fix all unresolved issues.

@mrubens mrubens merged commit bb31b04 into main Nov 18, 2025
10 checks passed
@mrubens mrubens deleted the release/v3.33.0 branch November 18, 2025 17:26
@github-project-automation github-project-automation bot moved this from New to Done in Roo Code Roadmap Nov 18, 2025
@github-project-automation github-project-automation bot moved this from Triage to Done in Roo Code Roadmap Nov 18, 2025
@roomote
Copy link
Contributor

roomote bot commented Nov 18, 2025

Rooviewer Clock   Follow along on Roo Cloud

Reviewing your PR now. Feedback coming soon!

mini2s added a commit to zgsm-ai/costrict that referenced this pull request Nov 19, 2025
* fix: prevent MCP server restart when toggling tool permissions (RooCodeInc#8633)

* fix: prevent MCP server restart when toggling tool permissions

Add isProgrammaticUpdate flag to distinguish between programmatic config
updates and user-initiated file changes. Skip file watcher processing
during programmatic updates to prevent unnecessary server restarts.

* fix(mcp): prevent server reconnection when toggling disabled state

Fixed bug where MCP servers would reconnect instead of staying disabled when toggled off. The issue was that toggleServerDisabled() used stale in-memory config instead of reading the fresh config from disk after writing the disabled flag.

Changes:
Added readServerConfigFromFile() helper to read and validate server config from disk
Updated disable path to read fresh config before calling connectToServer()
Updated enable path to read fresh config before calling connectToServer()
This ensures the disabled: true flag is properly read, causing connectToServer() to create a disabled placeholder connection instead of actually connecting the server.

+ refactor(mcp): use safeWriteJson for atomic config writes

Replace JSON.stringify + fs.writeFile with safeWriteJson in McpHub.ts
to prevent data corruption through atomic writes with file locking.

* fix(mcp): prevent race condition in isProgrammaticUpdate flag

Replace multiple independent reset timers with a single timer that gets
cleared and rescheduled on each programmatic config update. This prevents
the flag from being reset prematurely when multiple rapid updates occur,
which could cause unwanted server restarts during the file watcher's
debounce period.

+ fix(mcp): ensure isProgrammaticUpdate flag cleanup with try-finally

Wrap safeWriteJson() calls in try-finally blocks to guarantee the
isProgrammaticUpdate flag is always reset, even if the write operation
fails. This prevents the flag from being stuck at true indefinitely,
which would cause subsequent user-initiated config changes to be
silently ignored.

* docs(readme): update readme images and image compression

* docs: replace inline base64 images with image file references

* Merge remote-tracking branch 'upstream/main' into roo-to-main

* feat(terminal): refactor execa command execution for shell handling

* Feat: Add Minimax Provider (fixes