Skip to content

Improve Google Gemini defaults, temperature, and cost reporting #9327

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
hannesrudolph merged 8 commits into from
Nov 18, 2025
Merged

Improve Google Gemini defaults, temperature, and cost reporting #9327

hannesrudolph merged 8 commits into from
Nov 18, 2025

Conversation

@hannesrudolph
Copy link
Collaborator

@hannesrudolph hannesrudolph commented Nov 18, 2025 •
edited
Loading

Summary:

  • Switch the default Gemini model to gemini-2.5-pro for higher‑quality responses by default.
  • Upgrade to the latest Google GenAI SDK to stay aligned with current Gemini APIs.
  • Increase the default Gemini temperature to 1 (when supported by the model), making generations more natural and less deterministic while still respecting model- and user-level overrides.
  • Remove several outdated Gemini models from the built-in model list to focus on current, supported options and simplify model selection.
  • Improve Gemini usage and cost accounting by correctly including reasoning/“thought” tokens in the billed output total for more accurate cost reporting.

@dosubot dosubot bot added size:XL This PR changes 500-999 lines, ignoring generated files. Enhancement New feature or request labels Nov 18, 2025
@roomote
Copy link
Contributor

roomote bot commented Nov 18, 2025 •
edited
Loading

Rooviewer Clock   See task on Roo Cloud

Re-review completed for commit 5782830. The defensive filtering for reasoning messages and countTokens refactoring introduce no new issues.

Existing issue remains:

  • Inconsistent requiredReasoningBudget flag between stable and preview gemini-2.5-pro models - the stable version requires reasoning budget while preview versions do not, which could lead to unexpected behavior when switching between model versions
Previous reviews

Mention @roomote in a comment to request specific changes to this pull request or fix all unresolved issues.

@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Nov 18, 2025
roomote[bot]
roomote bot reviewed Nov 18, 2025
View reviewed changes
@hannesrudolph hannesrudolph added the Issue/PR - Triage New issue. Needs quick review to confirm validity and assign labels. label Nov 18, 2025
mrubens
mrubens reviewed Nov 18, 2025
View reviewed changes
@hannesrudolph hannesrudolph merged commit f7c2e8d into main Nov 18, 2025
10 checks passed
@hannesrudolph hannesrudolph deleted the feature/gemini-cleanup branch November 18, 2025 06:38
@github-project-automation github-project-automation bot moved this from Triage to Done in Roo Code Roadmap Nov 18, 2025
@github-project-automation github-project-automation bot moved this from New to Done in Roo Code Roadmap Nov 18, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@roomote roomote[bot] roomote[bot] left review comments

@mrubens mrubens mrubens approved these changes

@cte cte Awaiting requested review from cte cte is a code owner

@jr jr Awaiting requested review from jr jr is a code owner

Assignees

No one assigned

Labels

Enhancement New feature or request Issue/PR - Triage New issue. Needs quick review to confirm validity and assign labels. lgtm This PR has been approved by a maintainer size:XL This PR changes 500-999 lines, ignoring generated files.

Projects

Roo Code Roadmap
Archived in project

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@hannesrudolph @mrubens