refactor: centralize toolProtocol configuration checks #9279
+34
−40
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Created src/utils/toolProtocol.ts with getToolProtocolFromSettings() utility - Replaced all direct vscode.workspace.getConfiguration() calls with centralized utility - Updated 6 files to use the new utility function - All tests pass and TypeScript compilation succeeds
dosubot
bot
added
the
size:M
Contributor
Review complete. No issues found. This PR successfully refactors tool protocol checks to use the Mention @roomote in a comment to request specific changes to this pull request or fix all unresolved issues. |
mrubens
approved these changes
Nov 15, 2025
![roomote[bot]](https://avatars.githubusercontent.com/in/1546624?s=60&v=4){kind=small}
github-project-automation
bot
moved this from PR [Needs Review]
to Done
in Roo Code Roadmap
mini2s
added a commit
to zgsm-ai/costrict
that referenced
this pull request
Nov 17, 2025
* refactor(tools): move imageHelpers to tools directory and update imports * Improve checkpoint menu translations for PR RooCodeInc#7841 (RooCodeInc#8796) Co-authored-by: Bruno Bergher <[email protected]> Co-authored-by: ellipsis-dev[bot] <65095814+ellipsis-dev[bot]@users.noreply.github.com> Co-authored-by: NaccOll <[email protected]> * Handle Roo provider pricing correctly (RooCodeInc#8802) * fix: preserve trailing newlines in stripLineNumbers for apply_diff (RooCodeInc#8227) Co-authored-by: Roo Code <[email protected]> Co-authored-by: Matt Rubens <[email protected]> * Fix checkpoints test (RooCodeInc#8803) * Chore: Update magistral-medium-latest in mistral.ts (RooCodeInc#8364) Co-authored-by: daniel-lxs <[email protected]> * fix: respect nested .gitignore files in search_files (RooCodeInc#8804) * fix(export): exclude max tokens field for models that don't support it (RooCodeInc#8464) * chore: add changeset for v3.29.0 (RooCodeInc#8806) Co-authored-by: ellipsis-dev[bot] <65095814+ellipsis-dev[bot]@users.noreply.github.com> * Changeset version bump (RooCodeInc#8807) Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: Matt Rubens <[email protected]> * fix: adjust GLM-4.6-turbo max output tokens to prevent context limit errors (RooCodeInc#8822) Co-authored-by: Roo Code <[email protected]> * fix: change Add to Context keybinding to avoid Redo conflict (RooCodeInc#8653) Co-authored-by: Roo Code <[email protected]> * feat: add Google Ads conversion tracking to reviewer page (RooCodeInc#8831) * feat: add Google Ads conversion tracking to reviewer page * fix: add asChild prop to first button to prevent invalid HTML nesting --------- Co-authored-by: Roo Code <[email protected]> Co-authored-by: daniel-lxs <[email protected]> * Fix provider model loading race conditions (RooCodeInc#8836) * Release v3.29.1 (RooCodeInc#8854) chore: add changeset for v3.29.1 * Changeset version bump (RooCodeInc#8855) * changeset version bump * Update CHANGELOG for version 3.29.1 release Updated version number and added release notes for 3.29.1. --------- Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: Matt Rubens <[email protected]> * Merge remote-tracking branch 'upstream/main' into roo-to-main * Fix caching logic in Roo provider (RooCodeInc#8860) * fix: Remove specific Claude model version from settings descriptions (RooCodeInc#8437) Co-authored-by: ellipsis-dev[bot] <65095814+ellipsis-dev[bot]@users.noreply.github.com> Co-authored-by: Roo Code <[email protected]> Co-authored-by: daniel-lxs <[email protected]> Co-authored-by: Daniel <[email protected]> * feat: add LongCat-Flash-Thinking-FP8 models to Chutes AI provider (RooCodeInc#8426) Co-authored-by: Roo Code <[email protected]> Co-authored-by: daniel-lxs <[email protected]> * Make sure not to show prices for free models (RooCodeInc#8864) * chore: add changeset for v3.29.2 (RooCodeInc#8865) * Changeset version bump (RooCodeInc#8866) Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: Matt Rubens <[email protected]> * fix: resolve checkpoint menu popover overflow (RooCodeInc#8867) * fix: process queued messages after context condensing completes (RooCodeInc#8478) Co-authored-by: Roo Code <[email protected]> * fix: use max_output_tokens when available in LiteLLM fetcher (RooCodeInc#8455) Co-authored-by: Roo Code <[email protected]> * Use monotonic clock for rate limiting (RooCodeInc#8456) * Fix LiteLLM test failures after merge (
Centralizes all
toolProtocolconfiguration checks into a single utility function.Changes
src/utils/toolProtocol.tswithgetToolProtocolFromSettings()utilityvscode.workspace.getConfiguration()calls across 6 filesTesting