Disable XML parser for native tool protocol #9277
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dosubot
bot
added
size:M
Contributor
Review completed. No new issues found. The PR correctly implements conditional parser initialization and abort controller support for request cancellation. All changes follow good practices and maintain proper null-safe access patterns. Mention @roomote in a comment to request specific changes to this pull request or fix all unresolved issues. |
hannesrudolph
added
the
Issue/PR - Triage
daniel-lxs
force-pushed
the
disable-xml-parser-for-native-tools
branch
from
17b2a3b to
73d2c5c
Compare
![roomote[bot]](https://avatars.githubusercontent.com/in/1546624?s=60&v=4){kind=small}
mrubens
reviewed
Nov 15, 2025
Comment on lines
+410
to
+412
| const toolProtocol = vscode.workspace.getConfiguration(Package.name).get<ToolProtocol>("toolProtocol", "xml") | ||
| this.assistantMessageParser = toolProtocol === "xml" ? new AssistantMessageParser() : undefined |
Collaborator
There was a problem hiding this comment.
As a follow-up I think we should probably centralize these toolProtocol checks into a single shared method that we import
mrubens
approved these changes
Nov 15, 2025
hannesrudolph
added
PR - Needs Review
and removed
Issue/PR - Triage
- Make assistantMessageParser optional (undefined for native protocol) - Only initialize parser when toolProtocol is 'xml' - Add conditional checks before calling parser methods - Handle native protocol text chunks separately from XML parsing This prevents unnecessary XML parsing when using native tool calls, which come as structured tool_call chunks instead of XML text.
daniel-lxs
force-pushed
the
disable-xml-parser-for-native-tools
branch
from
73d2c5c to
c6d315d
Compare
github-project-automation
bot
moved this from PR [Needs Review]
to Done
in Roo Code Roadmap
mini2s
added a commit
to zgsm-ai/costrict
that referenced
this pull request
Nov 17, 2025
This PR fixes the assistant message parser initialization to only use XML parsing when the tool protocol is set to 'xml'.
Problem
When using native tool protocol, models like Claude Sonnet were sometimes getting confused and attempting to use XML-formatted tool calls instead of the native tool format. The XML parser would then parse these incorrect tool calls, which further confused the model and created a feedback loop of incorrect tool usage.
Changes
Why
With native tool protocol, the model returns tool calls as structured tool_call chunks that don't require XML parsing. By disabling the XML parser for native protocol, we prevent the parser from inadvertently processing and validating malformed XML tool calls that the model might generate, eliminating the confusion feedback loop.
Important
Conditionally initialize
AssistantMessageParserinTask.tsbased ontoolProtocolto support both XML and native protocols.Task.ts,AssistantMessageParseris conditionally initialized based ontoolProtocolsetting.toolProtocolset to 'native',assistantMessageParseris set toundefined.toolProtocolset to 'xml',assistantMessageParseris initialized as before.?.) forassistantMessageParserinreset()andfinalizeContentBlocks()calls.recursivelyMakeClineRequests()to handle both XML and native protocols.presentAssistantMessage()logic to differentiate between XML and native text handling.This description was created by
for 73d2c5c. You can customize this summary. It will automatically update as commits are pushed.