Rooviewer   See task on Roo Cloud

Reviewed latest commit (8b6649a). Test changes correctly align with getRooReasoning() implementation.

Previous reviews

• e34e6b9: Review #1

_{Mention @roomote in a comment to request specific changes to this pull request or fix all unresolved issues.}

@roomote can you fix the tests? Do those need to be rolled back too?

@roomote can you fix the tests? Do those need to be rolled back too?

doing it now

Fixaroo   Follow along on Roo Cloud

Working on fixing the tests and determining if any changes need to be rolled back.

Fixaroo   See task on Roo Cloud

Investigation Results

The tests do not need to be rolled back - they are already correct for this revert PR.

What I Found

PR #9252 introduced capability-driven reasoning effort handling, including support for "minimal" as a distinct effort level. It updated:

• roo.spec.ts: Changed test to expect reasoning: { enabled: true, effort: "minimal" }
• SimpleThinkingBudget.spec.tsx: Added "minimal" translation and changed default from "None" to "Select"

PR #9258 (this PR) correctly reverts the out-of-scope changes:

• reasoning.ts (lines 74-77): Treats "minimal" as none, returning undefined instead of sending it as an effort
• roo.spec.ts (line 610): Updated test to expect reasoning to be undefined for minimal
• SimpleThinkingBudget.spec.tsx (line 192): Reverted to expect "None" as default, removed "minimal" translation

Test Results

✅ All tests pass:

• roo.spec.ts: 33/33 tests passing
• SimpleThinkingBudget.spec.tsx: 11/11 tests passing

Conclusion

The test changes in this PR are intentional and correct. They were updated to match the reverted code behavior, ensuring tests accurately reflect how the code now handles reasoning effort. No further rollback is needed.