OpenAI Native: gate encrypted_content include; remove gpt-5-chat-latest verbosity flag (fixes #9225) #9231
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…gEffort is set; prevent Responses API error on non-reasoning models. types: remove supportsVerbosity from gpt-5-chat-latest to avoid invalid verbosity error. Fixes #9225
dosubot
bot
added
size:XS
Contributor
Review completed. No issues found. The changes correctly address the reported bug by:
Both changes are minimal, focused, and properly implemented across streaming and non-streaming code paths. Mention @roomote in a comment to request specific changes to this pull request or fix all unresolved issues. |
![roomote[bot]](https://avatars.githubusercontent.com/in/1546624?s=60&v=4){kind=small}
mrubens
approved these changes
Nov 13, 2025
mini2s
added a commit
to zgsm-ai/costrict
that referenced
this pull request
Nov 17, 2025
* refactor(tools): move imageHelpers to tools directory and update imports * Improve checkpoint menu translations for PR RooCodeInc#7841 (RooCodeInc#8796) Co-authored-by: Bruno Bergher <[email protected]> Co-authored-by: ellipsis-dev[bot] <65095814+ellipsis-dev[bot]@users.noreply.github.com> Co-authored-by: NaccOll <[email protected]> * Handle Roo provider pricing correctly (RooCodeInc#8802) * fix: preserve trailing newlines in stripLineNumbers for apply_diff (RooCodeInc#8227) Co-authored-by: Roo Code <[email protected]> Co-authored-by: Matt Rubens <[email protected]> * Fix checkpoints test (RooCodeInc#8803) * Chore: Update magistral-medium-latest in mistral.ts (RooCodeInc#8364) Co-authored-by: daniel-lxs <[email protected]> * fix: respect nested .gitignore files in search_files (RooCodeInc#8804) * fix(export): exclude max tokens field for models that don't support it (RooCodeInc#8464) * chore: add changeset for v3.29.0 (RooCodeInc#8806) Co-authored-by: ellipsis-dev[bot] <65095814+ellipsis-dev[bot]@users.noreply.github.com> * Changeset version bump (RooCodeInc#8807) Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: Matt Rubens <[email protected]> * fix: adjust GLM-4.6-turbo max output tokens to prevent context limit errors (RooCodeInc#8822) Co-authored-by: Roo Code <[email protected]> * fix: change Add to Context keybinding to avoid Redo conflict (RooCodeInc#8653) Co-authored-by: Roo Code <[email protected]> * feat: add Google Ads conversion tracking to reviewer page (RooCodeInc#8831) * feat: add Google Ads conversion tracking to reviewer page * fix: add asChild prop to first button to prevent invalid HTML nesting --------- Co-authored-by: Roo Code <[email protected]> Co-authored-by: daniel-lxs <[email protected]> * Fix provider model loading race conditions (RooCodeInc#8836) * Release v3.29.1 (RooCodeInc#8854) chore: add changeset for v3.29.1 * Changeset version bump (RooCodeInc#8855) * changeset version bump * Update CHANGELOG for version 3.29.1 release Updated version number and added release notes for 3.29.1. --------- Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: Matt R
Reason
Changes
Fixes #9225
Important
Gate
encrypted_contentinclusion to whenreasoningEffortis set and remove verbosity support forgpt-5-chat-latest.encrypted_contentinclusion to whenreasoningEffortis set inOpenAiNativeHandler.buildRequestBody()andOpenAiNativeHandler.completePrompt().supportsVerbosityfromgpt-5-chat-latestinopenai.ts.openai-native.spec.tspass.This description was created by
for 46fc2e1. You can customize this summary. It will automatically update as commits are pushed.