Skip to content

Conversation

@roomote
Copy link
Contributor

@roomote roomote bot commented Nov 13, 2025

Description

This PR attempts to address Issue #9220 by removing legacy models from the AWS Bedrock provider configuration.

Changes Made

  • Removed Claude 2 series models that are no longer available in AWS Bedrock:

  • Removed Amazon Titan embedding models that shouldn't appear in model selection:

  • Updated test file to use instead of the removed

Testing

  • ✅ All tests pass for the modified test file
  • ✅ All Bedrock provider tests pass
  • ✅ Linting and type checking pass

Related Issue

Fixes #9220

Feedback and guidance are welcome!


Important

Remove legacy Claude 2 series and Amazon Titan embedding models from Bedrock provider configuration and update tests.

  • Behavior:
    • Removed legacy Claude 2 series models from bedrock.ts.
    • Removed Amazon Titan embedding models from bedrock.ts.
    • Updated test file bedrock-invokedModelId.spec.ts to reflect model removals.
  • Testing:
    • All tests pass for modified test file.
    • All Bedrock provider tests pass.
    • Linting and type checking pass.

This description was created by Ellipsis for 4e7ca64. You can customize this summary. It will automatically update as commits are pushed.

…provider

- Removed anthropic.claude-2-1-v1:0, anthropic.claude-2-0-v1:0, and anthropic.claude-instant-v1:0
- Removed amazon.titan-text-embeddings-v1:0 and amazon.titan-text-embeddings-v2:0
- Updated test to use Claude 3 Sonnet instead of removed Claude 2.1 model

Fixes #9220
@roomote roomote bot requested review from cte, jr and mrubens as code owners November 13, 2025 06:06
@dosubot dosubot bot added size:M This PR changes 30-99 lines, ignoring generated files. bug Something isn't working labels Nov 13, 2025
@roomote
Copy link
Contributor Author

roomote bot commented Nov 13, 2025

Rooviewer Clock   See task on Roo Cloud

Review completed. No issues found. The merge commit correctly resolves conflicts with main while preserving the PR's original goal of removing legacy Claude 2 and Titan embedding models. New models and features from main were properly incorporated.

Previous reviews

Mention @roomote in a comment to request specific changes to this pull request or fix all unresolved issues.

@hannesrudolph hannesrudolph added the Issue/PR - Triage New issue. Needs quick review to confirm validity and assign labels. label Nov 13, 2025
@github-project-automation github-project-automation bot moved this from New to Done in Roo Code Roadmap Jan 6, 2026
@github-project-automation github-project-automation bot moved this from Triage to Done in Roo Code Roadmap Jan 6, 2026
@hannesrudolph hannesrudolph reopened this Jan 6, 2026
@github-project-automation github-project-automation bot moved this from Done to New in Roo Code Roadmap Jan 6, 2026
@github-project-automation github-project-automation bot moved this from Done to Triage in Roo Code Roadmap Jan 6, 2026
@hannesrudolph hannesrudolph moved this from Triage to PR [Needs Review] in Roo Code Roadmap Jan 6, 2026
@roomote
Copy link
Contributor Author

roomote bot commented Jan 6, 2026

Rooviewer Clock   See task on Roo Cloud

Review completed. No issues found.

The changes correctly remove legacy models from the AWS Bedrock provider:

  • Claude 2 series models (no longer available in Bedrock)
  • Amazon Titan embedding models (not appropriate for model selection)

Test updates appropriately use Claude 3 Sonnet with correct pricing assertions.

Mention @roomote in a comment to request specific changes to this pull request or fix all unresolved issues.

@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Jan 6, 2026
@hannesrudolph
Copy link
Collaborator

@roomote fix the conflicts

@roomote
Copy link
Contributor Author

roomote bot commented Jan 6, 2026

Fixaroo Clock   See task on Roo Cloud

Resolved merge conflicts with main. All local checks passed.

View commit | Revert commit

@hannesrudolph hannesrudolph added PR - Needs Review and removed Issue/PR - Triage New issue. Needs quick review to confirm validity and assign labels. labels Jan 6, 2026
@github-actions
Copy link
Contributor

github-actions bot commented Jan 6, 2026

🚀 Preview deployed!

Your changes have been deployed to Vercel:

Preview URL: https://roo-code-website-8qwvnff9d-roo-code.vercel.app

This preview will be updated automatically when you push new commits to this PR.

@hannesrudolph
Copy link
Collaborator

@roomote can you just close this PR and make a new one addressing the original problem of the legacy claude 2 models? Your merge resolutions were not good at all.

@roomote
Copy link
Contributor Author

roomote bot commented Jan 7, 2026

Fixaroo Clock   See task on Roo Cloud

Closed this PR and created a fresh PR #10501 from main that properly removes the legacy Claude 2 models. All local checks passed.

View new PR | View commit

@roomote
Copy link
Contributor Author

roomote bot commented Jan 7, 2026

Closing this PR due to merge resolution issues. A fresh PR will be created to properly address issue #9220.

@roomote roomote bot closed this Jan 7, 2026
@github-project-automation github-project-automation bot moved this from New to Done in Roo Code Roadmap Jan 7, 2026
@github-project-automation github-project-automation bot moved this from PR [Needs Review] to Done in Roo Code Roadmap Jan 7, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working lgtm This PR has been approved by a maintainer PR - Needs Review size:M This PR changes 30-99 lines, ignoring generated files.

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

[ENHANCEMENT] Remove legacy model from bedrock provider

4 participants