Batch settings updates from the webview to the extension host #9165
Conversation
dosubot
bot
added
size:XL
All issues resolved. Changes look good.
Mention @roomote in a comment to request specific changes to this pull request or fix all unresolved issues. |
hannesrudolph
added
the
Issue/PR - Triage
![roomote[bot]](https://avatars.githubusercontent.com/in/1546624?s=60&v=4){kind=small}
![ellipsis-dev[bot]](https://avatars.githubusercontent.com/in/64358?s=60&v=4){kind=small}
| try { | ||
| if (!CloudService.instance.isCloudAgent) { | ||
| cloudOrganizations = await CloudService.instance.getOrganizationMemberships() | ||
| const now = Date.now() | ||
|
|
||
| if ( | ||
| this.cloudOrganizationsCache !== null && | ||
| this.cloudOrganizationsCacheTimestamp !== null && | ||
| now - this.cloudOrganizationsCacheTimestamp < ClineProvider.CLOUD_ORGANIZATIONS_CACHE_DURATION_MS | ||
| ) { | ||
| cloudOrganizations = this.cloudOrganizationsCache! | ||
| } else { | ||
| cloudOrganizations = await CloudService.instance.getOrganizationMemberships() | ||
| this.cloudOrganizationsCache = cloudOrganizations | ||
| this.cloudOrganizationsCacheTimestamp = now | ||
| } |
There was a problem hiding this comment.
The organization cache may store empty arrays from failed API calls for 5 minutes. When getOrganizationMemberships() returns an empty array due to an error (line 710 in WebAuthService.ts), this code caches it as valid data. Users won't see their actual organizations until the cache expires, even if the API becomes available again.
Consider checking if the result is a legitimate empty array (user has no orgs) vs an error case before caching, or add cache invalidation on auth state changes.
Fix it with Roo Code or mention @roomote and request a fix.
There was a problem hiding this comment.
@roomote Please fix this by throwing in getOrganizationMemberships instead of returning an empty array.
There was a problem hiding this comment.
Fixaroo
See task on Roo Cloud
Fixed the reported issue. All local checks passed.
dosubot
bot
removed
the
size:XL
dosubot
bot
added
the
size:XXL
hannesrudolph
added
PR - Needs Preliminary Review
and removed
Issue/PR - Triage
daniel-lxs
moved this from PR [Needs Prelim Review]
to PR [Needs Review]
in Roo Code Roadmap
github-project-automation
bot
moved this from PR [Needs Review]
to Done
in Roo Code Roadmap
Important
Batch updates settings using a single
updateSettingsmessage, refactoring components and tests for efficiency and consistency.updateSettingsmessage inwebviewMessageHandler.SettingsView,AutoApproveDropdown,CommandExecution,McpEnabledToggle, and other components to useupdateSettings.AutoApproveDropdownto useupdateSettingsfor toggling settings.CommandExecutionto update allowed/denied commands usingupdateSettings.McpEnabledToggleto useupdateSettingsfor toggling MCP.SettingsViewto batch update settings usingupdateSettings.CommandExecution.spec.tsxandSettingsView.spec.tsxto reflect changes in settings update mechanism.updateSettingsfor batch updates.This description was created by
for 697c12b. You can customize this summary. It will automatically update as commits are pushed.