-
Notifications
You must be signed in to change notification settings - Fork 2.8k
Move auto-approval from ChatView to Task
#9157
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Reviewed commit 62cc020. Clean test cleanup that properly removes obsolete tests for auto-approval logic that was moved from ChatView to Task. No new issues found.
Mention @roomote in a comment to request specific changes to this pull request or fix all unresolved issues. |
daniel-lxs
approved these changes
Nov 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Issue/PR - Triage
New issue. Needs quick review to confirm validity and assign labels.
lgtm
This PR has been approved by a maintainer
size:XXL
This PR changes 1000+ lines, ignoring generated files.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Test plan:
Important
Refactor auto-approval logic by moving it from
ChatViewtoTaskclass, centralizing command validation and tool action handling.ChatViewtoTaskclass.Taskclass handles auto-approval for commands, tools, and other actions.ChatViewfocuses on UI interactions, delegating logic toTask.ChatView.Taskclass.ChatView.spec.tsxto reflect new logic.Taskclass to ensure correct auto-approval behavior.ChatView.ChatViewcomponent by removing logic now handled byTask.This description was created by
for 62cc020. You can customize this summary. It will automatically update as commits are pushed.