Skip to content

feat: add Google Tag Manager to marketing website #9148

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
dleffel merged 3 commits into from
Nov 10, 2025
Merged

feat: add Google Tag Manager to marketing website #9148

dleffel merged 3 commits into from
Nov 10, 2025

Conversation

@roomote
Copy link
Contributor

@roomote roomote bot commented Nov 9, 2025 •
edited by ellipsis-dev bot
Loading

This PR adds Google Tag Manager (GTM-M2JZHV8N) to the marketing website to enable tracking and analytics capabilities.

Changes Made

  • Added Google Tag Manager script using Next.js Script component with afterInteractive strategy
  • Added Google Tag Manager noscript fallback for users with JavaScript disabled
  • Imported Script component from next/script to follow Next.js best practices

Implementation Details

  • GTM Container ID: GTM-M2JZHV8N
  • Script placement follows Google Tag Manager implementation guidelines
  • Using Next.js Script component to avoid ESLint warnings and ensure proper loading

Testing

  • Linting passes successfully
  • Type checking passes successfully
  • Implementation follows Next.js best practices for third-party scripts

Resolves: Slack request to add Google Tag Manager to the marketing website

Important

Adds Google Tag Manager to the marketing website, replacing Google Analytics, with GDPR-compliant consent handling.

  • Behavior:
    • Adds Google Tag Manager (GTM-M2JZHV8N) using GoogleTagManagerProvider in google-tag-manager-provider.tsx.
    • Removes GoogleAnalyticsProvider from providers.tsx and replaces it with GoogleTagManagerProvider.
    • Removes trackGoogleAdsConversion calls from AgentLandingContent.tsx.
  • Implementation:
    • Uses next/script for GTM script with afterInteractive strategy.
    • Includes noscript fallback for users with JavaScript disabled.
    • GTM loads only after user consent, following GDPR requirements.
  • Testing:
    • Linting and type checking pass successfully.

This description was created by Ellipsis for 003a8be. You can customize this summary. It will automatically update as commits are pushed.

@roomote roomote bot requested review from cte, jr and mrubens as code owners November 9, 2025 17:20
@dosubot dosubot bot added size:S This PR changes 10-29 lines, ignoring generated files. Enhancement New feature or request labels Nov 9, 2025
@roomote
Copy link
Contributor Author

roomote bot commented Nov 9, 2025 •
edited
Loading

Rooviewer Clock   See task on Roo Cloud

Re-review complete. The previous GDPR consent issue has been resolved - GTM now properly checks consent before loading.

  • GTM script loads unconditionally without checking user consent first (GDPR compliance issue)
Previous reviews

Mention @roomote in a comment to request specific changes to this pull request or fix all unresolved issues.

@github-actions
Copy link
Contributor

github-actions bot commented Nov 9, 2025

🚀 Preview deployed!

Your changes have been deployed to Vercel:

Preview URL: https://roo-code-website-8n0s6zo63-roo-code.vercel.app

This preview will be updated automatically when you push new commits to this PR.

@hannesrudolph hannesrudolph added the Issue/PR - Triage New issue. Needs quick review to confirm validity and assign labels. label Nov 9, 2025
@dleffel
Copy link
Collaborator

dleffel commented Nov 9, 2025

@roomote can you remove the previous Google Ads implementation, as I will set that up using Tag Manager going forward?

@roomote
Copy link
Contributor Author

roomote bot commented Nov 9, 2025

Fixaroo Clock   Follow along on Roo Cloud

Working on removing the previous Google Ads implementation from the marketing website.

@dleffel
Copy link
Collaborator

dleffel commented Nov 9, 2025

@roomote can you remove the previous Google Ads implementation, as I will set that up using Tag Manager going forward?

@roomote
Copy link
Contributor Author

roomote bot commented Nov 9, 2025 •
edited
Loading

Fixaroo Clock   See task on Roo Cloud

Removed Google Ads implementation. All local checks passed.

View commit | Revert commit

@dleffel
Copy link
Collaborator

dleffel commented Nov 9, 2025

@roomote can you remove the previous Google Ads implementation, as I will set that up using Tag Manager going forward?

@roomote
Copy link
Contributor Author

roomote bot commented Nov 9, 2025

Fixaroo Clock   Follow along on Roo Cloud

Working on removing the previous Google Ads implementation from the marketing website.

@dosubot dosubot bot added size:L This PR changes 100-499 lines, ignoring generated files. and removed size:S This PR changes 10-29 lines, ignoring generated files. labels Nov 9, 2025
roomote[bot]
roomote bot commented Nov 9, 2025
View reviewed changes
@roomote
Copy link
Contributor Author

roomote bot commented Nov 9, 2025 •
edited
Loading

Fixaroo Clock   See task on Roo Cloud

Fixed the GDPR consent issue by wrapping GTM in a client component that checks consent before loading. All local checks passed.

View commit | Revert commit

@roomote
Copy link
Contributor Author

roomote bot commented Nov 10, 2025 •
edited
Loading

Rooviewer Clock   See task on Roo Cloud

Re-review complete. The previous GDPR consent issue has been resolved - GTM now properly checks consent before loading.

  • GTM script loads unconditionally without checking user consent first (GDPR compliance issue)
Previous reviews

Mention @roomote in a comment to request specific changes to this pull request or fix all unresolved issues.

@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Nov 10, 2025
@dleffel dleffel merged commit 62636ad into main Nov 10, 2025
17 checks passed
@dleffel dleffel deleted the feat/add-google-tag-manager branch November 10, 2025 09:51
@github-project-automation github-project-automation bot moved this from New to Done in Roo Code Roadmap Nov 10, 2025
@github-project-automation github-project-automation bot moved this from Triage to Done in Roo Code Roadmap Nov 10, 2025
mini2s added a commit to zgsm-ai/costrict that referenced this pull request Nov 11, 2025
@mini2s @brunobergher
@mrubens @hannesrudolph @chrarnoldus @github-actions @roomote @roomote @laz-001 @cte @ellipsis-dev @mohammad154 @daniel-lxs @NaccOll @ThomsenDrake @elianiva @heyseth @Maosghoul @kevint-cerebras @jr @Thibault00 @requesty-JohnCosta27 @dmarkey @SannidhyaSah @sebastiand-cerebras @dleffel @ajjuaire @renovate
Roo to main (#636