-
Notifications
You must be signed in to change notification settings - Fork 2.8k
ux: Improvements to to-do lists and task headers #9096
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Review completed. Latest commit 1334429 removes a commented-out line referencing an unused parameter. All previously identified issues remain resolved. No new issues found.
Mention @roomote in a comment to request specific changes to this pull request or fix all unresolved issues. |
Co-authored-by: roomote[bot] <219738659+roomote[bot]@users.noreply.github.com>
Co-authored-by: roomote[bot] <219738659+roomote[bot]@users.noreply.github.com>
…tRow.tsx and TaskHeader.tsx
…o bb/visuals-todos
Review completed. All previously identified issues have been successfully resolved:
No new issues found. The PR is ready to merge. Mention @roomote in a comment to request specific changes to this pull request or fix all unresolved issues. |
|
|
||
| <div className="pl-1 pr-1 pt-1 font-light leading-normal"> | ||
| {todoGroups.map((group, index) => ( | ||
| <TodoList key={index} {...group} /> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Consider using a stable unique key (e.g. group.keyPrefix) instead of the array index when mapping over todoGroups. This helps ensure consistent rendering across re-renders.
| <TodoList key={index} {...group} /> | |
| <TodoList key={group.keyPrefix} {...group} /> |
| { | ||
| todos: startedTodos, | ||
| status: "in_progress", | ||
| keyPrefix: "started", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There is an inconsistent naming for the keyPrefix. In the initial state branch the in-progress group uses keyPrefix 'in-progress', but in the update branch it uses 'started'. If both refer to in-progress tasks, consider aligning the naming or adding a comment to clarify the distinction.
This is strictly UX-focused, with the aim of reducing visual noise and making to-do lists more useful. Changes include:
No functionality change (other than the shorter to-do-related messages in the chat.
Test Procedure
Screenshots / Videos
There many states, but these screenshots encapsulate the vast majority of what changes.
Important
Improves UX by redesigning to-do lists and task headers, integrating them for better focus and reduced visual noise, with various visual tweaks across the UI.
TodoChangeDisplayinChatRow.tsxto show changes in to-dos.LucideIconButtoninLucideIconButton.tsxfor consistent icon button styling.TaskHeader.tsxto integrate to-do list and adjust task info layout.index.cssfor mention highlights and other UI elements.This description was created by
for 431ab2e. You can customize this summary. It will automatically update as commits are pushed.