Skip to content

feat: add MiniMax-M2-Stable model and enable prompt caching #9072

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
cte merged 2 commits into from
Nov 6, 2025
Merged

feat: add MiniMax-M2-Stable model and enable prompt caching #9072

cte merged 2 commits into from
Nov 6, 2025

Conversation

@roomote
Copy link
Contributor

@roomote roomote bot commented Nov 6, 2025 •
edited by ellipsis-dev bot
Loading

Related GitHub Issue

Closes: #9070

Roo Code Task Context (Optional)

N/A - This PR was created by an automated workflow.

Description

This PR addresses the enhancement request to add the new MiniMax-M2-Stable model option and enable prompt caching support for MiniMax provider models.

Key implementation details:

  • Added MiniMax-M2-Stable model configuration with identical technical specs to MiniMax-M2
  • Enabled prompt caching for both MiniMax-M2 and MiniMax-M2-Stable models
  • Set cache pricing according to MiniMax documentation (reads: /bin/sh.03/M tokens, writes: /bin/sh.375/M tokens)
  • Updated model descriptions to distinguish between "Limited-time Free" (M2) and "High Concurrency, Commercial Use" (M2-Stable)
  • Added comprehensive test coverage for the new model and caching features

Test Procedure

Automated Tests:

  1. Run the MiniMax provider tests: 
    cd src && npx vitest run api/providers/__tests__/minimax.spec.ts
  2. Run TypeScript type checking: 
    cd packages/types && npx tsc --noEmit

Manual Verification:

  • The new MiniMax-M2-Stable model should appear in the model selection dropdown
  • Prompt caching should be enabled for both MiniMax models
  • Pricing information should reflect the correct cache read/write costs

All automated tests are passing (19 tests).

Pre-Submission Checklist

  • Issue Linked: This PR is linked to an approved GitHub Issue (see "Related GitHub Issue" above).
  • Scope: My changes are focused on the linked issue (one major feature/fix per PR).
  • Self-Review: I have performed a thorough self-review of my code.
  • Testing: New and/or updated tests have been added to cover my changes.
  • Documentation Impact: I have considered if my changes require documentation updates (see "Documentation Updates" section below).
  • Contribution Guidelines: I have read and agree to the Contributor Guidelines.

Screenshots / Videos

N/A - This is a backend change for model configuration.

Documentation Updates

  • No documentation updates are required.

The changes are self-documenting through the model configuration and descriptions.

Additional Notes

This implementation follows the pricing and specifications provided in the MiniMax official documentation:

Feedback and guidance are welcome!

Get in Touch

N/A - Automated workflow

Important

Add MiniMax-M2-Stable model and enable prompt caching for MiniMax models with updated tests.

  • Models:
    • Add MiniMax-M2-Stable model to minimax.ts with specs identical to MiniMax-M2.
    • Enable prompt caching for MiniMax-M2 and MiniMax-M2-Stable with specific cache pricing.
    • Update model descriptions to reflect usage and pricing.
  • Tests:
    • Add tests in minimax.spec.ts to verify MiniMax-M2-Stable configuration and prompt caching.
    • Ensure tests cover model selection, pricing, and caching behavior.

This description was created by Ellipsis for 7a93d2d. You can customize this summary. It will automatically update as commits are pushed.

@roomote
feat: add MiniMax-M2-Stable model and enable prompt caching
7a93d2d 
- Add MiniMax-M2-Stable model for high concurrency commercial use
- Enable prompt caching for both MiniMax-M2 and MiniMax-M2-Stable models
- Update pricing information for cache reads (0.03/M tokens) and writes (0.375/M tokens)
- Update tests to cover new model and caching support

Fixes #9070
@roomote roomote bot requested review from cte, jr and mrubens as code owners November 6, 2025 09:41
@dosubot dosubot bot added size:M This PR changes 30-99 lines, ignoring generated files. Enhancement New feature or request labels Nov 6, 2025
@roomote
Copy link
Contributor Author

roomote bot commented Nov 6, 2025 •
edited
Loading

Rooviewer Clock   See task on Roo Cloud

Re-review complete. Latest changes look good - the description update is a minor documentation improvement with no functional impact.

The implementation correctly:

  • Adds the MiniMax-M2-Stable model with identical specs to MiniMax-M2
  • Enables prompt caching for both MiniMax models
  • Updates pricing information according to MiniMax documentation
  • Includes comprehensive test coverage for the new model
  • Follows existing code patterns and type definitions
Previous reviews

Mention @roomote to ask your PR Fixer agent to address the feedback.

@hannesrudolph hannesrudolph added the Issue/PR - Triage New issue. Needs quick review to confirm validity and assign labels. label Nov 6, 2025
@roomote roomote bot mentioned this pull request Nov 6, 2025
Closed
2 tasks
@nokaka nokaka mentioned this pull request Nov 6, 2025
Merged
@daniel-lxs
Update MiniMax M2 description
737f61a 
Removed 'Limited-time Free' from MiniMax M2 description.
@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Nov 6, 2025
@daniel-lxs daniel-lxs moved this from Triage to PR [Needs Review] in Roo Code Roadmap Nov 6, 2025
@hannesrudolph hannesrudolph added PR - Needs Review and removed Issue/PR - Triage New issue. Needs quick review to confirm validity and assign labels. labels Nov 6, 2025
@cte cte merged commit bf04849 into main Nov 6, 2025
15 checks passed
@cte cte deleted the feat/minimax-stable-model-and-caching branch November 6, 2025 20:34
@github-project-automation github-project-automation bot moved this from New to Done in Roo Code Roadmap Nov 6, 2025
@github-project-automation github-project-automation bot moved this from PR [Needs Review] to Done in Roo Code Roadmap Nov 6, 2025
mini2s added a commit to zgsm-ai/costrict that referenced this pull request Nov 7, 2025
@mini2s @mrubens
@brunobergher @roomote @github-actions @roomote @SannidhyaSah @jr @cte @ColbySerpa @PeterDaveHello @daniel-lxs @hassoncs @hannesrudolph @chrarnoldus @laz-001 @ellipsis-dev @mohammad154 @NaccOll @ThomsenDrake @elianiva @heyseth @Maosghoul @kevint-cerebras @Thibault00 @requesty-JohnCosta27 @dmarkey @sebastiand-cerebras @dleffel @ajjuaire @renovate
Roo to main (#628