feat: add conditional test running to pre-push hook #9055
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Load .env.local environment variables if file exists - Run tests via 'pnpm run test' when RUN_TESTS_ON_PUSH=true - Users can control test execution by setting RUN_TESTS_ON_PUSH in .env.local
dosubot
bot
added
size:S
Contributor
|
Review complete. Found 1 security issue that needs to be addressed before merging.
Mention @roomote in a comment to trigger your PR Fixer agent and make changes to this pull request. |
mrubens
approved these changes
Nov 5, 2025
github-project-automation
bot
moved this from PR [Needs Review]
to Done
in Roo Code Roadmap
![roomote[bot]](https://avatars.githubusercontent.com/in/1546624?s=60&v=4){kind=small}
Comment on lines
+21
to
+24
| # Load .env.local if it exists | ||
| if [ -f ".env.local" ]; then | ||
| export $(grep -v '^#' .env.local | xargs) | ||
| fi |
Contributor
There was a problem hiding this comment.
Shell injection vulnerability: The export $(grep -v '^#' .env.local | xargs) pattern is unsafe when .env.local contains values with shell metacharacters (semicolons, backticks, command substitutions). For example, RUN_TESTS_ON_PUSH=true; rm -rf / would execute the deletion command. Use set -a; source .env.local; set +a instead, or properly quote and validate each variable before export.
Fix it with Roo Code or mention @roomote and request a fix.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Adds the ability to conditionally run tests during the pre-push hook using a
.env.localenvironment variable.Changes
.husky/pre-pushto load.env.localif it existsRUN_TESTS_ON_PUSH=truepnpm run testcommand (turbo) to run all tests across the monorepoRUN_TESTS_ON_PUSHis not set or falseUsage
Create or update
.env.local:Benefits