feat: optimize router model fetching with single-provider filtering #8956

daniel-lxs · 2025-10-31T16:34:41Z

Problem

The existing PRs #8916 and #8917 implemented provider filtering but used an array-based approach. Per mrubens' feedback, this should be simplified to use a single provider filter instead.

Solution

This PR combines and improves upon #8916 and #8917 by:

Simplified API: Uses single provider: string instead of providers: string[]
Type Reuse: Leverages existing isDynamicProvider from @roo-code/types instead of duplicating provider lists
Cleaner Code: Removes backward compatibility complexity and debug logging
Better Performance: Reduces payload sizes and eliminates unnecessary fetches

Changes

Backend (`src/core/webview/webviewMessageHandler.ts`)

Changed from providers array to single provider string filter
Simplified filtering logic using providerFilter instead of requestedSet
Maintained backward compatibility (no filter = fetch all)

Frontend (`webview-ui/src/components/ui/hooks/`)

useRouterModels: Updated to accept single provider option
useSelectedModel: Uses isDynamicProvider from types to determine when to fetch
Removed all console.debug logging
Gates router model fetches entirely for static providers

Tests

Updated backend test to verify single-provider filtering
Updated frontend tests to reflect gated behavior for static providers

Impact

Before:

Frontend could request all providers or a filtered array
Custom DYNAMIC_ROUTER_PROVIDERS constant duplicated type info
Debug logging cluttered console

After:

Cleaner single-provider API
Reuses existing type definitions
No debug logging
Static providers (anthropic, openai-native, etc.) skip router fetches entirely
Dynamic providers fetch only their own models

Addresses mrubens' Comments

✅ PR #8916: "Is there a reason for this filter to be an array?" - Now uses single provider
✅ PR #8916: "...make a function that only fetches one...Or just do it all in one PR" - Combined in one PR with simplified API
✅ PR #8917: "isn't this already in the types somewhere?" - Now uses isDynamicProvider from types
✅ PR #8917: "Can we remove this debug logging?" - All debug logging removed

Testing

✅ Backend tests pass (3/3)
✅ Frontend tests pass (14/14)
✅ Type checking passes

Closes #8916
Closes #8917

Important

Optimize router model fetching by switching to single-provider filtering, improving performance and simplifying code.

Behavior:
- Switch from providers: string[] to provider: string in webviewMessageHandler.ts for filtering router models.
- Simplifies logic by using providerFilter instead of requestedSet.
- Maintains backward compatibility by fetching all if no filter is provided.
Frontend:
- useRouterModels in useRouterModels.ts now accepts a single provider and an enabled flag.
- useSelectedModel in useSelectedModel.ts updated to use isDynamicProvider and gate fetches for static providers.
Tests:
- Add tests in webviewMessageHandler.routerModels.spec.ts to verify single-provider filtering.
- Update useSelectedModel.spec.ts to reflect changes in loading and error states for static providers.

^{This description was created by}^{for 9dac237. You can customize this summary. It will automatically update as commits are pushed.}

- Simplify backend to use single provider filter instead of array - Use existing isDynamicProvider from @roo-code/types instead of duplicating - Update frontend to request only the needed provider - Gate router model fetches entirely for static providers - Remove unnecessary debug logging - Update tests to reflect new behavior This combines and improves upon PRs #8916 and #8917 by: 1. Using a simpler single-provider API (provider: string instead of providers: string[]) 2. Leveraging existing type definitions from packages/types 3. Eliminating race conditions through simpler request/response matching 4. Reducing payload sizes and network usage Closes #8916 Closes #8917

roomote · 2025-10-31T16:35:02Z

Review Summary

I've reviewed the latest changes to this PR. The critical issue from the previous review has been resolved.

Issues Found

Critical: Response matching bug in useRouterModels - Fixed in commit 9dac237. The backend now correctly includes the provider in the response values.

Status

All issues have been addressed. The PR is ready for merge.

Follow Along on Roo Code Cloud

Previous Reviews

4396aa6: Review #1

roomote · 2025-10-31T16:36:47Z

webview-ui/src/components/ui/hooks/useRouterModels.ts

+				const msgProvider = message?.values?.provider as string | undefined
+
+				// Verify response matches request
+				if (provider !== msgProvider) {
+					// Not our response; ignore and wait for the matching one
+					return
+				}


Critical bug: The backend never includes the provider in the response values, so msgProvider will always be undefined. When a provider filter is used (e.g., provider="roo"), the check provider !== msgProvider evaluates to "roo" !== undefined, which is always true, causing the response to be ignored indefinitely. The promise will timeout after 10 seconds, breaking router model fetching for all dynamic providers. The backend needs to include the provider in the response: provider.postMessageToWebview({ type: "routerModels", routerModels, values: { provider: requestedProvider } })

roomote

Cannot approve due to critical issue found. The response matching bug must be fixed before this PR can be merged.

The frontend needs the provider in message.values.provider to match requests with responses. Without this, all filtered requests would timeout after 10 seconds.

* Correct tool use suggestion to improve model adherence to suggestion (RooCodeInc#8315) * Correct tool use suggestion to improve model adherence to suggestion * tweak * removing user hint when refreshing models (RooCodeInc#7710) * feat(zgsm): add quota info display and periodic updates * Show the Roo provider on the welcome screen (RooCodeInc#8317) * wip: Website Improvements (RooCodeInc#8303) Co-authored-by: Matt Rubens <[email protected]> * refactor: remove pr-reviewer mode (RooCodeInc#8222) * feat: add animated quota display with staggered transitions * Merge remote-tracking branch 'upstream/main' into roo-to-main * web: More website copy tweaks (RooCodeInc#8326) Co-authored-by: Matt Rubens <[email protected]> * fix: remove <thinking> tags from prompts for cleaner output and fewer tokens (RooCodeInc#8319) Co-authored-by: Roo Code <[email protected]> Co-authored-by: Hannes Rudolph <[email protected]> * Upgrade Supernova (RooCodeInc#8330) * chore: add changeset for v3.28.9 (RooCodeInc#8336) * Changeset ver

daniel-lxs requested review from cte, jr and mrubens as code owners October 31, 2025 16:34

github-project-automation bot added this to Roo Code Roadmap and Roo Code Roadmap Oct 31, 2025

github-project-automation bot moved this to New in Roo Code Roadmap Oct 31, 2025

github-project-automation bot moved this to Triage in Roo Code Roadmap Oct 31, 2025

dosubot bot added size:L This PR changes 100-499 lines, ignoring generated files. Enhancement New feature or request labels Oct 31, 2025

daniel-lxs mentioned this pull request Oct 31, 2025

feat: Add provider filtering support to router models backend #8916

Closed

daniel-lxs mentioned this pull request Oct 31, 2025

feat: Add provider-scoped router model fetches in frontend #8917

Closed

roomote bot reviewed Oct 31, 2025

View reviewed changes

fix: include provider in response values for request/response matching

9dac237

The frontend needs the provider in message.values.provider to match requests with responses. Without this, all filtered requests would timeout after 10 seconds.

hannesrudolph added the Issue/PR - Triage New issue. Needs quick review to confirm validity and assign labels. label Oct 31, 2025

roomote bot approved these changes Oct 31, 2025

View reviewed changes

daniel-lxs moved this from Triage to PR [Needs Review] in Roo Code Roadmap Oct 31, 2025

hannesrudolph added PR - Needs Review and removed Issue/PR - Triage New issue. Needs quick review to confirm validity and assign labels. labels Oct 31, 2025

mrubens approved these changes Nov 2, 2025

View reviewed changes

dosubot bot added the lgtm This PR has been approved by a maintainer label Nov 2, 2025

mrubens merged commit 31de103 into main Nov 2, 2025
17 checks passed

mrubens deleted the feat/combined-provider-filtering branch November 2, 2025 05:04

github-project-automation bot moved this from New to Done in Roo Code Roadmap Nov 2, 2025

github-project-automation bot moved this from PR [Needs Review] to Done in Roo Code Roadmap Nov 2, 2025

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

feat: optimize router model fetching with single-provider filtering #8956

feat: optimize router model fetching with single-provider filtering #8956

Uh oh!

daniel-lxs commented Oct 31, 2025 •

edited by ellipsis-dev bot

Loading

Uh oh!

roomote bot commented Oct 31, 2025 •

edited

Loading

Uh oh!

roomote bot Oct 31, 2025

Uh oh!

roomote bot left a comment

Uh oh!

Uh oh!

feat: optimize router model fetching with single-provider filtering #8956

feat: optimize router model fetching with single-provider filtering #8956

Uh oh!

Conversation

daniel-lxs commented Oct 31, 2025 • edited by ellipsis-dev bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Problem

Solution

Changes

Backend (src/core/webview/webviewMessageHandler.ts)

Frontend (webview-ui/src/components/ui/hooks/)

Tests

Impact

Addresses mrubens' Comments

Testing

Uh oh!

roomote bot commented Oct 31, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Review Summary

Issues Found

Status

Uh oh!

roomote bot Oct 31, 2025

Choose a reason for hiding this comment

Uh oh!

roomote bot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

daniel-lxs commented Oct 31, 2025 •

edited by ellipsis-dev bot

Loading

Backend (`src/core/webview/webviewMessageHandler.ts`)

Frontend (`webview-ui/src/components/ui/hooks/`)

roomote bot commented Oct 31, 2025 •

edited

Loading