fix: remove search_and_replace tool from codebase #8892

roomote · 2025-10-28T19:22:05Z

Summary

This PR addresses Issue #8891 by completely removing the search_and_replace tool from the codebase.

Changes Made

Core Implementation

Deleted src/core/tools/searchAndReplaceTool.ts - the main implementation file
Removed tool execution handling from presentAssistantMessage.ts
Removed tool from type definitions in packages/types/src/tool.ts

Type System & Interfaces

Removed SearchAndReplaceToolUse interface from src/shared/tools.ts
Removed tool from TOOL_GROUPS and TOOL_DISPLAY_NAMES
Removed from ExtensionMessage.ts tool types

Prompt System

Deleted tool description file src/core/prompts/tools/search-and-replace.ts
Removed references from prompt index and mapping
Removed from system rules and response formatting guidance

UI & Localization

Removed case handling from ChatRow.tsx component
Removed all localization strings from 18 language files
Cleaned up experimental feature flags

Tests

Removed references from mode restriction tests
Updated 13 snapshot files to reflect prompt changes
Note: E2E tests were already marked as skipped

Testing

✅ TypeScript compilation passes
✅ All tests pass with updated snapshots
✅ Linting passes

Impact

This is a breaking change that removes a feature. The search_and_replace tool will no longer be available to users. Other editing tools (apply_diff, write_to_file, insert_content) remain available for file modifications.

Closes #8891

Important

Remove search_and_replace tool from codebase, affecting core implementation, type system, UI, and tests.

Core Implementation:
- Deleted searchAndReplaceTool.ts.
- Removed tool handling from presentAssistantMessage.ts.
- Removed tool from tool.ts type definitions.
Type System & Interfaces:
- Removed SearchAndReplaceToolUse interface from tools.ts.
- Removed tool from TOOL_GROUPS and TOOL_DISPLAY_NAMES.
- Removed from ExtensionMessage.ts tool types.
Prompt System:
- Deleted search-and-replace.ts description file.
- Removed references from prompt index and mapping.
- Removed from system rules and response formatting guidance.
UI & Localization:
- Removed case handling from ChatRow.tsx.
- Removed localization strings from 18 language files.
- Cleaned up experimental feature flags.
Tests:
- Removed references from mode restriction tests.
- Updated 13 snapshot files to reflect prompt changes.
- Deleted search-and-replace.test.ts file.
Misc:
- Removed tool references from XML rule files.

^{This description was created by}^{for 2017d37. You can customize this summary. It will automatically update as commits are pushed.}

- Deleted src/core/tools/searchAndReplaceTool.ts - Removed import and case handling from presentAssistantMessage.ts - Removed from toolNames array in packages/types/src/tool.ts - Removed SearchAndReplaceToolUse interface from src/shared/tools.ts - Deleted src/core/prompts/tools/search-and-replace.ts - Removed from tool description map in prompts/tools/index.ts - Removed from prompts rules and responses - Removed from test files - Snapshot files will be regenerated on test run Fixes #8891

… and ExtensionMessage

roomote · 2025-10-28T19:22:27Z

PR Review Update

I've reviewed the latest changes and confirmed that all previously identified issues have been successfully resolved.

All Issues Resolved ✅

Incomplete removal of search_and_replace properties in ClineSayTool interface - Successfully removed all 6 orphaned properties (search, replace, useRegex, ignoreCase, startLine, endLine) from src/shared/ExtensionMessage.ts in commit 2017d37

Recent Improvements

✅ Removed obsolete E2E test file apps/vscode-e2e/src/suite/tools/search-and-replace.test.ts
✅ Removed orphaned properties from ClineSayTool interface
✅ Removed references from .roo/rules-issue-fixer/1_Workflow.xml
✅ Removed references from .roo/rules-merge-resolver/2_best_practices.xml
✅ Removed references from .roo/rules-merge-resolver/3_tool_usage.xml
✅ Cleaned up UI filtering in webview-ui/src/components/chat/ChatView.tsx

What Was Done Well (from previous reviews)

✅ Core implementation file deleted (src/core/tools/searchAndReplaceTool.ts)
✅ Tool execution handling removed from presentAssistantMessage.ts
✅ Tool removed from type definitions in packages/types/src/tool.ts
✅ Tool description file deleted and references removed from prompt system
✅ UI handling removed from ChatRow.tsx
✅ All localization strings removed from 18 language files
✅ Test files updated appropriately
✅ Snapshot files regenerated

Verification Complete

No remaining runtime references to search_and_replace tool
Remaining mentions are only historical (CHANGELOG.md) or unrelated (apply_diff documentation)
All changes are consistent with the goal of completely removing the tool

This PR has successfully accomplished its goal of completely removing the search_and_replace tool from the codebase.

Follow Along on Roo Code Cloud

roomote

No issues found beyond what was already noted in the review summary.

hannesrudolph · 2025-10-28T21:11:14Z

@roomote run PR Fixeer mode on this PR

roomote · 2025-10-28T21:14:14Z

ACK: Starting PR Fixer mode on this PR. Plan:

Check out branch fix/remove-search-and-replace-tool
Scan repo for any remaining references to search_and_replace/search-and-replace
Build and run tests locally, fix breakages
Push fixes to the PR branch and monitor CI
I will post a summary after the checks pass.

…ce tool (UI + rules)

roomote

Review complete. The recent changes successfully cleaned up additional references to search_and_replace in rule files and UI code. However, there is still one outstanding issue that needs to be addressed before this PR can be approved (see the updated checklist in my top-level comment).

roomote · 2025-10-28T21:39:45Z

PR Fixer summary:

Changes applied on branch fix/remove-search-and-replace-tool:

Removed residual references to the removed tool
- webview-ui/src/components/chat/ChatView.tsx — removed "searchAndReplace" from write tool detection list
- .roo/rules-merge-resolver/2_best_practices.xml — removed mention of search_and_replace in best practices
- .roo/rules-merge-resolver/3_tool_usage.xml — dropped search_and_replace tool section and priority; updated guidance to prefer apply_diff
- .roo/rules-issue-fixer/1_Workflow.xml — removed search_and_replace from recommended tools

Repository scan results:

No remaining runtime references to search_and_replace
Remaining mentions are historical in CHANGELOG.md and a skipped e2e file apps/vscode-e2e/src/suite/tools/search-and-replace.test.ts

Local verification:

Webview UI tests: pass (93 passed, 6 skipped)
Lint and type checks passed during commit

CI status:

All checks reported as passing: compile, analyze, CodeQL, translations, knip, integration tests, platform unit tests (ubuntu and windows)

Commit pushed:

201c1f4 — fixes above

This PR is now consistent with removal of the search_and_replace tool and ready for review and merge.

roomote

All previously identified issues have been resolved. The PR successfully completes the removal of the search_and_replace tool from the codebase.

hannesrudolph · 2025-10-31T02:49:00Z

Is roomote’s feedback valid?

They were. Fixed.

roomote added 4 commits October 28, 2025 19:07

test: update snapshots after removing search_and_replace tool

9b993ef

fix: remove remaining search_and_replace references from localization…

7d42021

… and ExtensionMessage

fix: remove searchAndReplace case from ChatRow.tsx

b1c1751

roomote bot requested review from cte, jr and mrubens as code owners October 28, 2025 19:22

github-project-automation bot added this to Roo Code Roadmap and Roo Code Roadmap Oct 28, 2025

github-project-automation bot moved this to New in Roo Code Roadmap Oct 28, 2025

github-project-automation bot moved this to Triage in Roo Code Roadmap Oct 28, 2025

dosubot bot added the size:L This PR changes 100-499 lines, ignoring generated files. label Oct 28, 2025

roomote bot commented Oct 28, 2025

View reviewed changes

roomote bot mentioned this pull request Oct 28, 2025

[ENHANCEMENT] Remove search_and_replace tool and all references #8891

Closed

hannesrudolph added the Issue/PR - Triage New issue. Needs quick review to confirm validity and assign labels. label Oct 28, 2025

hannesrudolph moved this from Triage to PR [Needs Prelim Review] in Roo Code Roadmap Oct 28, 2025

hannesrudolph added PR - Needs Preliminary Review and removed Issue/PR - Triage New issue. Needs quick review to confirm validity and assign labels. labels Oct 28, 2025

fix(pr-fixer): scrub lingering references to removed search_and_repla…

201c1f4

…ce tool (UI + rules)

roomote bot commented Oct 28, 2025

View reviewed changes

test: remove obsolete search_and_replace e2e test file

06507ff

daniel-lxs moved this from PR [Needs Prelim Review] to PR [Needs Review] in Roo Code Roadmap Oct 30, 2025

dosubot bot added size:XXL This PR changes 1000+ lines, ignoring generated files. and removed size:L This PR changes 100-499 lines, ignoring generated files. labels Oct 30, 2025

daniel-lxs approved these changes Oct 30, 2025

View reviewed changes

dosubot bot added the lgtm This PR has been approved by a maintainer label Oct 30, 2025

roomote bot commented Oct 31, 2025

View reviewed changes

mrubens approved these changes Oct 31, 2025

View reviewed changes

mrubens merged commit 81d5f63 into main Oct 31, 2025
9 checks passed

mrubens deleted the fix/remove-search-and-replace-tool branch October 31, 2025 02:51

github-project-automation bot moved this from PR [Needs Review] to Done in Roo Code Roadmap Oct 31, 2025

github-project-automation bot moved this from New to Done in Roo Code Roadmap Oct 31, 2025

mini2s added a commit to zgsm-ai/costrict that referenced this pull request Oct 31, 2025

Roo to main (#601

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

fix: remove search_and_replace tool from codebase #8892

fix: remove search_and_replace tool from codebase #8892

Uh oh!

roomote bot commented Oct 28, 2025 •

edited by ellipsis-dev bot

Loading

Uh oh!

roomote bot commented Oct 28, 2025 •

edited

Loading

Uh oh!

roomote bot left a comment

Uh oh!

hannesrudolph commented Oct 28, 2025

Uh oh!

roomote bot commented Oct 28, 2025

Uh oh!

roomote bot left a comment

Uh oh!

roomote bot commented Oct 28, 2025

Uh oh!

roomote bot left a comment

Uh oh!

hannesrudolph commented Oct 31, 2025

Uh oh!

Uh oh!

fix: remove search_and_replace tool from codebase #8892

fix: remove search_and_replace tool from codebase #8892

Uh oh!

Conversation

roomote bot commented Oct 28, 2025 • edited by ellipsis-dev bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Changes Made

Core Implementation

Type System & Interfaces

Prompt System

UI & Localization

Tests

Testing

Impact

Uh oh!

roomote bot commented Oct 28, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

PR Review Update

All Issues Resolved ✅

Recent Improvements

What Was Done Well (from previous reviews)

Verification Complete

Uh oh!

roomote bot left a comment

Choose a reason for hiding this comment

Uh oh!

hannesrudolph commented Oct 28, 2025

Uh oh!

roomote bot commented Oct 28, 2025

Uh oh!

roomote bot left a comment

Choose a reason for hiding this comment

Uh oh!

roomote bot commented Oct 28, 2025

Uh oh!

roomote bot left a comment

Choose a reason for hiding this comment

Uh oh!

hannesrudolph commented Oct 31, 2025

Uh oh!

Uh oh!

roomote bot commented Oct 28, 2025 •

edited by ellipsis-dev bot

Loading

roomote bot commented Oct 28, 2025 •

edited

Loading