Skip to content

feat: add Google Ads conversion tracking to reviewer page #8831

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
dleffel merged 2 commits into from
Oct 26, 2025
Merged

feat: add Google Ads conversion tracking to reviewer page #8831

dleffel merged 2 commits into from
Oct 26, 2025

Conversation

@roomote
Copy link
Contributor

@roomote roomote bot commented Oct 26, 2025 •
edited by ellipsis-dev bot
Loading

Implements Google Ads conversion tracking for the "Start 14 Day Trial" buttons on the PR Reviewer landing page (roocode.com/reviewer).

Changes

  • Created new utility function trackGoogleAdsConversion() in apps/web-roo-code/src/lib/analytics/google-ads.ts
  • Refactored reviewer page into server component (page.tsx) and client component (ReviewerContent.tsx) to support onClick handlers
  • Added onClick={trackGoogleAdsConversion} to both "Start 14 Day Trial" buttons

Conversion Event Details

  • Conversion ID: AW-17391954825/VtOZCJe_77MbEInXkOVA
  • Value: 10.0 USD
  • Triggers when users click either trial button

Technical Notes

  • Respects user consent through existing GoogleAnalyticsProvider
  • Only fires if gtag is loaded (after consent given)
  • Server-side rendering safe with typeof window check
  • Type-safe implementation using existing GtagArgs types

Important

Adds Google Ads conversion tracking to the reviewer page with refactoring for client-server component separation and user consent handling.

  • Behavior:
    • Implements Google Ads conversion tracking for "Start 14 Day Trial" buttons on the reviewer page.
    • Conversion ID: AW-17391954825/VtOZCJe_77MbEInXkOVA, Value: 10.0 USD.
    • Triggers on button click, respects user consent, and only fires if gtag is loaded.
  • Components:
    • Refactors reviewer page into page.tsx (server component) and ReviewerContent.tsx (client component).
    • Adds onClick={trackGoogleAdsConversion} to trial buttons in ReviewerContent.tsx.
  • Utilities:
    • Adds trackGoogleAdsConversion() in google-ads.ts for conversion tracking.
    • Ensures server-side rendering safety with typeof window check.

This description was created by Ellipsis for 1c65f6f. You can customize this summary. It will automatically update as commits are pushed.

@roomote roomote bot requested review from cte, jr and mrubens as code owners October 26, 2025 02:39
@dosubot dosubot bot added size:L This PR changes 100-499 lines, ignoring generated files. Enhancement New feature or request labels Oct 26, 2025
@roomote
Copy link
Contributor Author

roomote bot commented Oct 26, 2025 •
edited
Loading

Review Complete ✅

No issues found. The implementation correctly:

  • Uses type-safe Google Ads conversion tracking
  • Respects user consent through existing GoogleAnalyticsProvider
  • Only fires conversion events when gtag is loaded
  • Follows Next.js best practices for server/client component separation
  • Maintains proper onClick handler placement
  • Fixes invalid HTML nesting with asChild prop on first button

The PR is ready to merge.

Follow Along on Roo Code Cloud

@github-actions
Copy link
Contributor

github-actions bot commented Oct 26, 2025

🚀 Preview deployed!

Your changes have been deployed to Vercel:

Preview URL: https://roo-code-website-f6v31v9u9-roo-code.vercel.app

This preview will be updated automatically when you push new commits to this PR.

roomote[bot]
roomote bot commented Oct 26, 2025
View reviewed changes
Copy link
Contributor Author

@roomote roomote bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found.

@hannesrudolph hannesrudolph added the Issue/PR - Triage New issue. Needs quick review to confirm validity and assign labels. label Oct 26, 2025
@daniel-lxs daniel-lxs moved this from Triage to PR [Needs Review] in Roo Code Roadmap Oct 26, 2025
roomote[bot]
roomote bot commented Oct 26, 2025
View reviewed changes
Copy link
Contributor Author

@roomote roomote bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found.

@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Oct 26, 2025
@hannesrudolph hannesrudolph added PR - Needs Review and removed Issue/PR - Triage New issue. Needs quick review to confirm validity and assign labels. labels Oct 26, 2025
@dleffel dleffel merged commit 8870348 into main Oct 26, 2025
19 checks passed
@dleffel dleffel deleted the feature/add-google-ads-conversion-tracking-reviewer branch October 26, 2025 04:23
@github-project-automation github-project-automation bot moved this from PR [Needs Review] to Done in Roo Code Roadmap Oct 26, 2025
@github-project-automation github-project-automation bot moved this from New to Done in Roo Code Roadmap Oct 26, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@cte cte cte approved these changes

@daniel-lxs daniel-lxs daniel-lxs approved these changes

@mrubens mrubens Awaiting requested review from mrubens mrubens is a code owner

@jr jr Awaiting requested review from jr jr is a code owner

Assignees

No one assigned

Labels

Enhancement New feature or request lgtm This PR has been approved by a maintainer PR - Needs Review size:L This PR changes 100-499 lines, ignoring generated files.

Projects

Roo Code Roadmap
Archived in project

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@cte @daniel-lxs @dleffel @hannesrudolph @roomote