Skip to content

feat: add GLM-4.6 model to Fireworks provider #8754

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
mrubens merged 2 commits into from
Nov 3, 2025
Merged

feat: add GLM-4.6 model to Fireworks provider #8754

mrubens merged 2 commits into from
Nov 3, 2025

Conversation

@roomote
Copy link
Contributor

@roomote roomote bot commented Oct 21, 2025 •
edited by ellipsis-dev bot
Loading

Related GitHub Issue

Closes: #8752

Roo Code Task Context (Optional)

This PR was created with assistance from Roo Code.

Description

This PR adds support for the GLM-4.6 model to the Fireworks provider, addressing the enhancement request in issue #8752. The implementation follows the established patterns for adding new models to the provider:

  • Added glm-4p6 to the FireworksModelId type union
  • Configured model parameters (maxTokens: 16384, contextWindow: 128000)
  • Set appropriate pricing ($0.55 input, $2.19 output) consistent with other GLM models
  • Added a descriptive message highlighting its advanced coding capabilities

Test Procedure

  1. Unit Tests: Added a comprehensive test case for GLM-4.6 in src/api/providers/__tests__/fireworks.spec.ts

    • Test verifies model ID, configuration parameters, and description
    • All tests pass successfully (24 tests total)

  2. Manual Testing Steps:

    • Select Fireworks as the API provider in settings
    • Verify GLM-4.6 appears in the model dropdown
    • Confirm model can be selected and used for API calls

Pre-Submission Checklist

  • Issue Linked: This PR is linked to an approved GitHub Issue (see "Related GitHub Issue" above).
  • Scope: My changes are focused on the linked issue (one major feature/fix per PR).
  • Self-Review: I have performed a thorough self-review of my code.
  • Testing: New and/or updated tests have been added to cover my changes (if applicable).
  • Documentation Impact: I have considered if my changes require documentation updates (see "Documentation Updates" section below).
  • Contribution Guidelines: I have read and agree to the Contributor Guidelines.

Screenshots / Videos

N/A - This is a backend model addition that will appear in the existing model dropdown UI.

Documentation Updates

  • No documentation updates are required.

The model will automatically appear in the dropdown list once merged. No user-facing documentation changes needed as this follows the existing pattern for model selection.

Additional Notes

This implementation follows the exact pattern used for other Fireworks models like GLM-4.5 and GLM-4.5-Air. The pricing and parameters are set based on typical values for GLM models in the Fireworks platform.

Get in Touch

Discord: Available for questions about this PR

Important

Add GLM-4.6 model to Fireworks provider with specific configuration and testing.

  • Behavior:
    • Add glm-4p6 to FireworksModelId in fireworks.ts.
    • Configure glm-4p6 with maxTokens: 25344, contextWindow: 198000, inputPrice: 0.55, outputPrice: 2.19.
    • Add description for glm-4p6 highlighting advanced coding capabilities.
  • Testing:
    • Add test for glm-4p6 in fireworks.spec.ts to verify model ID, configuration, and description.
    • Ensure all tests pass successfully.

This description was created by Ellipsis for 12467b5. You can customize this summary. It will automatically update as commits are pushed.

@roomote roomote bot requested review from cte, jr and mrubens as code owners October 21, 2025 18:56
@roomote
Copy link
Contributor Author

roomote bot commented Oct 21, 2025 •
edited
Loading

Review Complete

No issues found. The implementation correctly adds GLM-4.6 model support following established patterns.

Follow Along on Roo Code Cloud

@dosubot dosubot bot added size:M This PR changes 30-99 lines, ignoring generated files. Enhancement New feature or request labels Oct 21, 2025
roomote[bot]
roomote bot commented Oct 21, 2025
View reviewed changes
Copy link
Contributor Author

@roomote roomote bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found.

@hannesrudolph hannesrudolph added the Issue/PR - Triage New issue. Needs quick review to confirm validity and assign labels. label Oct 21, 2025
@roomote roomote bot mentioned this pull request Oct 21, 2025
Closed
2 tasks
@mmealman
Copy link

mmealman commented Oct 21, 2025 •
edited
Loading

Well, this is actually pretty good. How can I get @roomote to change the below settings though in both the code and tests?

maxTokens: 25344,
contextWindow: 198000,

@roomote
fix: update GLM-4.6 model configuration with correct specifications
12467b5 
- Updated maxTokens from 16384 to 25344
- Updated contextWindow from 128000 to 198000
- Updated test expectations to match new specifications

As requested by @mmealman in issue #8752
roomote[bot]
roomote bot commented Oct 21, 2025
View reviewed changes
Copy link
Contributor Author

@roomote roomote bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found.

@mmealman
Copy link

mmealman commented Oct 21, 2025

This all looks great now.

@hannesrudolph hannesrudolph moved this from Triage to PR [Needs Prelim Review] in Roo Code Roadmap Oct 29, 2025
@hannesrudolph hannesrudolph added PR - Needs Preliminary Review and removed Issue/PR - Triage New issue. Needs quick review to confirm validity and assign labels. labels Oct 29, 2025
@vladrpmd
Copy link

vladrpmd commented Nov 2, 2025

would love to test this one out, any update on this ?

@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Nov 3, 2025
@mrubens mrubens merged commit 8dc8452 into main Nov 3, 2025
14 of 15 checks passed
@mrubens mrubens deleted the feat/add-glm-4p6-fireworks branch November 3, 2025 02:41
@github-project-automation github-project-automation bot moved this from New to Done in Roo Code Roadmap Nov 3, 2025
@github-project-automation github-project-automation bot moved this from PR [Needs Prelim Review] to Done in Roo Code Roadmap Nov 3, 2025
mini2s added a commit to zgsm-ai/costrict that referenced this pull request Nov 3, 2025
@mini2s @brunobergher
@mrubens @roomote @roomote @hannesrudolph @github-actions @daniel-lxs @SannidhyaSah @jr @mohammad154 @ellipsis-dev @MuriloFP @renovate @cte @ColbySerpa @PeterDaveHello @hassoncs @chrarnoldus @laz-001 @NaccOll @ThomsenDrake @elianiva @heyseth @Maosghoul @kevint-cerebras @Thibault00 @requesty-JohnCosta27 @dmarkey
Roo to main (#609