feat: add dynamic model loading for Roo Code Cloud provider #8728

roomote · 2025-10-19T02:47:10Z

Summary

Enables the Roo Code extension to dynamically load available models from the Roo Code Cloud provider via the /v1/models endpoint.

Changes

New fetcher: Added getRooModels() function to fetch models from Roo Code Cloud /v1/models endpoint
Dynamic provider: Added "roo" to the list of dynamic providers
Type updates: Updated RooHandler to support dynamic model IDs (changed from RooModelId to string)
Model caching: Integrated with existing modelCache infrastructure for efficient caching
Graceful fallback: Falls back to static model definitions if dynamic loading fails

Technical Details

Model Loading Strategy

Models are loaded asynchronously on handler initialization
Dynamic models are merged with static models (static definitions take precedence)
Uses 5-minute memory cache + file cache from existing infrastructure
10-second timeout prevents hanging on network issues

Type Safety

Maintains backward compatibility with existing static models
Generic type changed from RooModelId to string to support dynamic model IDs
All type definitions updated across shared/api.ts and provider-settings.ts

Testing

Linting passes
Type checks pass
Follows patterns from other dynamic providers (requesty, glama, unbound)
Error handling with descriptive logging

Behavior:
- Adds getRooModels() in fetchers/roo.ts to fetch models from /v1/models endpoint.
- Integrates Roo Code Cloud as a dynamic provider in provider-settings.ts and webviewMessageHandler.ts.
- Updates RooHandler in roo.ts to support dynamic model IDs and caching.
- Falls back to static models if dynamic loading fails.
Type Updates:
- Changes RooModelId to string in RooHandler.
- Updates type definitions in shared/api.ts and WebviewMessage.ts.
UI Components:
- Adds Roo component in providers/Roo.tsx for model selection.
- Updates ApiOptions.tsx and ModelPicker.tsx to support dynamic model loading.
Testing:
- Updates tests in webviewMessageHandler.spec.ts and validate.test.ts to cover new functionality.
Misc:
- Adds Roo to dynamicProviders in provider-settings.ts.
- Handles authentication state changes in ExtensionStateContext.tsx to refresh models.

^{This description was created by}^{for 6a1c35e. You can customize this summary. It will automatically update as commits are pushed.}

roomote · 2025-10-19T02:47:29Z

Review Summary

I've completed my re-review of this PR. All previously identified issues have been successfully addressed, and no new issues were found in the latest changes.

Issues Found

Remove accidentally committed pr-body.md file from repository root
Logout handler should flush shared model cache to maintain symmetry with login handler

Latest Changes Reviewed

The latest commit (6a1c35e) improves response handling in the Roo models fetcher:

✅ Always sends response even when no models are returned
✅ Prevents frontend from waiting indefinitely for a response
✅ Adds clear comment explaining the behavior
✅ No new issues introduced

Positive Observations

✅ Follows the same patterns as other dynamic providers (glama, unbound, requesty)
✅ Type definitions correctly updated across all relevant files
✅ Proper integration with modelCache infrastructure
✅ Appropriate error handling with fallback to static models
✅ Async loading strategy is well-designed
✅ No breaking changes to existing functionality
✅ URL handling correctly prevents duplication of /v1 suffix
✅ Test coverage added for router models integration
✅ Zod schema validation properly integrated for type safety
✅ Improved error handling with validation errors logged
✅ Auth state change handling now properly reloads models on login
✅ Comment clarity improvements in latest commit
✅ Logout handler now properly flushes model cache with error handling
✅ Successfully removed redundant instance cache in favor of shared cache infrastructure
✅ Replaced axios with native fetch API and AbortController for better timeout handling
✅ Simplified URL normalization while maintaining correctness
✅ Comprehensive error handling for fetch-specific error types
✅ Auth state watcher properly triggers model refresh on login
✅ Response always sent to prevent frontend hangs, even with empty model lists

View Job

pr-body.md

roomote · 2025-10-19T04:51:15Z

PR Review Complete

✅ No issues found

This PR successfully implements dynamic model loading for the Roo Code Cloud provider. The implementation:

Follows established patterns from other dynamic providers
Has proper error handling and timeout mechanisms
Correctly integrates with existing model cache infrastructure
Includes appropriate fallback behavior
Updates all necessary type definitions and UI components

The code is ready to merge.

…loud-models

ellipsis-dev · 2025-10-24T03:41:59Z

src/api/providers/roo.ts

 					})
+
+					// Clear models cache when logged out
+					this.mergedModels = {}


On logout, mergedModels are cleared but the memory cache isn’t flushed. Consider calling flushModels('roo') in the logged-out branch to avoid stale dynamic models.

roomote · 2025-10-24T03:45:16Z

src/api/providers/roo.ts

+					// Clear models cache when logged out
+					this.mergedModels = {}
+					this.modelsLoaded = false


The logout handler clears the instance's model cache but doesn't flush the shared model cache via flushModels("roo"), creating an asymmetry with the login handler (lines 65-72) which does flush the cache. This could allow stale authenticated models to persist in the shared cache after logout, potentially causing the next login to use outdated model data until the 5-minute TTL expires.

roomote

Re-review completed. Found 1 new issue regarding cache management symmetry in the logout handler.

roomote

Re-review complete. One issue remains unresolved (logout handler cache flush). Otherwise, the implementation follows established patterns and integrates well with the existing codebase.

cte

LGTM

src/core/webview/webviewMessageHandler.ts

roomote

All previously identified issues have been successfully resolved. No new issues found in the latest changes.

roomote

No issues found.

feat: add dynamic model loading for Roo Code Cloud provider

4444328

roomote bot requested review from cte, jr and mrubens as code owners October 19, 2025 02:47

github-project-automation bot added this to Roo Code Roadmap and Roo Code Roadmap Oct 19, 2025

github-project-automation bot moved this to Triage in Roo Code Roadmap Oct 19, 2025

github-project-automation bot moved this to New in Roo Code Roadmap Oct 19, 2025

dosubot bot added size:L This PR changes 100-499 lines, ignoring generated files. Enhancement New feature or request labels Oct 19, 2025

mrubens marked this pull request as draft October 19, 2025 02:47

roomote bot commented Oct 19, 2025

View reviewed changes

pr-body.md Outdated Show resolved Hide resolved

hannesrudolph added the Issue/PR - Triage New issue. Needs quick review to confirm validity and assign labels. label Oct 19, 2025

mrubens added 2 commits October 18, 2025 23:03

Delete pr-body.md

626d97b

Make it work

382764c

mrubens marked this pull request as ready for review October 19, 2025 04:50

mrubens added 5 commits October 19, 2025 01:05

Fix url

eeabc50

Fix tests

dbdc8e4

Update types

b2c02de

Reload model list on auth changes

b3054a6

Merge remote-tracking branch 'origin/main' into feature/dynamic-roo-c…

26978df

…loud-models

ellipsis-dev bot reviewed Oct 24, 2025

View reviewed changes

roomote bot commented Oct 24, 2025

View reviewed changes

Update comment

dfecaa0

roomote bot commented Oct 24, 2025

View reviewed changes

cte approved these changes Oct 24, 2025

View reviewed changes

dosubot bot added the lgtm This PR has been approved by a maintainer label Oct 24, 2025

ellipsis-dev bot reviewed Oct 24, 2025

View reviewed changes

src/core/webview/webviewMessageHandler.ts Outdated Show resolved Hide resolved

roomote bot commented Oct 24, 2025

View reviewed changes

PR feedback

6a1c35e

roomote bot commented Oct 24, 2025

View reviewed changes

mrubens merged commit ab9a485 into main Oct 24, 2025
9 checks passed

mrubens deleted the feature/dynamic-roo-cloud-models branch October 24, 2025 04:58

github-project-automation bot moved this from Triage to Done in Roo Code Roadmap Oct 24, 2025

github-project-automation bot moved this from New to Done in Roo Code Roadmap Oct 24, 2025

mini2s added a commit to zgsm-ai/costrict that referenced this pull request Oct 24, 2025

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

feat: add dynamic model loading for Roo Code Cloud provider #8728

feat: add dynamic model loading for Roo Code Cloud provider #8728

Uh oh!

roomote bot commented Oct 19, 2025 •

edited by ellipsis-dev bot

Loading

Uh oh!

roomote bot commented Oct 19, 2025 •

edited

Loading

Uh oh!

Uh oh!

roomote bot commented Oct 19, 2025 •

edited

Loading

Uh oh!

ellipsis-dev bot Oct 24, 2025

Uh oh!

roomote bot Oct 24, 2025

Uh oh!

roomote bot left a comment

Uh oh!

roomote bot left a comment

Uh oh!

cte left a comment

Uh oh!

Uh oh!

roomote bot left a comment

Uh oh!

roomote bot left a comment

Uh oh!

Uh oh!

feat: add dynamic model loading for Roo Code Cloud provider #8728

feat: add dynamic model loading for Roo Code Cloud provider #8728

Uh oh!

Conversation

roomote bot commented Oct 19, 2025 • edited by ellipsis-dev bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Changes

Technical Details

Model Loading Strategy

Type Safety

Testing

Related

Uh oh!

roomote bot commented Oct 19, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Review Summary

Issues Found

Latest Changes Reviewed

Positive Observations

Uh oh!

Uh oh!

roomote bot commented Oct 19, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

PR Review Complete

Uh oh!

ellipsis-dev bot Oct 24, 2025

Choose a reason for hiding this comment

Uh oh!

roomote bot Oct 24, 2025

Choose a reason for hiding this comment

Uh oh!

roomote bot left a comment

Choose a reason for hiding this comment

Uh oh!

roomote bot left a comment

Choose a reason for hiding this comment

Uh oh!

cte left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

roomote bot left a comment

Choose a reason for hiding this comment

Uh oh!

roomote bot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

roomote bot commented Oct 19, 2025 •

edited by ellipsis-dev bot

Loading

roomote bot commented Oct 19, 2025 •

edited

Loading

roomote bot commented Oct 19, 2025 •

edited

Loading