-
Notifications
You must be signed in to change notification settings - Fork 2.8k
Make chat icons shrink-0 #8343
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make chat icons shrink-0 #8343
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I found a couple of low-priority consistency/maintainability items:
- Consider adding
shrink-0to the command icon <TerminalSquare className="size-4" ...> for parity with other icons so it won’t compress in tight flex layouts. - Several icons repeat the className "w-4 shrink-0". Extracting a tiny helper (e.g., a shared class/constant or Icon component) would reduce duplication and keep styling consistent.
No functional or accessibility regressions observed.
| ) : cost !== null && cost !== undefined ? ( | ||
| isExpanded ? ( | ||
| <ChevronDown className="w-4" /> | ||
| <ChevronDown className="w-4 shrink-0" /> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
P3 — Repeated "w-4 shrink-0" across many icons. Consider extracting a small Icon utility (or a shared class/constant) to keep styling consistent and reduce duplication.
* feat: Add DeepInfra as a model provider in Roo Code (RooCodeInc#7677) * fix: validate MCP tool exists before execution (RooCodeInc#7632) Co-authored-by: Roo Code <[email protected]> Co-authored-by: Daniel Riccio <[email protected]> * fix: add error transform to cryptic openAI SDK errors when API key is invalid (RooCodeInc#7586) Co-authored-by: Roo Code <[email protected]> Co-authored-by: Daniel Riccio <[email protected]> * feat: OpenAI Responses API service tiers (flex/priority) — UI selector, pricing, and tests (RooCodeInc#7646) Co-authored-by: Daniel Riccio <[email protected]> * fix: prevent countdown timer from showing in history for answered follow-up questions (RooCodeInc#7686) * fix: Fix the issue of Moonshot's maximum return token count being limited to 1024 (RooCodeInc#7673) Co-authored-by: ellipsis-dev[bot] <65095814+ellipsis-dev[bot]@users.noreply.github.com> Co-authored-by: roomote[bot] <219738659+roomote[bot]@users.noreply.github.com> * feat: update kimi-k2-0905-preview and kimi-k2-turbo-preview (RooCodeInc#7663) * Fix test * Release v3.26.7 (RooCodeInc#7691) * Delete .changeset/petite-rats-admire.md * feat: Add Kimi K2 0905 model to Groq, Moonshot, and Fireworks providers (RooCodeInc#7693) * Use an allowlist to keep the prompt default shell sane (RooCodeInc#7681) * Changeset version bump (RooCodeInc#7690) Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: Matt Rubens <[email protected]> * Fix: Improve WelcomeView styling and readability (RooCodeInc#7682) * fix: improve WelcomeView styling and readability - Reduced excessive padding from p-16 to p-6 - Removed excessive bold text throughout - Made provider cards more compact with smaller icons (32x32px) - Increased introduction text size from text-sm to text-base for better visibility - Centered the main greeting title - Improved visual hierarchy with proper text sizing and spacing - Added subtle borders and improved color contrast * fix: remove undefined color class from incentive text Removed the text-vscode-warningForeground class as it wasn't defined in index.css. The incentive text now uses default color which looks good. * feat: add Kimi K2-0905 model to Chutes provider (RooCodeInc#7701) Co-authored-by: Roo Code <[email protected]> * fix: handle array paths from VSCode terminal profiles (RooCodeInc#7697) * fix: handle array paths from VSCode terminal profiles - Updated terminal profile interfaces to support string | string[] for path property - Added normalizeShellPath helper to safely extract first element from array paths - Modified isShellAllowed to handle both string and array inputs - Updated getWindowsShellFromVSCode, getMacShellFromVSCode, and getLinuxShellFromVSCode to use normalizeShellPath - Added comprehensive tests for array path handling Fixes RooCodeInc#7695 * feat: add validateShellPath export for robust shell validation - Created validateShellPath as a public API for shell path validation - Refactored internal validation logic into isShellAllowedInternal - Added comprehensive test coverage for all edge cases - Maintains backward compatibility with deprecated isShellAllowed - Handles arrays, strings, null, undefined, and nested arrays gracefully * Simplify roomote's work a little --------- Co-authored-by: Roo Code <[email protected]> Co-authored-by: John Richmond <[email protected]> * Edit/Delete User Message (RooCodeInc#7447) * fix: prevent stack overflow in codebase indexing for large projects (RooCodeInc#7712) * fix: identify mcp and slash command config path in multiple folder workspace (RooCodeInc#6904) * fix: resolve CI e2e test ETIMEDOUT errors when downloading VS Code (RooCodeInc#7583) * fix: Tackling Race/State condition issue by Changing the Code Design for Gemini Grounding Sources (RooCodeInc#7434) Co-authored-by: daniel-lxs <[email protected]> Co-authored-by: Matt Rubens <[email protected]> * fix: preserve context by retrying with full conversation on invalid previous_response_id (RooCodeInc#7714) * chore: add changeset for v3.26.8 (RooCodeInc#7715) * feat(checkpoints): create checkpoint when user sends a message (RooCodeInc#7713) * feat(checkpoints): create checkpoint on user message send * fix(checkpoints): suppress implicit user-message checkpoint row; keep current checkpoint updated without a chat row * Fix checkpoint suppression for user messages - Propagate suppressMessage flag through event chain properly - Update ChatView to check checkpoint metadata for suppressMessage flag - Ensure checkpoint messages are created but not rendered when suppressed - Fix bug where checkpointSave(false) should have been checkpointSave(true) * fix: only create checkpoint on user message when files have changed - Changed allowEmpty from true to false in checkpointSave call - Checkpoints will now only be created when there are actual file changes - This avoids creating empty commits in the shadow git repository * test: update checkpoint test to include suppressMessage parameter - Fixed test expectation to match the new function signature - saveCheckpoint now expects both allowEmpty and suppressMessage parameters --------- Co-authored-by: Roo Code <[email protected]> Co-authored-by: Hannes Rudolph <[email protected]> Co-authored-by: Daniel Riccio <[email protected]> * Bump to 3.27.0 (RooCodeInc#7719) * Changeset version bump (
Before:

After:

Important
Add
shrink-0class to icons inChatRow.tsxto prevent shrinking in limited space.shrink-0class to icons inChatRow.tsxto prevent shrinking in limited space.ChevronDown,ChevronRight,MessageCircleQuestionMark,FileDiff,Eye,FileCode2,SquareArrowOutUpRight,ListTree,FolderTree,PocketKnife,MessageCircle,User,Edit, andTrash2.This description was created by
for ca0ee62. You can customize this summary. It will automatically update as commits are pushed.