Terminal settings: Cleanup terminal settings tab and change default terminal to inline #8342
Conversation
…)' and clarify blurbs; align with execa and CR/BS processing
hannesrudolph
added
the
Issue/PR - Triage
KJ7LNW
left a comment
KJ7LNW
left a comment
There was a problem hiding this comment.
Here are a few comments. I think anything else looks fine and can be kept the way it is.
hannesrudolph
added
PR - Draft / In Progress
and removed
Issue/PR - Triage
…d settings Set terminalShellIntegrationDisabled default to true to use Inline Terminal by default. Update Terminal settings UI to default to Inline Terminal and only show "Inherit environment variables" when using the VS Code terminal. Refresh English settings copy for clarity and reliability.
hannesrudolph
changed the title
…als/next-env.d.ts from origin/main
dosubot
bot
added
the
size:M
Review UpdateThe spacing inconsistency on line 670 has been resolved! The recent commit added the missing space before Status:
The PR successfully:
The existing review comments from @KJ7LNW and @roomote[bot] contain suggestions for further improving the documentation text, which the PR author can address if desired. |
![ellipsis-dev[bot]](https://avatars.githubusercontent.com/in/64358?s=60&v=4){kind=small}
![roomote[bot]](https://avatars.githubusercontent.com/in/1546624?s=60&v=4){kind=small}
There was a problem hiding this comment.
Pull Request Overview
This PR inverts the logic of the "Use Inline Terminal" setting and updates all terminal setting descriptions for clarity. The setting now defaults to enabled (inline terminal mode) instead of disabled.
- Changed
terminalShellIntegrationDisableddefault value fromfalsetotrueacross the codebase - Inverted UI checkbox logic and moved related settings into a conditional block
- Rewrote all terminal setting descriptions for better user comprehension
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 5 comments.
| File | Description |
|---|---|
| webview-ui/src/i18n/locales/en/settings.json | Updated terminal setting descriptions to be more concise and user-friendly; adjusted text for the inverted checkbox logic |
| webview-ui/src/components/settings/TerminalSettings.tsx | Changed default value from false to true and moved inheritEnv setting inside the conditional block so it only appears when inline terminal is disabled |
| src/core/tools/executeCommandTool.ts | Updated default value of terminalShellIntegrationDisabled from false to true in two locations |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <[email protected]>
Co-authored-by: Copilot <[email protected]>
hannesrudolph
moved this from PR [Needs Review]
to PR [Needs Prelim Review]
in Roo Code Roadmap
github-project-automation
bot
moved this from PR [Needs Prelim Review]
to Done
in Roo Code Roadmap
Beyond the tweaks to the UI this PR also changes the default terminal to inline.
Important
Set default
terminalShellIntegrationDisabledtotrueand update terminal settings UI and localization accordingly.terminalShellIntegrationDisabledset totrueinexecuteCommandTool()andexecuteCommand()inexecuteCommandTool.ts.inheritEnvcheckbox moved to be conditional onterminalShellIntegrationDisabledinTerminalSettings.tsx.TerminalSettings.tsxto reflect new default forterminalShellIntegrationDisabled.TerminalSettings.tsx.settings.jsonto reflect changes in terminal settings behavior and defaults.This description was created by
for 580c455. You can customize this summary. It will automatically update as commits are pushed.