Show the Roo provider on the welcome screen #8317
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dosubot
bot
added
the
size:M
Collaborator
|
Where screenshots? :P |
Collaborator
Author
Added |
hannesrudolph
added
the
Issue/PR - Triage
![roomote[bot]](https://avatars.githubusercontent.com/in/1546624?s=60&v=4){kind=small}
| // Check PostHog feature flag for Roo provider | ||
| useEffect(() => { | ||
| posthog.onFeatureFlags(function () { | ||
| setShowRooProvider(posthog?.getFeatureFlag("roo-provider-featured") === "test") |
Contributor
There was a problem hiding this comment.
[P2] onFeatureFlags only updates after PostHog loads and this checks specifically for the 'test' variant. Initialize immediately and support boolean/variant values (true|'test'|'enabled'); run an initial check and then subscribe to updates.
| href={provider.authUrl} | ||
| className="flex-1 border border-vscode-panel-border hover:bg-secondary rounded-md py-3 px-4 mb-2 flex flex-row gap-3 cursor-pointer transition-all no-underline text-inherit" | ||
| className="relative flex-1 border border-vscode-panel-border hover:bg-secondary rounded-md py-3 px-4 mb-2 flex flex-row gap-3 cursor-pointer transition-all no-underline text-inherit" | ||
| target="_blank" |
Contributor
There was a problem hiding this comment.
[P3] Roo card uses target="_blank" even when href is '#'. Middle-click/keyboard open can create a dead tab despite preventDefault. Omit target for Roo or render as a button to avoid stray tabs.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Important
Adds Roo provider to welcome screen with feature flag control and telemetry tracking, updating translations for multiple languages.
WelcomeView.tsxifroo-provider-featuredfeature flag is set to "test".FEATURED_PROVIDER_CLICKEDtelemetry event.FEATURED_PROVIDER_CLICKEDtoTelemetryEventNameintelemetry.ts.rooCodeTelemetryEventSchemato includeFEATURED_PROVIDER_CLICKED.welcome.jsonin multiple locales to include Roo provider description and incentive.This description was created by
for 376c8f1. You can customize this summary. It will automatically update as commits are pushed.