Correct tool use suggestion to improve model adherence to suggestion #8315
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dosubot
bot
added
the
size:XS
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR improves the clarity of error messages in the multiApplyDiffTool by updating tool usage suggestions to use more consistent and explicit language.
- Updated error message suggestions to use consistent language when referring to the read_file tool
- Changed references from
<read_file>to "the read_file tool" for better clarity
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
mrubens
approved these changes
Sep 25, 2025
![roomote[bot]](https://avatars.githubusercontent.com/in/1546624?s=60&v=4){kind=small}
src/core/tools/multiApplyDiffTool.ts
Outdated
| 1. Verify the search content exactly matches the file content (including whitespace and case) | ||
| 2. Check for correct indentation and line endings | ||
| 3. Use <read_file> to see the current file content | ||
| 3. Use the read_file tool to verify the current file content |
Contributor
There was a problem hiding this comment.
P3: Microcopy — consider formatting the tool name with backticks for readability and consistency (e.g., "the read_file tool").
src/core/tools/multiApplyDiffTool.ts
Outdated
| Recovery suggestions: | ||
| 1. Use <read_file> to examine the current file content | ||
| 1. Use the read_file tool to verify the current file content |
Contributor
There was a problem hiding this comment.
P3: Same note — consider "the read_file tool" for consistent formatting and readability.
github-project-automation
bot
moved this from PR [Needs Review]
to Done
in Roo Code Roadmap
mini2s
added a commit
to zgsm-ai/costrict
that referenced
this pull request
Sep 25, 2025
Intended to fix situations where Roo sometimes gives up trying to apply edits on a file after failures even though it has not tried to reread and verify the current condition of said file.
In this specific example Roo simply moved on after trying twice to make edits and failing but never reread the file to see if the edits were failing do to an incorrect understanding of the files current condition.
Important
Corrects tool use suggestion in
multiApplyDiffTool.tsfor clarity by replacing<read_file>withthe read_file tool.multiApplyDiffTool.tsto replace<read_file>withthe read_file toolfor clarity.This description was created by
for 7b5fbbd. You can customize this summary. It will automatically update as commits are pushed.