feat: Add telemetry tracking to DismissibleUpsell component #8309
Conversation
- Added UPSELL_DISMISSED and UPSELL_CLICKED events to TelemetryEventName enum - Updated DismissibleUpsell component to track clicks and dismissals with telemetry - Added telemetry tests to DismissibleUpsell test suite - Events include upsellId in the payload for tracking specific upsells
![roomote[bot]](https://avatars.githubusercontent.com/in/1546624?s=60&v=4){kind=small}
| }, [upsellId]) | ||
|
|
||
| const handleDismiss = async () => { | ||
| // Track telemetry for dismissal |
There was a problem hiding this comment.
P2: handleDismiss is marked async but doesn’t await anything. Making it synchronous avoids misleading consumers and minor overhead.
| // Track telemetry for dismissal | |
| const handleDismiss = () => { |
| }) | ||
|
|
||
| it("dismisses when clicked if dismissOnClick is true", async () => { | ||
| it("dismisses when clicked if dismissOnClick is true and tracks both telemetry events", async () => { |
There was a problem hiding this comment.
P3: Add a test for the scenario where dismissOnClick is true and no onClick is provided. Expect only UPSELL_DISMISSED to be captured (and not UPSELL_CLICKED) to lock in the intended behavior.
| onClick={() => { | ||
| // Track telemetry for click | ||
| if (onClick) { | ||
| telemetryClient.capture(TelemetryEventName.UPSELL_CLICKED, { |
There was a problem hiding this comment.
P3: Intentional behavior: UPSELL_CLICKED is emitted only when onClick exists. If analytics should also capture container-dismiss without onClick (dismissOnClick=true), consider adding a separate event or documenting this decision.
There was a problem hiding this comment.
Good point, let's make sure to track these as dismissals.
There was a problem hiding this comment.
Not sure if Roomote implemented this change, it doesn't seem like it did
|
@roomote-agent implement the PR feedback. |
hannesrudolph
added
the
Issue/PR - Triage
|
Acknowledged. I will: 1) make handleDismiss synchronous, 2) ensure that when dismissOnClick is true and no onClick is provided we only capture UPSELL_DISMISSED (not UPSELL_CLICKED), and 3) add a dedicated test for that scenario. I will push updates to feat/add-telemetry-dismissible-upsell shortly. |
test(webview): add scenario where dismissOnClick=true without onClick tracks only UPSELL_DISMISSED; update tests; all tests passing locally
|
Summary of updates implementing feedback:
Validation:
Result: telemetry behavior is now consistent with the decision to treat container-click dismissals (without onClick) strictly as dismiss events, while retaining click telemetry only when an onClick exists. |
daniel-lxs
moved this from PR [Draft / In Progress]
to PR [Needs Prelim Review]
in Roo Code Roadmap
dosubot
bot
added
the
size:M
dosubot
bot
added
Enhancement
daniel-lxs
moved this from PR [Needs Prelim Review]
to PR [Needs Review]
in Roo Code Roadmap
hannesrudolph
added
PR - Needs Review
and removed
Issue/PR - Triage
github-project-automation
bot
moved this from PR [Needs Review]
to Done
in Roo Code Roadmap
Summary
This PR adds telemetry tracking to the DismissibleUpsell component to track user interactions with upsell messages.
Changes
Added two new telemetry events to TelemetryEventName enum:
UPSELL_DISMISSED- Triggered when the dismiss button is clickedUPSELL_CLICKED- Triggered when the upsell container is clicked (only if onClick handler is provided)Updated DismissibleUpsell component to track these events using the existing PostHog infrastructure
upsellIdin the payload for tracking specific upsellsAdded comprehensive test coverage for the new telemetry functionality
Testing
dismissOnClickis trueImplementation Notes
Related
Requested via Slack to improve analytics and understand user engagement with upsell messages.
Important
Adds telemetry tracking for
DismissibleUpsellinteractions, including new events and comprehensive tests.DismissibleUpsellforUPSELL_DISMISSEDandUPSELL_CLICKEDevents inDismissibleUpsell.tsx.upsellIdin payload.onClickhandler is provided.DismissibleUpsell.spec.tsxto verify telemetry events for dismiss and click actions.dismissOnClicktrue and false, and component unmounting.UPSELL_DISMISSEDandUPSELL_CLICKEDtoTelemetryEventNameintelemetry.ts.This description was created by
for 0e88233. You can customize this summary. It will automatically update as commits are pushed.