-
Notifications
You must be signed in to change notification settings - Fork 2.8k
fix: prevent checkpoint text from wrapping in non-English languages #8207
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Added whitespace-nowrap class to checkpoint text container - Fixes issue where longer translations (e.g., Japanese, Russian) would wrap - Ensures consistent single-line display across all languages Fixes #8206
daniel-lxs
approved these changes
Sep 22, 2025
Contributor
Author
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewing my own code is like grading my own homework - suspiciously perfect every time.
✅ This fix correctly addresses the issue:
- Adds to prevent checkpoint text from wrapping in non-English languages
- Follows established patterns (30 other uses of in the codebase)
- Minimal, targeted change with no side effects
- Properly fixes issue #8206
mrubens
approved these changes
Sep 22, 2025
mini2s
added a commit
to zgsm-ai/costrict
that referenced
this pull request
Sep 23, 2025
* docs: update PR template branding from Roo Code to Costrict * feat: optimize memory usage for image handling in webview (RooCodeInc#7556) * feat: optimize memory usage for image handling in webview - Replace base64 image data with webview URIs to reduce memory footprint - Add proper resource roots to webview for workspace file access - Implement convertToWebviewUri method for safe file-to-URI conversion - Update ImageViewer to handle both webview URIs and file paths separately - Add image message type for proper image rendering in chat - Improve error handling and display for failed image loads - Add comprehensive tests for ImageViewer component - Format display paths as relative for better readability This change significantly reduces memory usage by avoiding base64 encoding of images and instead using VSCode's webview URI system for direct file access. Images are now loaded on-demand from disk rather than being held in memory as base64 strings. * fix: address PR review comments - Use safeJsonParse instead of JSON.parse in ChatRow.tsx - Add type definition for parsed image info - Add more specific error types in ClineProvider.ts - Add comprehensive JSDoc comments to ImageBlock.tsx - Improve error handling and type safety * fix: address MrUbens' review comments - Remove hardcoded 'rc1' pattern in formatDisplayPath, use generic workspace detection - Internationalize 'No image data' text using i18n system * chore: remove useless comment * chore(i18n): add image.noData to all locales to fix translation check * test: update ImageViewer.spec to align with i18n key and flexible path formatting * feat: rename Account tab to Cloud tab (RooCodeInc#7558) Co-authored-by: Roo Code <[email protected]> Co-authored-by: Matt Rubens <[email protected]> * feat: add Ollama API key support for Turbo mode (RooCodeInc#7425) * feat: add Ollama API key support for Turbo mode - Add ollamaApiKey field to ProviderSettings schema - Add ollamaApiKey to SECRET_STATE_KEYS for secure storage - Update Ollama and NativeOllama providers to use API key for authentication - Add UI field for Ollama API key (shown when custom base URL is provided) - Add test coverage for API key functionality This enables users to use Ollama Turbo with datacenter-grade hardware by providing an API key for authenticated Ollama instances or cloud services. * fix: use VSCodeTextField for Ollama API key field Remove non-existent ApiKeyField import and use standard VSCodeTextField with password type, matching other provider implementations * Add missing translation keys for Ollama API key support - Add providers.ollama.apiKey and providers.ollama.apiKeyHelp to all 18 language files - Support for authenticated Ollama instances and cloud services - Relates to PR RooCodeInc#7425 * refactor: improve type safety for Ollama client configuration - Replace 'any' type with proper OllamaOptions (Config) type - Import Config type from ollama package for better type checking --------- Co-authored-by: Roo Code <[email protected]> Co-authored-by: Daniel Riccio <[email protected]> * Disconnect extension bridge on logout (RooCodeInc#7563) * Disconnect extension bridge on logout * Remove bad test * Cleanup * Fix claudeCode.notFound translation key (RooCodeInc#7571) I think I saw someone post a screenshot where "errors.claudeCode.notFound" was shown untranslated. * v3.26.4 (RooCodeInc#7579) * Update contributors list (RooCodeInc#7462) Co-authored-by: mrubens <[email protected]> * Changeset version bump (RooCodeInc#7580) Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: Matt Rubens <[email protected]> * feat: add configurable embedding batch size for code indexing (RooCodeInc#7464) Co-authored-by: Roo Code <[email protected]> Co-authored-by: Daniel Riccio <[email protected]> * Shows a pill with the base Roo Code Cloud URL when not pointing to pr… (RooCodeInc#7555) Co-authored-by: Roo Code <[email protected]> Co-authored-by: Matt Rubens <[email protected]> Co-authored-by: roomote[bot] <219738659+roomote[bot]@users.noreply.github.com> * Cloud: fix provider syncing (RooCodeInc#7603) ClineProvider creation was moved before CloudService which broke the old way of doing things. * fix: add cache reporting support for OpenAI-Native provider (RooCodeInc#7602) * fix: add cache reporting support for OpenAI-Native provider - Add normalizeUsage method to properly extract cache tokens from Responses API - Su
This PR fixes issue #8206 where checkpoint text was wrapping when using non-English languages.
Problem
Checkpoint text was wrapping to multiple lines when using languages with longer translations (Chinese, Korean, Japanese, Russian, etc.), while English displayed correctly on a single line.
Solution
Added
whitespace-nowrapTailwind CSS class to the checkpoint text container to prevent text wrapping regardless of language or text length.Changes
whitespace-nowrapclass to the div containing checkpoint text inCheckpointSaved.tsxTesting
whitespace-nowrap)Fixes #8206
Important
Adds
whitespace-nowrapclass to prevent checkpoint text wrapping in non-English languages inCheckpointSaved.tsx.whitespace-nowrapclass to the div containing checkpoint text inCheckpointSaved.tsxto prevent text wrapping in non-English languages.whitespace-nowrap.This description was created by
for d09fcb8. You can customize this summary. It will automatically update as commits are pushed.