Skip to content

Conversation

@mrubens
Copy link
Collaborator

@mrubens mrubens commented Sep 20, 2025

Screenshot 2025-09-20 at 2 45 38 PM Screenshot 2025-09-20 at 2 45 56 PM

Important

Add announcement for "Code Supernova" model with updated authentication flow and localization.

  • Behavior:
    • Adds support for landingPageSlug in login() in CloudService.ts and WebAuthService.ts to redirect users to specific landing pages.
    • New announcement for "Code Supernova" model in ClineProvider.ts and webviewMessageHandler.ts.
  • UI:
    • Updates Announcement.tsx to include new announcement details and conditional UI elements based on authentication status.
  • Localization:
    • Updates localization files for multiple languages to include new announcement text and remove outdated content.

This description was created by Ellipsis for 6fef5c4. You can customize this summary. It will automatically update as commits are pushed.

@mrubens mrubens requested review from cte and jr as code owners September 20, 2025 18:57
@dosubot dosubot bot added size:L This PR changes 100-499 lines, ignoring generated files. UI/UX UI/UX related or focused labels Sep 20, 2025
"visitCloudButton": "Roo Code Cloud 방문",
"socialLinks": "<xLink>X</xLink>, <discordLink>Discord</discordLink>, 또는 <redditLink>r/RooCode</redditLink>에서 만나요"
"stealthModel": {
"feature": "<bold>기간 한정 무료 스텔스 모델</bold> - Code Supernova: 이미지 입력을 지원하는 다목적 에이전틱 코딩 모델, Roo Code Cloud를 통해 이용 가능.",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Typographical suggestion: The phrase "다목적 에이전틱 코딩 모델" may contain a typo. Did you mean "다목적 에이전트 코딩 모델" instead?

Suggested change
"feature": "<bold>기간 한정 무료 스텔스 모델</bold> - Code Supernova: 이미지 입력을 지원하는 다목적 에이전틱 코딩 모델, Roo Code Cloud를 통해 이용 가능.",
"feature": "<bold>기간 한정 무료 스텔스 모델</bold> - Code Supernova: 이미지 입력을 지원하는 다목적 에이전트 코딩 모델, Roo Code Cloud를 통해 이용 가능.",

@hannesrudolph hannesrudolph added the Issue/PR - Triage New issue. Needs quick review to confirm validity and assign labels. label Sep 20, 2025
@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Sep 20, 2025
Copy link
Contributor

@roomote roomote bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Found several issues that need attention before merging this PR.

Critical Issues (Must Fix):

  1. Missing test coverage - The new landingPageSlug parameter in WebAuthService.login() and CloudService.login() methods lacks test coverage. The existing tests in WebAuthService.spec.ts don't verify the landing page URL construction logic. Please add tests to verify:
    • URL construction with a landing page slug
    • URL construction without a landing page slug (default behavior)
    • Error handling with landing page slug

Important Suggestions (Should Consider):

  1. Inconsistent model description - In packages/types/src/providers/roo.ts:26, the description says "logged by the model provider" which is vague. The grok-code-fast-1 model specifically mentions "logged by xAI", so this should specify the actual provider.

  2. Hardcoded default value - In webviewMessageHandler.ts:2307, the fallback value is hardcoded to "supernova". Consider making this configurable or at least document why this specific default was chosen.

Minor Improvements (Nice to Have):

  1. Missing TypeScript types - The cloudLandingPageSignIn message handler doesn't have a corresponding type definition in the message types, which could lead to type safety issues.

  2. Incomplete translations - While all language files were updated, the translations appear to be machine-generated. Consider having native speakers review the translations for accuracy.

@mrubens mrubens merged commit 32d7e6f into main Sep 20, 2025
12 checks passed
@mrubens mrubens deleted the code_supernova_announcement branch September 20, 2025 20:28
@github-project-automation github-project-automation bot moved this from New to Done in Roo Code Roadmap Sep 20, 2025
@github-project-automation github-project-automation bot moved this from Triage to Done in Roo Code Roadmap Sep 20, 2025