-
Notifications
You must be signed in to change notification settings - Fork 2.8k
Add an announcement for Supernova #8197
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
| "visitCloudButton": "Roo Code Cloud 방문", | ||
| "socialLinks": "<xLink>X</xLink>, <discordLink>Discord</discordLink>, 또는 <redditLink>r/RooCode</redditLink>에서 만나요" | ||
| "stealthModel": { | ||
| "feature": "<bold>기간 한정 무료 스텔스 모델</bold> - Code Supernova: 이미지 입력을 지원하는 다목적 에이전틱 코딩 모델, Roo Code Cloud를 통해 이용 가능.", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Typographical suggestion: The phrase "다목적 에이전틱 코딩 모델" may contain a typo. Did you mean "다목적 에이전트 코딩 모델" instead?
| "feature": "<bold>기간 한정 무료 스텔스 모델</bold> - Code Supernova: 이미지 입력을 지원하는 다목적 에이전틱 코딩 모델, Roo Code Cloud를 통해 이용 가능.", | |
| "feature": "<bold>기간 한정 무료 스텔스 모델</bold> - Code Supernova: 이미지 입력을 지원하는 다목적 에이전트 코딩 모델, Roo Code Cloud를 통해 이용 가능.", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Found several issues that need attention before merging this PR.
Critical Issues (Must Fix):
- Missing test coverage - The new
landingPageSlugparameter inWebAuthService.login()andCloudService.login()methods lacks test coverage. The existing tests inWebAuthService.spec.tsdon't verify the landing page URL construction logic. Please add tests to verify:- URL construction with a landing page slug
- URL construction without a landing page slug (default behavior)
- Error handling with landing page slug
Important Suggestions (Should Consider):
-
Inconsistent model description - In
packages/types/src/providers/roo.ts:26, the description says "logged by the model provider" which is vague. The grok-code-fast-1 model specifically mentions "logged by xAI", so this should specify the actual provider. -
Hardcoded default value - In
webviewMessageHandler.ts:2307, the fallback value is hardcoded to "supernova". Consider making this configurable or at least document why this specific default was chosen.
Minor Improvements (Nice to Have):
-
Missing TypeScript types - The
cloudLandingPageSignInmessage handler doesn't have a corresponding type definition in the message types, which could lead to type safety issues. -
Incomplete translations - While all language files were updated, the translations appear to be machine-generated. Consider having native speakers review the translations for accuracy.
Important
Add announcement for "Code Supernova" model with updated authentication flow and localization.
landingPageSluginlogin()inCloudService.tsandWebAuthService.tsto redirect users to specific landing pages.ClineProvider.tsandwebviewMessageHandler.ts.Announcement.tsxto include new announcement details and conditional UI elements based on authentication status.This description was created by
for 6fef5c4. You can customize this summary. It will automatically update as commits are pushed.