Fix: Transform keybindings in nightly build to fix command+y shortcut #8070
Conversation
The keybindings section was not being transformed during the nightly build process, causing command+y keybinding to reference the wrong command name (roo-cline.addToContext instead of roo-code-nightly.addToContext). - Added keybindings schema to types.ts - Updated generatePackageJson to transform keybindings command references - This ensures keybindings work correctly in the nightly build
Updated generatePackageJson to conditionally add keybindings to avoid including undefined values in the generated package.json. Fixed eslint-disable comment placement.
dosubot
bot
added
size:S
hannesrudolph
added
the
Issue/PR - Triage
![roomote[bot]](https://avatars.githubusercontent.com/in/1546624?s=60&v=4){kind=small}
There was a problem hiding this comment.
Reviewing my own code because apparently I trust no one, not even myself.
Review Findings
Critical Issues (Must Fix):
- Missing test coverage - The test file at
packages/build/src/__tests__/index.test.tsdoesn't include any keybindings in the test input, which means the new keybindings transformation logic is completely untested. Since this PR is specifically about fixing keybindings transformation, we should add test coverage for this critical functionality.
Important Suggestions (Should Consider):
-
Potential null/undefined handling issue - In
packages/build/src/esbuild.tsline 241, the code checksif (keybindings)but doesn't handle the case where keybindings might exist in the original contributes but fail to parse. The PR description mentions "Check for keybindings in both parsed and original contributes (fallback)" but I don't see any fallback logic in the implementation. -
Documentation opportunity - Consider adding a comment explaining why keybindings need special optional handling, unlike other contributes fields. This would help future maintainers understand the design decision.
The fix itself looks correct and should resolve the command+y keybinding issue in the Nightly build. However, the lack of test coverage is concerning for a critical user-facing feature.
Problem
The command+y keybinding wasn't working in the Nightly app because the keybindings section wasn't being transformed during the build process.
Root Cause
The
generatePackageJsonfunction inpackages/build/src/esbuild.tswas missing the logic to transform keybindings fromroo-clinetoroo-code-nightly.Solution
packages/build/src/types.tsgeneratePackageJsonto:roo-cline.addToContexttoroo-code-nightly.addToContextTesting
Impact
After this fix, the command+y keybinding will correctly trigger
roo-code-nightly.addToContextin the Nightly build instead of the non-existentroo-cline.addToContextcommand.Fixes the issue reported in Slack about command+y not working in the Nightly app.
Important
Fixes
command+ykeybinding in Nightly build by transforming keybinding commands ingeneratePackageJson()and adding a keybindings schema.command+ykeybinding in Nightly build by transforming keybinding commands fromroo-cline.addToContexttoroo-code-nightly.addToContextingeneratePackageJson().keybindingsSchematotypes.tsfor parsing keybindings.This description was created by
for 10d9470. You can customize this summary. It will automatically update as commits are pushed.