Skip to content

feat: add GDPR-compliant cookie consent banner #8022

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
mrubens merged 16 commits into from
Sep 16, 2025
Merged

feat: add GDPR-compliant cookie consent banner #8022

mrubens merged 16 commits into from
Sep 16, 2025

Conversation

@roomote
Copy link
Contributor

@roomote roomote bot commented Sep 16, 2025 •
edited by ellipsis-dev bot
Loading

This PR adds GDPR-compliant cookie banner to web-roo-code, ensuring cookie-driven analytics scripts are added only after consent.

Changes

  • Implemented CookieConsent component with proper styling (white background by default, inverted in dark mode)
  • Integrated cookie consent into web-roo-code layout

Screenshots

image

image
image

Important

Adds GDPR-compliant cookie consent banner and updates analytics providers to respect user consent.

  • Behavior:
    • Adds CookieConsentWrapper component in CookieConsentWrapper.tsx for GDPR-compliant cookie consent.
    • Integrates CookieConsentWrapper into layout.tsx to display consent banner.
    • Updates GoogleAnalyticsProvider and PostHogProvider to load analytics only after consent.
  • Consent Management:
    • Implements consent management in consent-manager.ts to handle consent events.
    • Defines CONSENT_COOKIE_NAME and COOKIE_CONSENT_EVENTS in cookie-consent.ts.
  • Dependencies:
    • Adds react-cookie-consent and tldts to package.json.

This description was created by Ellipsis for 9fc5f6c. You can customize this summary. It will automatically update as commits are pushed.

@roomote
feat: add GDPR-compliant cookie consent banners
9172003 
- Created shared @roo-code/cookie-consent package with react-cookie-consent
- Implemented CookieConsent component with proper styling (white bg, inverted in dark mode)
- Integrated cookie consent into web-roo-code layout
- Created basic Next.js app structure for web-docs
- Integrated cookie consent into web-docs layout
- Used shared component approach for consistency and maintainability
@roomote
chore: add gitignore for web-docs and remove build artifacts
ede487f
@roomote
chore: remove next-env.d.ts from git tracking
1bdbe5a
roomote[bot]
roomote bot commented Sep 16, 2025
View reviewed changes
Copy link
Contributor Author

@roomote roomote bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewing my own code because apparently I trust no one, not even myself.

@hannesrudolph hannesrudolph added the Issue/PR - Triage New issue. Needs quick review to confirm validity and assign labels. label Sep 16, 2025
@brunobergher
Copy link
Collaborator

brunobergher commented Sep 16, 2025

@roomote-agent there's a lot of PR feedback for you to address here.

@roomote
Copy link
Contributor Author

roomote bot commented Sep 16, 2025

Thanks for the feedback @brunobergher! I see the review comments and I'm on it. Here's what I'll be addressing:

  1. Remove shared package approach - Will duplicate the cookie consent component directly in each app instead
  2. Fix hydration issues - Replace DOM manipulation with next-themes useTheme hook for dark mode detection
  3. Use Tailwind classes - Replace all inline styles with Tailwind utility classes
  4. Add accessibility - Include proper ARIA attributes for screen reader support
  5. Remove unused dependency - Remove js-cookie from dependencies
  6. Align ESLint versions - Update to ESLint v9 across all apps

I'll have these changes ready shortly!

@roomote
refactor: address PR feedback for cookie consent implementation
c985d99 
- Remove shared package approach, duplicate component in each app
- Replace DOM manipulation with next-themes useTheme hook for dark mode
- Replace all inline styles with Tailwind utility classes
- Add proper ARIA attributes for accessibility
- Remove unused js-cookie dependency
- Align ESLint version to v9 across all apps

Addresses all review comments from @brunobergher
@github-actions
Copy link
Contributor

github-actions bot commented Sep 16, 2025

🚀 Preview deployed!

Your changes have been deployed to Vercel:

Preview URL: https://roo-code-website-hqgul24g8-roo-code.vercel.app

This preview will be updated automatically when you push new commits to this PR.

@roomote
Copy link
Contributor Author

roomote bot commented Sep 16, 2025

Hey @brunobergher! All requested changes have been implemented and pushed ✅

Changes Made:

  • ✅ Removed shared package approach - Deleted packages/cookie-consent and duplicated the component directly in each app
  • ✅ Fixed hydration issues - Replaced DOM manipulation with useTheme hook from next-themes for dark mode detection
  • ✅ Replaced inline styles - All styles now use Tailwind utility classes instead of React.CSSProperties
  • ✅ Added accessibility - Included proper ARIA attributes (role="banner", aria-label, aria-live)
  • ✅ Removed unused dependency - js-cookie was not included in the new implementation
  • ✅ Aligned ESLint versions - Updated web-docs to use ESLint v9 to match other apps

CI Status:

Most checks are passing. The Windows unit test failure appears to be a pre-existing issue unrelated to these changes (all other platform tests pass).

The cookie consent implementation is now cleaner, more maintainable, and follows best practices for SSR/hydration. Ready for your review!

@brunobergher brunobergher changed the title feat: add GDPR-compliant cookie consent banners feat: add GDPR-compliant cookie consent banner Sep 16, 2025
@brunobergher brunobergher marked this pull request as ready for review September 16, 2025 15:05
@dosubot dosubot bot added size:XL This PR changes 500-999 lines, ignoring generated files. Enhancement New feature or request labels Sep 16, 2025
mrubens
mrubens reviewed Sep 16, 2025
View reviewed changes
apps/web-docs/.eslintrc.json Outdated
Copy link
Collaborator

@mrubens mrubens Sep 16, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should probably remove this apps/web-docs folder and everything in it

Copy link
Collaborator

@brunobergher brunobergher Sep 16, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

#8027

mrubens
mrubens reviewed Sep 16, 2025
View reviewed changes
@dosubot dosubot bot removed the size:XL This PR changes 500-999 lines, ignoring generated files. label Sep 16, 2025
mini2s added a commit to zgsm-ai/costrict that referenced this pull request Sep 23, 2025
@mini2s @daniel-lxs
@roomote @roomote @mrubens @chrarnoldus @github-actions @brunobergher @jr @hannesrudolph @cte @mohammad154 @DC-Dancao @wangxiaolong100 @PeterDaveHello @Thachnh @ellipsis-dev @CellenLee @NaccOll @HahaBill @ssweens @renovate @ItsOnlyBinary @mubeen-zulfiqar @dependabot @jdilla1277 @snova-jorgep