Skip to content

Conversation

@cte
Copy link
Collaborator

@cte cte commented Sep 16, 2025

Important

Enhanced model ID handling and validation for dynamic providers, updated UI components, and incremented package version.

  • Behavior:
    • Introduced modelIdKeysByProvider in provider-settings.ts to map providers to their model ID keys.
    • Updated getModelId() in provider-settings.ts to use modelIdKeys.
    • Added isTypicalProvider() and modelIdKeysByProvider to handle typical providers.
    • Enhanced webviewMessageHandler.ts to handle model fetching for dynamic providers.
  • Validation:
    • Updated validate.ts to use modelIdKeysByProvider for model ID validation.
    • Modified getModelValidationError() and validateApiConfiguration() to incorporate new validation logic.
  • UI Components:
    • Updated ApiOptions.tsx and provider-specific components to use new model ID logic.
    • Added handling for new provider types in HuggingFace.tsx, LiteLLM.tsx, and Unbound.tsx.
  • Misc:
    • Incremented version in package.metadata.json from 1.78.0 to 1.79.0.

This description was created by Ellipsis for 1293aa8. You can customize this summary. It will automatically update as commits are pushed.

@cte cte requested review from jr and mrubens as code owners September 16, 2025 00:12
@dosubot dosubot bot added the size:M This PR changes 30-99 lines, ignoring generated files. label Sep 16, 2025
cursor[bot]

This comment was marked as outdated.

Copy link
Contributor

@roomote roomote bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your contribution! I've reviewed the changes and found that the refactoring improves type safety nicely. The const assertion on modelIdKeys and the new ModelIdKey type are good improvements. I have some suggestions for further improvements to reduce code duplication and enhance maintainability.

@hannesrudolph hannesrudolph added the Issue/PR - Triage New issue. Needs quick review to confirm validity and assign labels. label Sep 16, 2025
Copy link
Collaborator

@jr jr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Roomote's suggestion about webview-ui/src/utils/validate.ts seems interesting but also fine to do as a follow-up.

@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Sep 16, 2025
@dosubot dosubot bot added size:L This PR changes 100-499 lines, ignoring generated files. and removed size:M This PR changes 30-99 lines, ignoring generated files. labels Sep 16, 2025
cursor[bot]

This comment was marked as outdated.

@RooCodeInc RooCodeInc deleted a comment from roomote bot Sep 16, 2025
@dosubot dosubot bot added size:XL This PR changes 500-999 lines, ignoring generated files. and removed size:L This PR changes 100-499 lines, ignoring generated files. labels Sep 16, 2025
@cte
Copy link
Collaborator Author

cte commented Sep 16, 2025

Roomote's suggestion about webview-ui/src/utils/validate.ts seems interesting but also fine to do as a follow-up.

I DRY'd up webview-ui/src/utils/validate.ts, but it can probably be simplified even further.

cursor[bot]

This comment was marked as outdated.

@daniel-lxs daniel-lxs moved this from Triage to PR [Needs Review] in Roo Code Roadmap Sep 16, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

lgtm This PR has been approved by a maintainer PR - Draft / In Progress size:XL This PR changes 500-999 lines, ignoring generated files.

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

4 participants