Skip to content

Conversation

@roomote
Copy link
Contributor

@roomote roomote bot commented Sep 12, 2025

Description

This PR addresses Issue #7941 by replacing the "+" icon with a compose/pencil icon for the "New Task" button in the top bar.

Changes

  • Changed icon from $(add) to $(edit) in src/package.json for the plusButtonClicked command
  • Updated test expectations in packages/build/src/__tests__/index.test.ts to reflect the icon change

Motivation

The edit/pencil icon better conveys "start composing a task" rather than "add", providing a more intuitive user experience.

Testing

  • ✅ All tests pass
  • ✅ Linting checks pass
  • ✅ Type checking passes

Screenshots

The $(edit) icon is a standard VS Code codicon that displays as a pencil/compose icon and is designed to work well across all themes (light, dark, and high-contrast).

Fixes #7941


Important

Replaces the '+' icon with a pencil icon for the 'New Task' button, updating src/package.json and test expectations in index.test.ts.

  • Behavior:
    • Replaces $(add) icon with $(edit) icon for plusButtonClicked command in src/package.json.
    • Updates test expectations in index.test.ts to reflect icon change.
  • Motivation:
    • The pencil icon better conveys the action of composing a new task, improving user experience.
  • Testing:
    • All tests, linting, and type checks pass.

This description was created by Ellipsis for fc14f7d. You can customize this summary. It will automatically update as commits are pushed.

- Changed icon from $(add) to $(edit) in src/package.json
- Updated test expectations in packages/build/src/__tests__/index.test.ts
- Addresses issue #7941 to better convey "start composing a task"
@roomote roomote bot requested review from cte, jr and mrubens as code owners September 12, 2025 22:03
@dosubot dosubot bot added size:XS This PR changes 0-9 lines, ignoring generated files. UI/UX UI/UX related or focused labels Sep 12, 2025
Copy link
Contributor Author

@roomote roomote bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I reviewed my own code and found it surprisingly coherent. Must be a bug in my review module.

"command": "roo-cline.plusButtonClicked",
"title": "%command.newTask.title%",
"icon": "$(add)"
"icon": "$(edit)"
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The icon change looks good and aligns with the requirement. Is there a reason we're not also updating the command identifier from plusButtonClicked to something like newTaskButtonClicked for better semantic clarity? This could be done in a follow-up PR to avoid breaking changes.

command: "roo-cline.plusButtonClicked",
title: "%command.newTask.title%",
icon: "$(add)",
icon: "$(edit)",
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch updating the test expectations! Have we considered adding a test case that specifically validates the icon rendering or at least documents why we chose over other compose-related icons like or ``?

@hannesrudolph hannesrudolph added the Issue/PR - Triage New issue. Needs quick review to confirm validity and assign labels. label Sep 12, 2025
@daniel-lxs daniel-lxs moved this from Triage to PR [Needs Prelim Review] in Roo Code Roadmap Sep 12, 2025
@hannesrudolph hannesrudolph added PR - Needs Preliminary Review and removed Issue/PR - Triage New issue. Needs quick review to confirm validity and assign labels. labels Sep 12, 2025
Copy link
Member

@daniel-lxs daniel-lxs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Sep 15, 2025
@daniel-lxs daniel-lxs moved this from PR [Needs Prelim Review] to PR [Needs Review] in Roo Code Roadmap Sep 15, 2025
@mrubens mrubens merged commit fc9c395 into main Sep 16, 2025
29 checks passed
@mrubens mrubens deleted the feature/replace-plus-icon-with-compose branch September 16, 2025 15:55
@github-project-automation github-project-automation bot moved this from PR [Needs Review] to Done in Roo Code Roadmap Sep 16, 2025
@github-project-automation github-project-automation bot moved this from New to Done in Roo Code Roadmap Sep 16, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

lgtm This PR has been approved by a maintainer PR - Needs Review size:XS This PR changes 0-9 lines, ignoring generated files. UI/UX UI/UX related or focused

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

[ENHANCEMENT] Replace top-bar + with compose icon for New Task

5 participants