-
Notifications
You must be signed in to change notification settings - Fork 2.8k
feat: Replace + icon with edit icon for New Task button #7942
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
- Changed icon from $(add) to $(edit) in src/package.json - Updated test expectations in packages/build/src/__tests__/index.test.ts - Addresses issue #7941 to better convey "start composing a task"
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I reviewed my own code and found it surprisingly coherent. Must be a bug in my review module.
| "command": "roo-cline.plusButtonClicked", | ||
| "title": "%command.newTask.title%", | ||
| "icon": "$(add)" | ||
| "icon": "$(edit)" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The icon change looks good and aligns with the requirement. Is there a reason we're not also updating the command identifier from plusButtonClicked to something like newTaskButtonClicked for better semantic clarity? This could be done in a follow-up PR to avoid breaking changes.
| command: "roo-cline.plusButtonClicked", | ||
| title: "%command.newTask.title%", | ||
| icon: "$(add)", | ||
| icon: "$(edit)", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good catch updating the test expectations! Have we considered adding a test case that specifically validates the icon rendering or at least documents why we chose over other compose-related icons like or ``?
daniel-lxs
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Description
This PR addresses Issue #7941 by replacing the "+" icon with a compose/pencil icon for the "New Task" button in the top bar.
Changes
$(add)to$(edit)insrc/package.jsonfor theplusButtonClickedcommandpackages/build/src/__tests__/index.test.tsto reflect the icon changeMotivation
The edit/pencil icon better conveys "start composing a task" rather than "add", providing a more intuitive user experience.
Testing
Screenshots
The
$(edit)icon is a standard VS Code codicon that displays as a pencil/compose icon and is designed to work well across all themes (light, dark, and high-contrast).Fixes #7941
Important
Replaces the '+' icon with a pencil icon for the 'New Task' button, updating
src/package.jsonand test expectations inindex.test.ts.$(add)icon with$(edit)icon forplusButtonClickedcommand insrc/package.json.index.test.tsto reflect icon change.This description was created by
for fc14f7d. You can customize this summary. It will automatically update as commits are pushed.