Cloud: remove extension_bridge_enabled for personal users #7638
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dosubot
bot
added
the
size:S
mrubens
approved these changes
Sep 3, 2025
![ellipsis-dev[bot]](https://avatars.githubusercontent.com/in/64358?s=60&v=4){kind=small}
| if (userData.public_metadata?.extension_bridge_enabled === true) { | ||
| extensionBridgeEnabled = true | ||
| } | ||
| let extensionBridgeEnabled = true |
Contributor
There was a problem hiding this comment.
Business logic change: For personal users, extensionBridgeEnabled is now always set to true. Please add a clarifying comment explaining that personal accounts always have the extension bridge enabled and that the user metadata flag is no longer used.
![roomote[bot]](https://avatars.githubusercontent.com/in/1546624?s=60&v=4){kind=small}
| if (userData.public_metadata?.extension_bridge_enabled === true) { | ||
| extensionBridgeEnabled = true | ||
| } | ||
| let extensionBridgeEnabled = true |
Contributor
There was a problem hiding this comment.
Is this intentional as a breaking change? The default changing from to could affect existing users who haven't explicitly set this flag. Should there be a migration strategy or announcement for this change?
hannesrudolph
added
the
Issue/PR - Triage
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Important
Default
extensionBridgeEnabledtotrueand prioritize organization settings over user settings inWebAuthService.extensionBridgeEnabledtotrueinWebAuthService.extension_bridge_enabledin user metadata.extension_bridge_enabledover user setting.WebAuthService.spec.tsto setextensionBridgeEnabledtotruein test cases.This description was created by
for e7922ff. You can customize this summary. It will automatically update as commits are pushed.