-
Notifications
You must be signed in to change notification settings - Fork 2.8k
VSCode shim + basic cli #10452
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
VSCode shim + basic cli #10452
Conversation
All previously flagged issues have been addressed. No new issues found in the latest commit (f8d14c8).
Mention @roomote in a comment to request specific changes to this pull request or fix all unresolved issues. |
apps/cli/src/extension-host.ts
Outdated
| this.setupQuietMode() | ||
|
|
||
| // Initialize debug log for streaming analysis | ||
| this.initDebugLog() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This unconditionally creates a cli-stream-debug.log file in the workspace directory every time the CLI is activated. This could clutter user workspaces with debug artifacts. Consider gating this behind the verbose option or a dedicated debug flag.
Fix it with Roo Code or mention @roomote and request a fix.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@roomote We don't need this log file anymore - please remove it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixaroo
See task on Roo Cloud
Fixed the reported issue. All local checks passed.
apps/cli/src/extension-host.ts
Outdated
| import path from "path" | ||
| import { fileURLToPath } from "url" | ||
| import fs from "fs" | ||
| import ora, { type Ora } from "ora" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The ora package is imported but all spinner methods (startSpinner, updateSpinner, stopSpinner) are disabled no-ops, and the spinner property (line 63) is never used. Consider removing the import and related dead code, or implementing the spinner functionality properly.
Fix it with Roo Code or mention @roomote and request a fix.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@roomote Please fix.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixaroo
See task on Roo Cloud
Fixed the reported issue. Removed the unused ora import, spinner property, and disabled spinner methods from the CLI extension host. All local checks passed.
…cli to @roo-code/vscode-shim
|
Generated with ❤️ by ellipsis.dev |
|
Generated with ❤️ by ellipsis.dev |
|
Generated with ❤️ by ellipsis.dev |
Big shout-out to Kilo Code for the idea and execution on the VSCode compatibility layer. Very clever solution.
Important
Adds a CLI for Roo Code with a VSCode API shim, enabling command line execution and extensive testing.
@roo-code/clifor running Roo Code agent from the command line.index.tsand task execution inextension-host.ts.@roo-code/vscode-shimto provide a VSCode API compatibility layer.Uri,Position,Range, and APIs likeWindowAPI,WorkspaceAPI.__tests__directories.package.jsonand addseslint.config.mjsfor linting.tsup.config.tsandvitest.config.tsfor build and test configurations.This description was created by
for e74bbd3. You can customize this summary. It will automatically update as commits are pushed.