fix: add type check for lastMessage.text in TTS useEffect #10431
Conversation
Fixes #10430 The TTS useEffect was calling .startsWith() on lastMessage.text after only checking if it was truthy. If text was a non-string truthy value (array, object, or number), this would crash with "Q.text.startsWith is not a function". Changed the truthy check to an explicit type check: typeof lastMessage.text === "string"
Review complete. No issues found. The change from a truthy check to an explicit Mention @roomote in a comment to request specific changes to this pull request or fix all unresolved issues. |
dosubot
bot
added
size:XS
Review complete. No issues found. The change from a truthy check to an explicit Mention @roomote in a comment to request specific changes to this pull request or fix all unresolved issues. |
This PR attempts to address Issue #10430.
Problem
The TTS (text-to-speech)
useEffectinChatView.tsxwas crashing withTypeError: Q.text.startsWith is not a functionbecause it only checked iflastMessage.textwas truthy before calling.startsWith(). Iftextwas a non-string truthy value (array, object, or number), this would throw an error.Solution
Changed line 1019 from a truthy check to an explicit type check:
This ensures
.startsWith()will only be called on actual string values.Testing
Feedback and guidance are welcome.
Important
Fixes
TypeErrorinChatView.tsxby ensuringlastMessage.textis a string before calling.startsWith().TypeErrorinuseEffectinChatView.tsxby changinglastMessage.textcheck from truthy totypeof lastMessage.text === "string"..startsWith()is only called on strings, preventing crashes whentextis non-string.ChatViewtests pass.This description was created by
for 491abe4. You can customize this summary. It will automatically update as commits are pushed.