fix: emit tool_call_end events in BaseOpenAiCompatibleProvider #10293
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The BaseOpenAiCompatibleProvider was not emitting tool_call_end events when the API stream ended with finish_reason === 'tool_calls'. This could cause the extension to appear stuck waiting for more stream data. - Added tracking of active tool call IDs in createMessage() - When finish_reason === 'tool_calls', emit tool_call_end events for all tracked tool calls - Added test coverage for single and parallel tool call scenarios - Matches the pattern used by OpenAI handler (PR #10280) Affects ZAi and other providers extending this base class.
dosubot
bot
added
size:L
Contributor
Reviewed
Mention @roomote in a comment to request specific changes to this pull request or fix all unresolved issues. |
daniel-lxs
approved these changes
Dec 23, 2025
mrubens
approved these changes
Dec 23, 2025
hannesrudolph
added
the
Issue/PR - Triage
![roomote[bot]](https://avatars.githubusercontent.com/in/1546624?s=60&v=4){kind=small}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
The
BaseOpenAiCompatibleProviderwas not emittingtool_call_endevents when the API stream ended withfinish_reason === 'tool_calls'. This could cause the extension to appear stuck waiting for more stream data.This is the same fix applied in PR #10280 to the OpenAI handler, now applied to the base class that ZAi and other OpenAI-compatible providers extend.
Changes
src/api/providers/base-openai-compatible-provider.tscreateMessage()finish_reason === 'tool_calls', emittool_call_endevents for all tracked tool callssrc/api/providers/__tests__/base-openai-compatible-provider.spec.tstool_call_endevents are emitted whenfinish_reason === 'tool_calls'finish_reasonis nottool_callsAffected Providers
BaseOpenAiCompatibleProvider)Related
Important
Fixes
BaseOpenAiCompatibleProviderto emittool_call_endevents whenfinish_reason === 'tool_calls', preventing the extension from appearing stuck.base-openai-compatible-provider.ts, added tracking of active tool call IDs increateMessage().tool_call_endevents whenfinish_reason === 'tool_calls'for all tracked tool calls.base-openai-compatible-provider.spec.ts, added tests to verifytool_call_endevents are emitted correctly.tool_callsfinish reasons.BaseOpenAiCompatibleProvider.This description was created by
for 17cfa2b. You can customize this summary. It will automatically update as commits are pushed.