Skip to content

Conversation

@brunobergher
Copy link
Collaborator

@brunobergher brunobergher commented Dec 18, 2025

It's still too much work to understand some errors, this captures more task detail to help with debugging.
We already have a good way of pulling out this info, but it's behind the debug flag and away from the context of the task.

Changes

  • Wire the chat error details dialog to request a downloadable diagnostics bundle from the extension, containing error metadata and full API conversation history.
  • Generate a structured JSON diagnostics file in a temporary location and open it automatically in VS Code so users can inspect/redact before sharing.
  • Add unit coverage in both the extension backend and webview UI to validate diagnostics generation, file I/O, and webview messaging payloads.
  • Update error-details copy and introduce a dedicated “Get detailed error info” action, localized across supported languages.
Screenshot 2025-12-18 at 15 52 52 Screenshot 2025-12-18 at 15 54 45
  • Testing
  • pnpm lint
  • pnpm check-types
  • pnpm test (fails in @roo-code/vscode-webview Bedrock provider tests; proceeding as requested for this branch).

Important

Adds downloadable error diagnostics feature, generating JSON files with error metadata and API history, accessible via a new UI action.

  • Backend (webview):
    • generateErrorDiagnostics (diagnosticsHandler.ts): Creates JSON diagnostics with error metadata and API history, saves to temp file, opens in VS Code.
    • Message handling: Adds downloadErrorDiagnostics handling in webviewMessageHandler.ts.
    • Types: Adds downloadErrorDiagnostics to WebviewMessage.
  • Frontend (webview-ui):
    • Error dialog action: Adds "Get detailed error info" button in ErrorRow.tsx to trigger diagnostics download.
  • Tests:
    • Adds unit tests for diagnostics generation (diagnosticsHandler.spec.ts), message routing (webviewMessageHandler.spec.ts), and UI messaging (ErrorRow.spec.tsx).
  • Localization:
    • Updates translations for chat:errorDetails.diagnostics across supported locales.

This description was created by Ellipsis for ab41d9f. You can customize this summary. It will automatically update as commits are pushed.



Note

Adds a diagnostics download flow that packages error metadata and API history into a temp JSON and opens it in VS Code, wired from the chat error UI.

  • Backend:
    • Diagnostics generation: New generateErrorDiagnostics in src/core/webview/diagnosticsHandler.ts reads api_conversation_history.json, writes temp roo-diagnostics-*.json, and opens it via VS Code.
    • Message handling: src/core/webview/webviewMessageHandler.ts handles downloadErrorDiagnostics (errors if no active task) and logs/open errors accordingly.
    • Types: Extend WebviewMessage with "downloadErrorDiagnostics".
  • Frontend:
    • Chat error UI: webview-ui/src/components/chat/ErrorRow.tsx adds a “Get detailed error info” action (posts downloadErrorDiagnostics) and adjusts copy button label.
  • Tests:
    • Add unit tests for diagnostics generation and webview wiring in src/core/webview/__tests__/*.spec.ts and UI tests in webview-ui/src/components/chat/__tests__/ErrorRow.spec.tsx.
  • Localization:
    • Add/update strings for diagnostics action across multiple locales under webview-ui/src/i18n/locales/*/chat.json.

Written by Cursor Bugbot for commit ab41d9f. This will update automatically on new commits. Configure here.

@roomote
Copy link
Contributor

roomote bot commented Dec 18, 2025

Rooviewer Clock   See task on Roo Cloud

All issues have been resolved. Latest commit removes unused Info import to fix linter error. LGTM!

  • Test assertion in webviewMessageHandler.spec.ts expects outdated header comment string (will cause test failure)
Previous reviews

Mention @roomote in a comment to request specific changes to this pull request or fix all unresolved issues.

Co-authored-by: roomote[bot] <219738659+roomote[bot]@users.noreply.github.com>
@brunobergher brunobergher marked this pull request as ready for review December 18, 2025 17:00
@dosubot dosubot bot added size:L This PR changes 100-499 lines, ignoring generated files. Enhancement New feature or request UI/UX UI/UX related or focused labels Dec 18, 2025
@hannesrudolph hannesrudolph added the Issue/PR - Triage New issue. Needs quick review to confirm validity and assign labels. label Dec 18, 2025
@roomote
Copy link
Contributor

roomote bot commented Dec 18, 2025

Rooviewer Clock   See task on Roo Cloud

All issues from previous review have been addressed.

  • Test assertion in webviewMessageHandler.spec.ts expects outdated header comment string (will cause test failure)

Mention @roomote in a comment to request specific changes to this pull request or fix all unresolved issues.

@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Dec 19, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Enhancement New feature or request Issue/PR - Triage New issue. Needs quick review to confirm validity and assign labels. lgtm This PR has been approved by a maintainer size:L This PR changes 100-499 lines, ignoring generated files. UI/UX UI/UX related or focused

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

5 participants