fix: add userAgentAppId to Bedrock embedder for code indexing #10166
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds userAgentAppId configuration to the BedrockRuntimeClient in the code indexing embedder, matching the implementation pattern already used in the main Bedrock API provider. This enables proper user agent identification in CloudTrail AWS requests when using Bedrock for code indexing embeddings. Fixes #10165
Contributor
Author
Review complete. No issues found. This PR correctly adds Mention @roomote in a comment to request specific changes to this pull request or fix all unresolved issues. |
dosubot
bot
added
size:XS
Contributor
Author
Review complete. No issues found. This PR correctly adds Mention @roomote in a comment to request specific changes to this pull request or fix all unresolved issues. |
mrubens
approved these changes
Dec 18, 2025
github-project-automation
bot
moved this from PR [Needs Prelim Review]
to Done
in Roo Code Roadmap
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related GitHub Issue
Closes: #10165
Description
This PR adds the
userAgentAppIdconfiguration to the BedrockRuntimeClient in the code indexing embedder, matching the implementation pattern already used in the main Bedrock API provider atsrc/api/providers/bedrock.ts:255.Key changes:
Packagefrom../../../shared/packageuserAgentAppId: \RooCode#${Package.version}`` to the BedrockRuntimeClient configurationThis enables proper user agent identification in CloudTrail AWS requests when using Bedrock for code indexing embeddings.
Test Procedure
cd src && npx vitest run services/code-index/embedders/__tests__/bedrock.spec.ts- all 25 tests passcd src && npx tsc --noEmit --skipLibCheck- no errorsTo verify the fix:
userAgentfield in CloudTrail AWS requests - should now includeapp/RooCode#X.X.XPre-Submission Checklist
Documentation Updates
Additional Notes
This is a simple two-line fix that matches the existing pattern used in the main Bedrock provider. Feedback and guidance are welcome.
Important
Adds
userAgentAppIdtoBedrockRuntimeClientinbedrock.tsfor user agent identification in AWS requests.userAgentAppId:RooCode#${Package.version}toBedrockRuntimeClientinbedrock.ts` for user agent identification in AWS requests.Packagefrom../../../shared/packageinbedrock.ts.This description was created by
for e972d32. You can customize this summary. It will automatically update as commits are pushed.