feat(read-file): implement incremental token-budgeted file reading #10052
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dosubot
bot
added
size:XXL
Contributor
Review complete. No issues found. This PR implements incremental token-budgeted file reading with a clean single-pass approach that replaces the previous two-step validate/truncate pattern. The implementation is correct and well-tested. Mention @roomote in a comment to request specific changes to this pull request or fix all unresolved issues. |
![ellipsis-dev[bot]](https://avatars.githubusercontent.com/in/64358?s=60&v=4){kind=small}
| let isProcessing = false | ||
| let shouldClose = false | ||
|
|
||
| const readStream = createReadStream(filePath) |
Contributor
There was a problem hiding this comment.
Consider specifying an explicit encoding (e.g. utf8) when creating the read stream to ensure text is decoded correctly.
Suggested change
| const readStream = createReadStream(filePath) | |
| const readStream = createReadStream(filePath, { encoding: 'utf8' }) |
![roomote[bot]](https://avatars.githubusercontent.com/in/1546624?s=60&v=4){kind=small}
hannesrudolph
added
the
Issue/PR - Triage
cte
approved these changes
Dec 15, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Important
Implements token-budgeted file reading in
ReadFileTool.tsusingreadFileWithTokenBudget, replacing previous validation methods.readFileWithTokenBudgetinReadFileTool.tsfor token-budgeted file reading.validateFileTokenBudgetandtruncateFileContentwithreadFileWithTokenBudget.readFileWithTokenBudgetinread-file-with-budget.spec.ts.readFileTool.spec.tsto mock and test new file reading behavior.fileTokenBudget.spec.tsas it's no longer needed.FILE_READ_BUDGET_PERCENTto 60% infileTokenBudget.ts.This description was created by
for 23b306a. You can customize this summary. It will automatically update as commits are pushed.