Skip to content

Commit f070c84

Browse files
hannesrudolphhannesrudolph
committed
chore: remove orphaned maxConcurrentFileReads setting
This setting was never used after removing the batch file reading system. Removes dead code from UI, state management, and types.
1 parent 3770f2e commit f070c84

16 files changed

+0
-60
lines changed

‎packages/types/src/global-settings.ts‎

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -89,7 +89,6 @@ export const globalSettingsSchema = z.object({
8989
allowedMaxCost: z.number().nullish(),
9090
autoCondenseContext: z.boolean().optional(),
9191
autoCondenseContextPercent: z.number().optional(),
92-
maxConcurrentFileReads: z.number().optional(),
9392

9493
/**
9594
* Whether to include current time in the environment details

‎packages/types/src/vscode-extension-host.ts‎

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -300,7 +300,6 @@ export type ExtensionState = Pick<
300300
| "ttsSpeed"
301301
| "soundEnabled"
302302
| "soundVolume"
303-
| "maxConcurrentFileReads"
304303
| "terminalOutputLineLimit"
305304
| "terminalOutputCharacterLimit"
306305
| "terminalShellIntegrationTimeout"

‎src/core/prompts/__tests__/sections.spec.ts‎

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -70,7 +70,6 @@ describe("getRulesSection", () => {
7070

7171
it("includes vendor confidentiality section when isStealthModel is true", () => {
7272
const settings = {
73-
maxConcurrentFileReads: 5,
7473
todoListEnabled: true,
7574
useAgentRules: true,
7675
newTaskRequireTodos: false,
@@ -88,7 +87,6 @@ describe("getRulesSection", () => {
8887

8988
it("excludes vendor confidentiality section when isStealthModel is false", () => {
9089
const settings = {
91-
maxConcurrentFileReads: 5,
9290
todoListEnabled: true,
9391
useAgentRules: true,
9492
newTaskRequireTodos: false,
@@ -103,7 +101,6 @@ describe("getRulesSection", () => {
103101

104102
it("excludes vendor confidentiality section when isStealthModel is undefined", () => {
105103
const settings = {
106-
maxConcurrentFileReads: 5,
107104
todoListEnabled: true,
108105
useAgentRules: true,
109106
newTaskRequireTodos: false,

‎src/core/prompts/__tests__/system-prompt.spec.ts‎

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -496,7 +496,6 @@ describe("SYSTEM_PROMPT", () => {
496496

497497
it("should exclude update_todo_list tool when todoListEnabled is false", async () => {
498498
const settings = {
499-
maxConcurrentFileReads: 5,
500499
todoListEnabled: false,
501500
useAgentRules: true,
502501
newTaskRequireTodos: false,
@@ -527,7 +526,6 @@ describe("SYSTEM_PROMPT", () => {
527526

528527
it("should include update_todo_list tool when todoListEnabled is true", async () => {
529528
const settings = {
530-
maxConcurrentFileReads: 5,
531529
todoListEnabled: true,
532530
useAgentRules: true,
533531
newTaskRequireTodos: false,
@@ -558,7 +556,6 @@ describe("SYSTEM_PROMPT", () => {
558556

559557
it("should include update_todo_list tool when todoListEnabled is undefined", async () => {
560558
const settings = {
561-
maxConcurrentFileReads: 5,
562559
todoListEnabled: true,
563560
useAgentRules: true,
564561
newTaskRequireTodos: false,
@@ -589,7 +586,6 @@ describe("SYSTEM_PROMPT", () => {
589586

590587
it("should include native tool instructions", async () => {
591588
const settings = {
592-
maxConcurrentFileReads: 5,
593589
todoListEnabled: true,
594590
useAgentRules: true,
595591
newTaskRequireTodos: false,

‎src/core/prompts/sections/__tests__/custom-instructions.spec.ts‎

Lines changed: 0 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -543,7 +543,6 @@ describe("addCustomInstructions", () => {
543543
"test-mode",
544544
{
545545
settings: {
546-
maxConcurrentFileReads: 5,
547546
todoListEnabled: true,
548547
useAgentRules: true,
549548
newTaskRequireTodos: false,
@@ -575,7 +574,6 @@ describe("addCustomInstructions", () => {
575574
"test-mode",
576575
{
577576
settings: {
578-
maxConcurrentFileReads: 5,
579577
todoListEnabled: true,
580578
useAgentRules: false,
581579
newTaskRequireTodos: false,
@@ -636,7 +634,6 @@ describe("addCustomInstructions", () => {
636634
"test-mode",
637635
{
638636
settings: {
639-
maxConcurrentFileReads: 5,
640637
todoListEnabled: true,
641638
useAgentRules: true,
642639
newTaskRequireTodos: false,
@@ -682,7 +679,6 @@ describe("addCustomInstructions", () => {
682679
"test-mode",
683680
{
684681
settings: {
685-
maxConcurrentFileReads: 5,
686682
todoListEnabled: true,
687683
useAgentRules: true,
688684
newTaskRequireTodos: false,
@@ -750,7 +746,6 @@ describe("addCustomInstructions", () => {
750746
"test-mode",
751747
{
752748
settings: {
753-
maxConcurrentFileReads: 5,
754749
todoListEnabled: true,
755750
useAgentRules: true,
756751
newTaskRequireTodos: false,
@@ -802,7 +797,6 @@ describe("addCustomInstructions", () => {
802797
"test-mode",
803798
{
804799
settings: {
805-
maxConcurrentFileReads: 5,
806800
todoListEnabled: true,
807801
useAgentRules: true,
808802
newTaskRequireTodos: false,
@@ -856,7 +850,6 @@ describe("addCustomInstructions", () => {
856850
"test-mode",
857851
{
858852
settings: {
859-
maxConcurrentFileReads: 5,
860853
todoListEnabled: true,
861854
useAgentRules: true,
862855
newTaskRequireTodos: false,
@@ -902,7 +895,6 @@ describe("addCustomInstructions", () => {
902895
"test-mode",
903896
{
904897
settings: {
905-
maxConcurrentFileReads: 5,
906898
todoListEnabled: true,
907899
useAgentRules: true,
908900
newTaskRequireTodos: false,

‎src/core/prompts/types.ts‎

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,6 @@
22
* Settings passed to system prompt generation functions
33
*/
44
export interface SystemPromptSettings {
5-
maxConcurrentFileReads: number
65
todoListEnabled: boolean
76
browserToolEnabled?: boolean
87
useAgentRules: boolean

‎src/core/task/Task.ts‎

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -3636,7 +3636,6 @@ export class Task extends EventEmitter<TaskEvents> implements TaskLike {
36363636
enableMcpServerCreation,
36373637
browserToolEnabled,
36383638
language,
3639-
maxConcurrentFileReads,
36403639
apiConfiguration,
36413640
enableSubfolderRules,
36423641
} = state ?? {}
@@ -3675,7 +3674,6 @@ export class Task extends EventEmitter<TaskEvents> implements TaskLike {
36753674
language,
36763675
rooIgnoreInstructions,
36773676
{
3678-
maxConcurrentFileReads: maxConcurrentFileReads ?? 5,
36793677
todoListEnabled: apiConfiguration?.todoListEnabled ?? true,
36803678
browserToolEnabled: browserToolEnabled ?? true,
36813679
useAgentRules:

‎src/core/webview/ClineProvider.ts‎

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -2057,7 +2057,6 @@ export class ClineProvider
20572057
publicSharingEnabled,
20582058
organizationAllowList,
20592059
organizationSettingsVersion,
2060-
maxConcurrentFileReads,
20612060
customCondensingPrompt,
20622061
codebaseIndexConfig,
20632062
codebaseIndexModels,
@@ -2192,7 +2191,6 @@ export class ClineProvider
21922191
renderContext: this.renderContext,
21932192
maxImageFileSize: maxImageFileSize ?? 5,
21942193
maxTotalImageSize: maxTotalImageSize ?? 20,
2195-
maxConcurrentFileReads: maxConcurrentFileReads ?? 5,
21962194
settingsImportedAt: this.settingsImportedAt,
21972195
terminalCompressProgressBar: terminalCompressProgressBar ?? true,
21982196
hasSystemPromptOverride,
@@ -2437,7 +2435,6 @@ export class ClineProvider
24372435
enableSubfolderRules: stateValues.enableSubfolderRules ?? false,
24382436
maxImageFileSize: stateValues.maxImageFileSize ?? 5,
24392437
maxTotalImageSize: stateValues.maxTotalImageSize ?? 20,
2440-
maxConcurrentFileReads: stateValues.maxConcurrentFileReads ?? 5,
24412438
historyPreviewCollapsed: stateValues.historyPreviewCollapsed ?? false,
24422439
reasoningBlockCollapsed: stateValues.reasoningBlockCollapsed ?? true,
24432440
enterBehavior: stateValues.enterBehavior ?? "send",

‎src/core/webview/__tests__/generateSystemPrompt.browser-capability.spec.ts‎

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -63,7 +63,6 @@ function makeProviderStub() {
6363
enableMcpServerCreation: false,
6464
browserToolEnabled: true, // critical: enabled in settings
6565
language: "en",
66-
maxConcurrentFileReads: 5,
6766
}),
6867
} as any
6968
}

‎src/core/webview/generateSystemPrompt.ts‎

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -20,7 +20,6 @@ export const generateSystemPrompt = async (provider: ClineProvider, message: Web
2020
enableMcpServerCreation,
2121
browserToolEnabled,
2222
language,
23-
maxConcurrentFileReads,
2423
enableSubfolderRules,
2524
} = await provider.getState()
2625

@@ -72,7 +71,6 @@ export const generateSystemPrompt = async (provider: ClineProvider, message: Web
7271
language,
7372
rooIgnoreInstructions,
7473
{
75-
maxConcurrentFileReads: maxConcurrentFileReads ?? 5,
7674
todoListEnabled: apiConfiguration?.todoListEnabled ?? true,
7775
useAgentRules: vscode.workspace.getConfiguration(Package.name).get<boolean>("useAgentRules") ?? true,
7876
enableSubfolderRules: enableSubfolderRules ?? false,

0 commit comments

Comments
 (0)