Fix preserveReasoning flag to control API reasoning inclusion

daniel-lxs · daniel-lxs · commit b13938ecd8be · 2025-11-20T18:58:46.000-05:00
Changes:
1. Removed hardcoded &lt;think&gt; tag logic in streaming
   - Previously hardcoded reasoning into assistant message text
   - Now passes reasoning to addToApiConversationHistory as parameter

2. Updated buildCleanConversationHistory to respect preserveReasoning flag
   - When preserveReasoning: true → reasoning block included in API requests
   - When preserveReasoning: false/undefined → reasoning stripped from API
   - Reasoning stored in history for all cases

3. Added temporary debug logs to base-openai-compatible-provider.ts
   - Shows preserveReasoning flag value
   - Logs reasoning blocks in incoming messages
   - Logs &lt;think&gt; tags in converted messages sent to API
diff --git a/src/core/task/Task.ts b/src/core/task/Task.ts
@@ -2647,21 +2647,14 @@ export class Task extends EventEmitter<TaskEvents> implements TaskLike {
 						})
 					}
 
-					// Check if we should preserve reasoning in the assistant message
-					let finalAssistantMessage = assistantMessage
-					if (reasoningMessage && streamModelInfo.preserveReasoning) {
-						// Prepend reasoning in XML tags to the assistant message so it's included in API history
-						finalAssistantMessage = `<think>${reasoningMessage}</think>\n${assistantMessage}`
-					}
-
 					// Build the assistant message content array
 					const assistantContent: Array<Anthropic.TextBlockParam | Anthropic.ToolUseBlockParam> = []
 
 					// Add text content if present
-					if (finalAssistantMessage) {
+					if (assistantMessage) {
 						assistantContent.push({
 							type: "text" as const,
-							text: finalAssistantMessage,
+							text: assistantMessage,
 						})
 					}
 
@@ -3432,16 +3425,28 @@ export class Task extends EventEmitter<TaskEvents> implements TaskLike {
 
 					continue
 				} else if (hasPlainTextReasoning) {
-					// For plain text reasoning, just strip it out and send the assistant message without it
-					// The reasoning was stored for history purposes, not for API requests
+					const reasoningBlock = first as any
+
+					// Check if the model's preserveReasoning flag is set
+					// If true, include the reasoning block in API requests
+					// If false/undefined, strip it out (stored for history only, not sent back to API)
+					const modelInfo = this.cachedStreamingModel?.info ?? this.api.getModel().info
+					const shouldPreserveForApi = modelInfo.preserveReasoning === true
+
 					let assistantContent: Anthropic.Messages.MessageParam["content"]
 
-					if (rest.length === 0) {
-						assistantContent = ""
-					} else if (rest.length === 1 && rest[0].type === "text") {
-						assistantContent = (rest[0] as Anthropic.Messages.TextBlockParam).text
+					if (shouldPreserveForApi) {
+						// Include reasoning block in the content sent to API
+						assistantContent = contentArray
 					} else {
-						assistantContent = rest
+						// Strip reasoning out - stored for history only, not sent back to API
+						if (rest.length === 0) {
+							assistantContent = ""
+						} else if (rest.length === 1 && rest[0].type === "text") {
+							assistantContent = (rest[0] as Anthropic.Messages.TextBlockParam).text
+						} else {
+							assistantContent = rest
+						}
 					}
 
 					cleanConversationHistory.push({
