docs: correct documentation about server priority order

daniel-lxs · daniel-lxs · commit ac462b243ebf · 2025-12-15T10:22:35.000-05:00
Update comments to accurately reflect that first occurrence wins based on
McpHub.getServers() order, rather than incorrectly claiming project servers
take priority. The actual behavior is that global servers are initialized first,
so global takes priority when the same server name exists in both configs.

The deduplication fix itself is correct - this is purely a documentation fix.
diff --git a/src/core/prompts/tools/native-tools/__tests__/mcp_server.spec.ts b/src/core/prompts/tools/native-tools/__tests__/mcp_server.spec.ts
@@ -78,16 +78,16 @@ describe("getMcpServerTools", () => {
 			"project",
 		)
 
-		// Project servers come before global servers (as per McpHub.notifyWebviewOfServerChanges sorting)
-		const mockHub = createMockMcpHub([projectServer, globalServer])
+		// First occurrence wins - in this test, global comes first
+		const mockHub = createMockMcpHub([globalServer, projectServer])
 
 		const result = getMcpServerTools(mockHub as McpHub)
 
 		// Should only have one tool, not two
 		expect(result).toHaveLength(1)
 		expect(getFunction(result[0]).name).toBe("mcp--context7--resolve-library-id")
-		// Project server takes priority (comes first in the list)
-		expect(getFunction(result[0]).description).toBe("Project description")
+		// First occurrence wins (global in this case)
+		expect(getFunction(result[0]).description).toBe("Global description")
 	})
 
 	it("should allow tools with different names from the same server", () => {
diff --git a/src/core/prompts/tools/native-tools/mcp_server.ts b/src/core/prompts/tools/native-tools/mcp_server.ts
@@ -5,7 +5,7 @@ import { buildMcpToolName } from "../../../../utils/mcp-name"
 /**
  * Dynamically generates native tool definitions for all enabled tools across connected MCP servers.
  * Deduplicates tools by name to prevent API errors when the same server is defined in both
- * global and project configs. Project servers take priority over global servers.
+ * global and project configs. First occurrence wins (based on McpHub.getServers() order).
  *
  * @param mcpHub The McpHub instance containing connected servers.
  * @returns An array of OpenAI.Chat.ChatCompletionTool definitions.

Original file line number	Diff line number	Diff line change
`@@ -5,7 +5,7 @@ import { buildMcpToolName } from "../../../../utils/mcp-name"`
`5`	`5`	`/**`
`6`	`6`	`* Dynamically generates native tool definitions for all enabled tools across connected MCP servers.`
`7`	`7`	`* Deduplicates tools by name to prevent API errors when the same server is defined in both`
`8`		`- * global and project configs. Project servers take priority over global servers.`
	`8`	`+ * global and project configs. First occurrence wins (based on McpHub.getServers() order).`
`9`	`9`	`*`
`10`	`10`	`* @param mcpHub The McpHub instance containing connected servers.`
`11`	`11`	`* @returns An array of OpenAI.Chat.ChatCompletionTool definitions.`