fix: move mode switch before child task creation in delegateParentAndOpenChild

hannesrudolph · hannesrudolph · commit 97f48c87997c · 2025-11-27T12:45:58.000-07:00
- Move handleModeSwitch() call BEFORE createTask() to ensure child task
  initializes with the correct mode's system prompt
- Remove redundant second handleModeSwitch() that was called after child creation
- This ensures the child's first API call uses the correct mode configuration
diff --git a/src/core/webview/ClineProvider.ts b/src/core/webview/ClineProvider.ts
@@ -3002,7 +3002,21 @@ export class ClineProvider
 			// Non-fatal: proceed with child creation even if parent cleanup had issues
 		}
 
-		// 3) Create child as sole active (parent reference preserved for lineage)
+		// 3) Switch provider mode to child's requested mode BEFORE creating the child task
+		//    This ensures the child's system prompt and configuration are based on the correct mode.
+		//    The mode switch must happen before createTask() because the Task constructor
+		//    initializes its mode from provider.getState() during initializeTaskMode().
+		try {
+			await this.handleModeSwitch(mode as any)
+		} catch (e) {
+			this.log(
+				`[delegateParentAndOpenChild] handleModeSwitch failed for mode '${mode}': ${
+					(e as Error)?.message ?? String(e)
+				}`,
+			)
+		}
+
+		// 4) Create child as sole active (parent reference preserved for lineage)
 		const child = await this.createTask(message, undefined, parent as any, { initialTodos })
 
 		// 4) Persist parent delegation metadata
@@ -3032,17 +3046,6 @@ export class ClineProvider
 			// non-fatal
 		}
 
-		// 6) Switch provider mode to child's requested mode and focus child (already focused by addClineToStack)
-		try {
-			await this.handleModeSwitch(mode as any)
-		} catch (e) {
-			this.log(
-				`[delegateParentAndOpenChild] handleModeSwitch failed for mode '${mode}': ${
-					(e as Error)?.message ?? String(e)
-				}`,
-			)
-		}
-
 		return child
 	}
 
