Skip to content

Commit 79a6f7a

Browse files
hannesrudolphhannesrudolph
committed
refactor: remove footgun prompting (file-based system prompt override)
Remove the feature that allowed overriding the entire system prompt via .roo/system-prompt-{mode} files. This removes: - Core module: loadSystemPromptFile, getSystemPromptFilePath, PromptVariables - File-based prompt bypass in SYSTEM_PROMPT generation - hasFileBasedSystemPromptOverride method and hasSystemPromptOverride state - SystemPromptWarning banner component and ChatView integration - Advanced: Override System Prompt disclosure section in ModesView - All related i18n keys across 18 locales (advanced, advancedSystemPrompt, systemPromptWarning) - Footgun reference in evals README 47 files changed, 714 deletions
1 parent 8d57da8 commit 79a6f7a

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

48 files changed

+9
-720
lines changed

‎packages/evals/README.md‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -37,7 +37,7 @@ Additionally, you'll find in Docker Desktop that database and redis services are
3737

3838
Navigate to [localhost:3446](http://localhost:3446/) in your browser and click the 🚀 button.
3939

40-
By default a evals run will run all programming exercises in [Roo Code Evals](https://github.com/RooCodeInc/Roo-Code-Evals) repository with the Claude Sonnet 4 model and default settings. For basic configuration you can specify the LLM to use and any subset of the exercises you'd like. For advanced configuration you can import a Roo Code settings file which will allow you to run the evals with Roo Code configured any way you'd like (this includes custom modes, a footgun prompt, etc).
40+
By default a evals run will run all programming exercises in [Roo Code Evals](https://github.com/RooCodeInc/Roo-Code-Evals) repository with the Claude Sonnet 4 model and default settings. For basic configuration you can specify the LLM to use and any subset of the exercises you'd like. For advanced configuration you can import a Roo Code settings file which will allow you to run the evals with Roo Code configured any way you'd like (this includes custom modes, custom instructions, etc).
4141

4242
<img width="1053" src="https://github.com/user-attachments/assets/2367eef4-6ae9-4ac2-8ee4-80f981046486" />
4343

‎packages/types/src/vscode-extension-host.ts‎

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -381,7 +381,6 @@ export type ExtensionState = Pick<
381381
lastShownAnnouncementId?: string
382382
apiModelId?: string
383383
mcpServers?: McpServer[]
384-
hasSystemPromptOverride?: boolean
385384
mdmCompliant?: boolean
386385
remoteControlEnabled: boolean
387386
taskSyncEnabled: boolean
@@ -645,7 +644,6 @@ export interface WebviewMessage {
645644
newSkillModeSlugs?: string[] // For updateSkillModes (new mode restrictions)
646645
requestId?: string
647646
ids?: string[]
648-
hasSystemPromptOverride?: boolean
649647
terminalOperation?: "continue" | "abort"
650648
messageTs?: number
651649
restoreCheckpoint?: boolean

‎src/core/prompts/__tests__/custom-system-prompt.spec.ts‎

Lines changed: 0 additions & 201 deletions
This file was deleted.

‎src/core/prompts/sections/__tests__/custom-system-prompt.spec.ts‎

Lines changed: 0 additions & 134 deletions
This file was deleted.

0 commit comments

Comments
 (0)