fix: prevent race condition in flushModels with refresh

daniel-lxs · daniel-lxs · commit 77eb3c281dc3 · 2025-11-21T12:53:34.000-05:00
Keep old cache in memory when refresh=true to avoid gap in cache
availability. This prevents getModels() from triggering a fresh API
fetch if called immediately after flushModels(router, true).

The refreshModels() function will atomically replace the memory cache
when the refresh completes, maintaining graceful degradation.
diff --git a/src/api/providers/fetchers/modelCache.ts b/src/api/providers/fetchers/modelCache.ts
@@ -258,13 +258,16 @@ export async function initializeModelCacheRefresh(): Promise<void> {
  * @param refresh - If true, immediately fetch fresh data from API
  */
 export const flushModels = async (router: RouterName, refresh: boolean = false): Promise<void> => {
-	memoryCache.del(router)
-
 	if (refresh) {
-		// Trigger background refresh - don't await to avoid blocking
+		// Don't delete memory cache - let refreshModels atomically replace it
+		// This prevents a race condition where getModels() might be called
+		// before refresh completes, avoiding a gap in cache availability
 		refreshModels({ provider: router } as GetModelsOptions).catch((error) => {
 			console.error(`[flushModels] Refresh failed for ${router}:`, error)
 		})
+	} else {
+		// Only delete memory cache when not refreshing
+		memoryCache.del(router)
 	}
 }
 
