refactor: remove redundant alias registration loop

daniel-lxs · daniel-lxs · commit 5964457597f1 · 2025-12-12T12:08:07.000-05:00
The loop in filterNativeToolsForMode that registers alias renames
for tools that are allowed and explicitly requested as aliases is
redundant. This logic is already handled in applyModelToolCustomization
at lines 195-205, which adds alias renames when processing includedTools.

The removed code was iterating over modelInfo.includedTools a second time
to add the same entries to aliasRenames that applyModelToolCustomization
had already added.
diff --git a/src/core/prompts/tools/filter-tools-for-mode.ts b/src/core/prompts/tools/filter-tools-for-mode.ts
@@ -267,16 +267,6 @@ export function filterNativeToolsForMode(
 	)
 	allowedToolNames = customizedTools
 
-	// Register alias renames for tools that are allowed and explicitly requested as aliases
-	if (modelInfo?.includedTools && modelInfo.includedTools.length > 0) {
-		for (const includedTool of modelInfo.includedTools) {
-			const canonical = resolveToolAlias(includedTool)
-			if (canonical !== includedTool && allowedToolNames.has(canonical)) {
-				aliasRenames.set(canonical, includedTool)
-			}
-		}
-	}
-
 	// Conditionally exclude codebase_search if feature is disabled or not configured
 	if (
 		!codeIndexManager ||
