perf(refactor): consolidate getState calls in resolveWebviewView

0xMink · 0xMink · commit 5519dcd18ac0 · 2026-02-08T17:44:05.000-05:00
Replace three separate this.getState().then() calls with a single
await this.getState() and destructuring. This avoids running the
full getState() method (CloudService calls, ContextProxy reads, etc.)
three times during webview view resolution.
diff --git a/src/core/webview/ClineProvider.ts b/src/core/webview/ClineProvider.ts
@@ -747,35 +747,29 @@ export class ClineProvider
 
 		// Initialize out-of-scope variables that need to receive persistent
 		// global state values.
-		this.getState().then(
-			({
-				terminalShellIntegrationTimeout = Terminal.defaultShellIntegrationTimeout,
-				terminalShellIntegrationDisabled = false,
-				terminalCommandDelay = 0,
-				terminalZshClearEolMark = true,
-				terminalZshOhMy = false,
-				terminalZshP10k = false,
-				terminalPowershellCounter = false,
-				terminalZdotdir = false,
-			}) => {
-				Terminal.setShellIntegrationTimeout(terminalShellIntegrationTimeout)
-				Terminal.setShellIntegrationDisabled(terminalShellIntegrationDisabled)
-				Terminal.setCommandDelay(terminalCommandDelay)
-				Terminal.setTerminalZshClearEolMark(terminalZshClearEolMark)
-				Terminal.setTerminalZshOhMy(terminalZshOhMy)
-				Terminal.setTerminalZshP10k(terminalZshP10k)
-				Terminal.setPowershellCounter(terminalPowershellCounter)
-				Terminal.setTerminalZdotdir(terminalZdotdir)
-			},
-		)
-
-		this.getState().then(({ ttsEnabled }) => {
-			setTtsEnabled(ttsEnabled ?? false)
-		})
+		const {
+			terminalShellIntegrationTimeout = Terminal.defaultShellIntegrationTimeout,
+			terminalShellIntegrationDisabled = false,
+			terminalCommandDelay = 0,
+			terminalZshClearEolMark = true,
+			terminalZshOhMy = false,
+			terminalZshP10k = false,
+			terminalPowershellCounter = false,
+			terminalZdotdir = false,
+			ttsEnabled,
+			ttsSpeed,
+		} = await this.getState()
 
-		this.getState().then(({ ttsSpeed }) => {
-			setTtsSpeed(ttsSpeed ?? 1)
-		})
+		Terminal.setShellIntegrationTimeout(terminalShellIntegrationTimeout)
+		Terminal.setShellIntegrationDisabled(terminalShellIntegrationDisabled)
+		Terminal.setCommandDelay(terminalCommandDelay)
+		Terminal.setTerminalZshClearEolMark(terminalZshClearEolMark)
+		Terminal.setTerminalZshOhMy(terminalZshOhMy)
+		Terminal.setTerminalZshP10k(terminalZshP10k)
+		Terminal.setPowershellCounter(terminalPowershellCounter)
+		Terminal.setTerminalZdotdir(terminalZdotdir)
+		setTtsEnabled(ttsEnabled ?? false)
+		setTtsSpeed(ttsSpeed ?? 1)
 
 		// Set up webview options with proper resource roots
 		const resourceRoots = [this.contextProxy.extensionUri]
