fix: detect tool calling support from API tool-use tag

daniel-lxs · daniel-lxs · commit 24c738728916 · 2025-11-13T09:26:05.000-05:00
- Add check for 'tool-use' tag in getRooModels() to set supportsNativeTools
- Remove hardcoded supportsNativeTools() fallback method
- Simplify getModel() to rely on API response data
- Update tests to include supportsNativeTools field
- Models now properly marked based on their actual capabilities from the API
diff --git a/src/api/providers/fetchers/__tests__/roo.spec.ts b/src/api/providers/fetchers/__tests__/roo.spec.ts
@@ -68,6 +68,7 @@ describe("getRooModels", () => {
 				supportsImages: true,
 				supportsReasoningEffort: true,
 				requiredReasoningEffort: false,
+				supportsNativeTools: false,
 				supportsPromptCache: true,
 				inputPrice: 100, // 0.0001 * 1_000_000
 				outputPrice: 200, // 0.0002 * 1_000_000
@@ -116,6 +117,7 @@ describe("getRooModels", () => {
 			supportsImages: false,
 			supportsReasoningEffort: true,
 			requiredReasoningEffort: true,
+			supportsNativeTools: false,
 			supportsPromptCache: false,
 			inputPrice: 100, // 0.0001 * 1_000_000
 			outputPrice: 200, // 0.0002 * 1_000_000
@@ -162,6 +164,7 @@ describe("getRooModels", () => {
 			supportsImages: false,
 			supportsReasoningEffort: false,
 			requiredReasoningEffort: false,
+			supportsNativeTools: false,
 			supportsPromptCache: false,
 			inputPrice: 100, // 0.0001 * 1_000_000
 			outputPrice: 200, // 0.0002 * 1_000_000
diff --git a/src/api/providers/fetchers/roo.ts b/src/api/providers/fetchers/roo.ts
@@ -92,6 +92,9 @@ export async function getRooModels(baseUrl: string, apiKey?: string): Promise<Mo
 				// Determine if the model requires reasoning effort based on tags
 				const requiredReasoningEffort = tags.includes("reasoning-required")
 
+				// Determine if the model supports native tool calling based on tags
+				const supportsNativeTools = tags.includes("tool-use")
+
 				// Parse pricing (API returns strings, convert to numbers)
 				const inputPrice = parseApiPrice(pricing.input)
 				const outputPrice = parseApiPrice(pricing.output)
@@ -104,6 +107,7 @@ export async function getRooModels(baseUrl: string, apiKey?: string): Promise<Mo
 					supportsImages,
 					supportsReasoningEffort,
 					requiredReasoningEffort,
+					supportsNativeTools,
 					supportsPromptCache: Boolean(cacheReadPrice !== undefined),
 					inputPrice,
 					outputPrice,
diff --git a/src/api/providers/roo.ts b/src/api/providers/roo.ts
@@ -249,17 +249,6 @@ export class RooHandler extends BaseOpenAiCompatibleProvider<string> {
 		}
 	}
 
-	/**
-	 * Check if a model ID supports native tool calling.
-	 * This is a fallback for models loaded dynamically that don't have explicit support flags.
-	 */
-	private supportsNativeTools(modelId: string): boolean {
-		// List of model IDs known to support native tools
-		const nativeToolModels = ["openai/gpt-5"]
-
-		return nativeToolModels.some((model) => modelId.includes(model))
-	}
-
 	override getModel() {
 		const modelId = this.options.apiModelId || rooDefaultModelId
 
@@ -268,10 +257,6 @@ export class RooHandler extends BaseOpenAiCompatibleProvider<string> {
 		const modelInfo = models[modelId]
 
 		if (modelInfo) {
-			// If model info exists but doesn't have supportsNativeTools set, check our list
-			if (modelInfo.supportsNativeTools === undefined) {
-				modelInfo.supportsNativeTools = this.supportsNativeTools(modelId)
-			}
 			return { id: modelId, info: modelInfo }
 		}
 
@@ -284,7 +269,7 @@ export class RooHandler extends BaseOpenAiCompatibleProvider<string> {
 				supportsImages: false,
 				supportsReasoningEffort: false,
 				supportsPromptCache: true,
-				supportsNativeTools: this.supportsNativeTools(modelId),
+				supportsNativeTools: false,
 				inputPrice: 0,
 				outputPrice: 0,
 			},
