fix: restore presentAssistantMessage for all partial blocks

daniel-lxs · daniel-lxs · commit 24bec99555af · 2025-12-02T17:48:05.000-05:00
PR #9542 added a condition that only called presentAssistantMessage() if there was at least one non-tool_use partial block. This broke XML protocol because XML tools are parsed from the text stream (not via native events), and when only a malformed tool_use was the partial block, presentAssistantMessage was never called, causing a hang. This commit restores the original behavior that works for both protocols.
diff --git a/src/core/task/Task.ts b/src/core/task/Task.ts
@@ -2940,9 +2940,11 @@ export class Task extends EventEmitter<TaskEvents> implements TaskLike {
 					this.assistantMessageContent = parsedBlocks
 				}
 
-				// Only present partial blocks that were just completed (from XML parsing)
-				// Native tool blocks were already presented during streaming, so don't re-present them
-				if (partialBlocks.length > 0 && partialBlocks.some((block) => block.type !== "tool_use")) {
+				// Present any partial blocks that were just completed
+				// For XML protocol: includes both text and tool_use blocks parsed from the text stream
+				// For native protocol: tool_use blocks were already presented during streaming via
+				// tool_call_partial events, but we still need to present them if they exist (e.g., malformed)
+				if (partialBlocks.length > 0) {
 					// If there is content to update then it will complete and
 					// update `this.userMessageContentReady` to true, which we
 					// `pWaitFor` before making the next request.
